From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D84C433DF for ; Sat, 4 Jul 2020 19:17:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C248207CD for ; Sat, 4 Jul 2020 19:17:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C248207CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cert.pl Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jrneW-0004NZ-6v; Sat, 04 Jul 2020 19:16:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jrneV-0004NU-9l for xen-devel@lists.xenproject.org; Sat, 04 Jul 2020 19:16:43 +0000 X-Inumbo-ID: e45ff73a-be2a-11ea-b7bb-bc764e2007e4 Received: from bagnar.nask.net.pl (unknown [195.187.242.196]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e45ff73a-be2a-11ea-b7bb-bc764e2007e4; Sat, 04 Jul 2020 19:16:42 +0000 (UTC) Received: from bagnar.nask.net.pl (unknown [172.16.9.10]) by bagnar.nask.net.pl (Postfix) with ESMTP id 4DA3EA242E; Sat, 4 Jul 2020 21:16:41 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by bagnar.nask.net.pl (Postfix) with ESMTP id 36C1BA23F8; Sat, 4 Jul 2020 21:16:40 +0200 (CEST) Received: from bagnar.nask.net.pl ([127.0.0.1]) by localhost (bagnar.nask.net.pl [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SNxKUOhn8haT; Sat, 4 Jul 2020 21:16:39 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by bagnar.nask.net.pl (Postfix) with ESMTP id 9139AA242E; Sat, 4 Jul 2020 21:16:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at bagnar.nask.net.pl Received: from bagnar.nask.net.pl ([127.0.0.1]) by localhost (bagnar.nask.net.pl [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Gz_v9F6XRqv7; Sat, 4 Jul 2020 21:16:39 +0200 (CEST) Received: from belindir.nask.net.pl (belindir-ext.nask.net.pl [195.187.242.210]) by bagnar.nask.net.pl (Postfix) with ESMTP id 5EE5DA23F8; Sat, 4 Jul 2020 21:16:39 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by belindir.nask.net.pl (Postfix) with ESMTP id 4128B22ACD; Sat, 4 Jul 2020 21:16:09 +0200 (CEST) Received: from belindir.nask.net.pl ([127.0.0.1]) by localhost (belindir.nask.net.pl [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id b7qClOMY0dAa; Sat, 4 Jul 2020 21:16:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by belindir.nask.net.pl (Postfix) with ESMTP id 9B2A222EFD; Sat, 4 Jul 2020 21:16:03 +0200 (CEST) X-Virus-Scanned: amavisd-new at belindir.nask.net.pl Received: from belindir.nask.net.pl ([127.0.0.1]) by localhost (belindir.nask.net.pl [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jBOuLc-zdkfn; Sat, 4 Jul 2020 21:16:03 +0200 (CEST) Received: from belindir.nask.net.pl (belindir.nask.net.pl [172.16.10.10]) by belindir.nask.net.pl (Postfix) with ESMTP id 571CB22EF9; Sat, 4 Jul 2020 21:16:03 +0200 (CEST) Date: Sat, 4 Jul 2020 21:16:03 +0200 (CEST) From: =?utf-8?Q?Micha=C5=82_Leszczy=C5=84ski?= To: Julien Grall Message-ID: <271632089.19642398.1593890163210.JavaMail.zimbra@cert.pl> In-Reply-To: <2e01fca9-efcd-7d09-355f-29245bbc8721@xen.org> References: <9a3f4d58-e5ad-c7a1-6c5f-42aa92101ca1@xen.org> <7f915146-6566-e5a7-14d2-cb2319838562@xen.org> <7ac383c2-0264-cc75-a85b-13c1fdfb0bd6@suse.com> <187614050.18497785.1593721708078.JavaMail.zimbra@cert.pl> <2e01fca9-efcd-7d09-355f-29245bbc8721@xen.org> Subject: Re: [PATCH v4 02/10] x86/vmx: add IPT cpu feature MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.16.10.10] X-Mailer: Zimbra 8.6.0_GA_1194 (ZimbraWebClient - GC83 (Win)/8.6.0_GA_1194) Thread-Topic: x86/vmx: add IPT cpu feature Thread-Index: YFC2wBSChqCukYMSGTrVHCRJJ7fKjQ== X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Tian , Stefano Stabellini , tamas lengyel , Jan Beulich , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Jun Nakajima , xen-devel@lists.xenproject.org, luwei kang , Roger Pau =?utf-8?Q?Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" ----- 3 lip 2020 o 9:58, Julien Grall julien@xen.org napisa=C5=82(a): > Hi, >=20 > On 02/07/2020 21:28, Micha=C5=82 Leszczy=C5=84ski wrote: >> ----- 2 lip 2020 o 16:31, Julien Grall julien@xen.org napisa=C5=82(a): >>=20 >>> On 02/07/2020 15:17, Jan Beulich wrote: >>>> On 02.07.2020 16:14, Julien Grall wrote: >>>>> On 02/07/2020 14:30, Jan Beulich wrote: >>>>>> On 02.07.2020 11:57, Julien Grall wrote: >>>>>>> On 02/07/2020 10:18, Jan Beulich wrote: >>>>>>>> On 02.07.2020 10:54, Julien Grall wrote: >>>>>>>>> On 02/07/2020 09:50, Jan Beulich wrote: >>>>>>>>>> On 02.07.2020 10:42, Julien Grall wrote: >>>>>>>>>>> On 02/07/2020 09:29, Jan Beulich wrote: >>>>>>> Another way to do it, would be the toolstack to do the mapping. At = which >>>>>>> point, you still need an hypercall to do the mapping (probably the >>>>>>> hypercall acquire). >>>>>> >>>>>> There may not be any mapping to do in such a contrived, fixed-range >>>>>> environment. This scenario was specifically to demonstrate that the >>>>>> way the mapping gets done may be arch-specific (here: a no-op) >>>>>> despite the allocation not being so. >>>>> You are arguing on extreme cases which I don't think is really helpfu= l >>>>> here. Yes if you want to map at a fixed address in a guest you may no= t >>>>> need the acquire hypercall. But in most of the other cases (see has f= or >>>>> the tools) you will need it. >>>>> >>>>> So what's the problem with requesting to have the acquire hypercall >>>>> implemented in common code? >>>> >>>> Didn't we start out by you asking that there be as little common code >>>> as possible for the time being? >>> >>> Well as I said I am not in favor of having the allocation in common >>> code, but if you want to keep it then you also want to implement >>> map/unmap in the common code ([1], [2]). >>> >>>> I have no issue with putting the >>>> acquire implementation there ... >>> This was definitely not clear given how you argued with extreme cases..= . >>> >>> Cheers, >>> >>> [1] <9a3f4d58-e5ad-c7a1-6c5f-42aa92101ca1@xen.org> >>> [2] >>> >>> -- >>> Julien Grall >>=20 >>=20 >> Guys, >>=20 >> could you express your final decision on this topic? >=20 > Can you move the acquire implementation from x86 to common code? >=20 > Cheers, >=20 > -- > Julien Grall Ok, sure. This will be done within the patch v5. Best regards, Micha=C5=82 Leszczy=C5=84ski CERT Polska