All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Eryu Guan <eguan@redhat.com>, bfoster@redhat.com
Cc: dhowells@redhat.com, linux-xfs@vger.kernel.org,
	hch@infradead.org, amir73il@gmail.com, david@fromorbit.com,
	fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Should xfstest generic/388 be using _require_command for fsstress?
Date: Wed, 05 Apr 2017 11:59:15 +0100	[thread overview]
Message-ID: <2718.1491389955@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170405104205.GZ22845@eguan.usersys.redhat.com>

| 388:45:	$KILLALL_PROG -9 fsstress > /dev/null 2>&1
| 388:58:_require_command "$KILLALL_PROG" "killall"
| 388:79:		$KILLALL_PROG -9 fsstress > /dev/null 2>&1

Should this be using _require_command for fsstress and $FSSTRESS_PROG like the
other tests that use fsstress?

Also, should 388 be printing "Silence is golden" at the end of the test?

David

  parent reply	other threads:[~2017-04-05 10:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 15:55 [PATCH 1/4] xfstests: Add an auxiliary program to create an AF_UNIX socket [ver #5] David Howells
2017-04-04 15:55 ` [PATCH 2/4] xfstests: Add first statx test " David Howells
2017-04-05 10:38   ` Eryu Guan
2017-04-05 10:53     ` Does btrfs get nlink on directories wrong? -- was " David Howells
2017-04-05 12:30       ` David Sterba
2017-04-05 12:32         ` Amir Goldstein
2017-04-08 15:43           ` Eryu Guan
2017-04-08 15:43             ` Eryu Guan
2017-04-08 21:02             ` David Howells
2017-04-04 15:55 ` [PATCH 3/4] xfstests: Partially expand the documentation " David Howells
2017-04-05 10:42   ` Eryu Guan
2017-04-05 10:55     ` David Howells
2017-04-05 10:59     ` David Howells [this message]
2017-04-05 11:10       ` Should xfstest generic/388 be using _require_command for fsstress? Eryu Guan
2017-04-05 11:17         ` David Howells
2017-04-05 11:32           ` Eryu Guan
2017-04-04 15:55 ` [PATCH 4/4] xfstests: Check the stx_attributes settable by chattr [ver #5] David Howells
2017-04-05 10:52   ` Eryu Guan
2017-04-05 11:11     ` David Howells
2017-04-05 11:30       ` Eryu Guan
2017-04-05 12:25     ` David Howells
2017-04-06  3:17       ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2718.1491389955@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=amir73il@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.