From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F05C33CAC for ; Thu, 6 Feb 2020 15:57:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 227BF21775 for ; Thu, 6 Feb 2020 15:57:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 227BF21775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC5F26FA96; Thu, 6 Feb 2020 15:57:15 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 358EB6FA96 for ; Thu, 6 Feb 2020 15:57:14 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2020 07:57:13 -0800 X-IronPort-AV: E=Sophos;i="5.70,410,1574150400"; d="scan'208";a="225052956" Received: from aabader-mobl1.ccr.corp.intel.com (HELO [10.252.21.249]) ([10.252.21.249]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 06 Feb 2020 07:57:12 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20200206152325.2521787-1-chris@chris-wilson.co.uk> <158100296311.7306.6375353895241979260@skylake-alporthouse-com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <2721ffcc-da8d-6d76-eec7-1c5911176a2a@linux.intel.com> Date: Thu, 6 Feb 2020 15:57:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <158100296311.7306.6375353895241979260@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Prevent queuing retire workers on the virtual engine X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 06/02/2020 15:29, Chris Wilson wrote: > Quoting Chris Wilson (2020-02-06 15:23:25) >> Virtual engines are fleeting. They carry a reference count and may be freed >> when their last request is retired. This makes them unsuitable for the >> task of housing engine->retire.work so assert that it is not used. >> >> Tvrtko tracked down an instance where we did indeed violate this rule. >> In virtal_submit_request, we flush a completed request directly with >> __i915_request_submit and this causes us to queue that request on the >> veng's breadcrumb list and signal it. Leading us down a path where we >> should not attach the retire. >> >> Reported-by: Tvrtko Ursulin >> Fixes: dc93c9b69315 ("drm/i915/gt: Schedule request retirement when signaler idles") >> Signed-off-by: Chris Wilson >> Cc: Tvrtko Ursulin > > Alternatively we could fixup the rq->engine before > __i915_request_submit. That would stop the spread of > intel_virtual_engine_get_sibling(). > > This is likely to be the cleaner fix, so I think I would prefer this and > then remove the get_sibling(). Yes it makes more sense for rq->engine to be always physical at the point of __i915_request_submit. Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx