All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Teddy Astie" <teddy.astie@vates.tech>,
	"Oleksii Kurochko" <oleksii.kurochko@gmail.com>
Subject: [PATCH for-4.22 1/5] x86/time: use RTC century byte when available
Date: Tue, 12 May 2026 16:58:43 +0200	[thread overview]
Message-ID: <2723456f-5d8c-4a2a-9876-e65d35579936@suse.com> (raw)
In-Reply-To: <b36b6f2f-2b0e-462d-9846-4a1b4d7edef9@suse.com>

Without this the present logic will misbehave from 2070 onwards.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1257,6 +1257,7 @@ struct rtc_time {
 static bool __get_cmos_time(struct rtc_time *rtc)
 {
     s_time_t start, t1, t2;
+    unsigned int century = 0;
     unsigned long flags;
 
     spin_lock_irqsave(&rtc_lock, flags);
@@ -1280,6 +1281,8 @@ static bool __get_cmos_time(struct rtc_t
     rtc->day  = CMOS_READ(RTC_DAY_OF_MONTH);
     rtc->mon  = CMOS_READ(RTC_MONTH);
     rtc->year = CMOS_READ(RTC_YEAR);
+    if ( acpi_gbl_FADT.century && acpi_gbl_FADT.century < 0x80 )
+        century = CMOS_READ(acpi_gbl_FADT.century);
     
     if ( RTC_ALWAYS_BCD || !(CMOS_READ(RTC_CONTROL) & RTC_DM_BINARY) )
     {
@@ -1293,7 +1296,12 @@ static bool __get_cmos_time(struct rtc_t
 
     spin_unlock_irqrestore(&rtc_lock, flags);
 
-    if ( (rtc->year += 1900) < 1970 )
+    if ( century )
+    {
+        BCD_TO_BIN(century);
+        rtc->year += century * 100;
+    }
+    else if ( (rtc->year += 1900) < 1970 )
         rtc->year += 100;
 
     return t1 <= SECONDS(1) && t2 < MILLISECS(3);



  reply	other threads:[~2026-05-12 14:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 14:57 [PATCH 0/5] x86/time: CMOS RTC century byte Jan Beulich
2026-05-12 14:58 ` Jan Beulich [this message]
2026-05-13  8:49   ` [PATCH for-4.22 1/5] x86/time: use RTC century byte when available Roger Pau Monné
2026-05-13 10:36     ` Jan Beulich
2026-05-13 14:51       ` Roger Pau Monné
2026-05-13 15:08         ` Jan Beulich
2026-05-14  7:27   ` Oleksii Kurochko
2026-05-15  6:42     ` Jan Beulich
2026-05-12 14:59 ` [PATCH 2/5] x86/time: move BCD_TO_BIN() uses Jan Beulich
2026-05-13  8:56   ` Roger Pau Monné
2026-05-13 10:39     ` Jan Beulich
2026-05-13 14:58       ` Roger Pau Monné
2026-05-13 15:15         ` Jan Beulich
2026-05-13 19:08           ` Roger Pau Monné
2026-05-15  6:40             ` Jan Beulich
2026-05-12 14:59 ` [PATCH for-4.22 3/5] x86/vRTC: support century field Jan Beulich
2026-05-13 14:24   ` Roger Pau Monné
2026-05-13 14:58     ` Jan Beulich
2026-05-13 15:14       ` Roger Pau Monné
2026-05-13 15:24         ` Jan Beulich
2026-05-13 19:40           ` Roger Pau Monné
2026-05-15  6:52             ` Jan Beulich
2026-05-15  8:42               ` Roger Pau Monné
2026-05-15  8:48                 ` Jan Beulich
2026-05-13 15:42       ` Jan Beulich
2026-05-12 15:00 ` [PATCH 4/5] x86/vRTC: use available macros for BCD <-> BIN conversion Jan Beulich
2026-05-13 14:39   ` Roger Pau Monné
2026-05-12 15:00 ` [PATCH 5/5] tools/xen-hvmctx: shorten various format strings a little Jan Beulich
2026-05-13 15:00   ` Roger Pau Monné
2026-05-15  9:32   ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2723456f-5d8c-4a2a-9876-e65d35579936@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=oleksii.kurochko@gmail.com \
    --cc=roger.pau@citrix.com \
    --cc=teddy.astie@vates.tech \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.