From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D0F2C4345F for ; Tue, 16 Apr 2024 06:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/F2khXvm8jPZf5CflRJ7wcIOm+H9+4npqbeMMazcLV4=; b=nZuEisfBZwg6hf wgGyUhGb+yVGmqadcbjvZrXeas9XiK9EpPTxVbTPobyAOHHmGfAnjs0GjNgYKiMJk2QP8cZ4Uvem7 kXdUrQulNOhah3CCTrmGdcKjRgZQKyxag46lmH7b/fiz8hFryusIImTL9olNxoMWtQ2PTHjC05PZz wQMRLKhmNvT3/VmvSsANBvsBPUfsF7pTuxhLbjXk0/HZQdZAVlUyk7rF7/iOuKy/8LalNYD8KWnkO 7vW4zZeCZnH1JyV4AAxqcNHJD0RUZs/evE6CqphXJ+RHiTp4W5noCk36m3nVAfn0HzpxLzN74wKbd h5+p3ifiKrBdHz+Za40w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwcHn-0000000B50T-3m49; Tue, 16 Apr 2024 06:27:19 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwcHk-0000000B4yn-1hIA; Tue, 16 Apr 2024 06:27:18 +0000 Received: from i5e8616c3.versanet.de ([94.134.22.195] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwcHS-0005DQ-PJ; Tue, 16 Apr 2024 08:26:58 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Vinod Koul , Kishon Vijay Abraham I , Arnd Bergmann Cc: Arnd Bergmann , Cristian Ciocaltea , Zhang Yubing , Frank Wang , Sebastian Reichel , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: fix CONFIG_TYPEC dependency Date: Tue, 16 Apr 2024 08:26:57 +0200 Message-ID: <2727344.mvXUDI8C0e@diego> In-Reply-To: <20240415174241.77982-1-arnd@kernel.org> References: <20240415174241.77982-1-arnd@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_232716_502152_A8E476F7 X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Am Montag, 15. April 2024, 19:42:25 CEST schrieb Arnd Bergmann: > From: Arnd Bergmann > > The newly added driver causes a warning about missing dependencies > by selecting CONFIG_TYPEC unconditionally: > > WARNING: unmet direct dependencies detected for TYPEC > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] > > WARNING: unmet direct dependencies detected for USB_COMMON > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y] > > Since that is a user-visible option, it should not really be selected > in the first place. Replace the 'select' with a 'depends on' as > we have for similar drivers. > > Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Heiko Stuebner > --- > drivers/phy/rockchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index a752ccdddb86..08b0f4345760 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB > config PHY_ROCKCHIP_USBDP > tristate "Rockchip USBDP COMBO PHY Driver" > depends on ARCH_ROCKCHIP && OF > + depends on TYPEC > select GENERIC_PHY > - select TYPEC > help > Enable this to support the Rockchip USB3.0/DP combo PHY with > Samsung IP block. This is required for USB3 support on RK3588. > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90219C4345F for ; Tue, 16 Apr 2024 06:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gl0j4544u6PBcoXR5DO8NBp7Lv3nT+lfchmFPW/c1MU=; b=ENvmFYKnvbKT6a rWRuOZdDdmMm5/jicBGhDoWj/7aSzZIybDwdq6Cwgf6+oGJ69qat3GE2mBcUl/hrJV0AHeXO3Jg2z N+wIW3IMbchXSIIFKFrDgyrjBDb28Di7d6YFJVpudZxrOH9vfVvuD8+eheQ36mopWjXteJAdLrYOc sShsJuIUrl67RtURZLSzNWZhefhytzb2U9HQ8mgV7r6JWVOXoN8ChIqKro7YTDp6T3cYJGjH+jGIj BFPmlYGUw3CZeCN2dXbgm8Wz6LMiL6DtNgv4ajeI8AJJHK5d9dTHmMdzZftgwn5A6mdtP5lcCFbeO KTGVCSf2qw1GQVe0gKRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwcHq-0000000B50p-0SIG; Tue, 16 Apr 2024 06:27:22 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwcHk-0000000B4yn-1hIA; Tue, 16 Apr 2024 06:27:18 +0000 Received: from i5e8616c3.versanet.de ([94.134.22.195] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwcHS-0005DQ-PJ; Tue, 16 Apr 2024 08:26:58 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Vinod Koul , Kishon Vijay Abraham I , Arnd Bergmann Cc: Arnd Bergmann , Cristian Ciocaltea , Zhang Yubing , Frank Wang , Sebastian Reichel , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: fix CONFIG_TYPEC dependency Date: Tue, 16 Apr 2024 08:26:57 +0200 Message-ID: <2727344.mvXUDI8C0e@diego> In-Reply-To: <20240415174241.77982-1-arnd@kernel.org> References: <20240415174241.77982-1-arnd@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_232716_502152_A8E476F7 X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Montag, 15. April 2024, 19:42:25 CEST schrieb Arnd Bergmann: > From: Arnd Bergmann > > The newly added driver causes a warning about missing dependencies > by selecting CONFIG_TYPEC unconditionally: > > WARNING: unmet direct dependencies detected for TYPEC > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] > > WARNING: unmet direct dependencies detected for USB_COMMON > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y] > > Since that is a user-visible option, it should not really be selected > in the first place. Replace the 'select' with a 'depends on' as > we have for similar drivers. > > Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Heiko Stuebner > --- > drivers/phy/rockchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index a752ccdddb86..08b0f4345760 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB > config PHY_ROCKCHIP_USBDP > tristate "Rockchip USBDP COMBO PHY Driver" > depends on ARCH_ROCKCHIP && OF > + depends on TYPEC > select GENERIC_PHY > - select TYPEC > help > Enable this to support the Rockchip USB3.0/DP combo PHY with > Samsung IP block. This is required for USB3 support on RK3588. > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DC00C4345F for ; Tue, 16 Apr 2024 06:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=frYD12xwCuV3Zr8NZjovxIBNO+JzcYqWt838WnCMSkU=; b=pcfolOYsyIabrx sYBRMIxOMLHTQC4WZD2jwcMoC+4Gg6w8Qlw+odVveAwI5yTxkhSXoi0aY7su8bM7SMBxivGEdv2SE kARZx/zMMvSjt99lzGCAKEaWRYGCwbjYPfnns11U4Fba2LVPGybKCmyxZYxQfzQc4Rey9WEGjMrJ6 awhy+9v+5I+XPVyw8B6QtyFjjOnUGEgJLnGmSpz0Ss+HN+GzmEFpSHmBO//DtwmM1QqPd+xcoCCVi yDEPqte3/EO6j2OqTjNqLm6U5ld/jK0+NDPU0FmG08C6APZuWF6HtJ18TtWY2AQh4yNW37Mo4ZAiH aNPaxusc9NOJ/5CHMupQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwcHp-0000000B50j-1YQF; Tue, 16 Apr 2024 06:27:21 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwcHk-0000000B4yn-1hIA; Tue, 16 Apr 2024 06:27:18 +0000 Received: from i5e8616c3.versanet.de ([94.134.22.195] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwcHS-0005DQ-PJ; Tue, 16 Apr 2024 08:26:58 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Vinod Koul , Kishon Vijay Abraham I , Arnd Bergmann Cc: Arnd Bergmann , Cristian Ciocaltea , Zhang Yubing , Frank Wang , Sebastian Reichel , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: fix CONFIG_TYPEC dependency Date: Tue, 16 Apr 2024 08:26:57 +0200 Message-ID: <2727344.mvXUDI8C0e@diego> In-Reply-To: <20240415174241.77982-1-arnd@kernel.org> References: <20240415174241.77982-1-arnd@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_232716_502152_A8E476F7 X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 15. April 2024, 19:42:25 CEST schrieb Arnd Bergmann: > From: Arnd Bergmann > > The newly added driver causes a warning about missing dependencies > by selecting CONFIG_TYPEC unconditionally: > > WARNING: unmet direct dependencies detected for TYPEC > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] > > WARNING: unmet direct dependencies detected for USB_COMMON > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y] > > Since that is a user-visible option, it should not really be selected > in the first place. Replace the 'select' with a 'depends on' as > we have for similar drivers. > > Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Heiko Stuebner > --- > drivers/phy/rockchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index a752ccdddb86..08b0f4345760 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB > config PHY_ROCKCHIP_USBDP > tristate "Rockchip USBDP COMBO PHY Driver" > depends on ARCH_ROCKCHIP && OF > + depends on TYPEC > select GENERIC_PHY > - select TYPEC > help > Enable this to support the Rockchip USB3.0/DP combo PHY with > Samsung IP block. This is required for USB3 support on RK3588. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9C773BBF6 for ; Tue, 16 Apr 2024 06:27:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713248844; cv=none; b=BXPMfsdL3o6A4rFL/EeM013tjV3ZdYQZVvEqSf33nfhWyu06BI8zUcO282BQgrNxBjhr9rkT/Djqi7xViUfshOZpwgB7NHXTfyDtkBQYiw6qZNmJhNdbYHMW8VcAB8PTZyR7IdC2xKnPlFqMc/owSvBvk169qdHv3BqrlWsqumc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713248844; c=relaxed/simple; bh=e6iWpFbdrqkdIbyGKXOFxiHA//NrN4bR2L8KZ1GpDy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VmNj9VYqS2B433DliIIz73FsxG1JmZT8kbv+sQW+zSA5hg4qq7igKP+zctmElo14hVc79P/9QvPRTAsy9moqJw9SPKrb+tGHm6NjIa2qsbW9HnoGhUzLeOVRVuBtqwbPDEK7wf6EDtjx1hKwLozeJ9DgaVDCz8QjVkwvp4AuVmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i5e8616c3.versanet.de ([94.134.22.195] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rwcHS-0005DQ-PJ; Tue, 16 Apr 2024 08:26:58 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Vinod Koul , Kishon Vijay Abraham I , Arnd Bergmann Cc: Arnd Bergmann , Cristian Ciocaltea , Zhang Yubing , Frank Wang , Sebastian Reichel , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: fix CONFIG_TYPEC dependency Date: Tue, 16 Apr 2024 08:26:57 +0200 Message-ID: <2727344.mvXUDI8C0e@diego> In-Reply-To: <20240415174241.77982-1-arnd@kernel.org> References: <20240415174241.77982-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Montag, 15. April 2024, 19:42:25 CEST schrieb Arnd Bergmann: > From: Arnd Bergmann > > The newly added driver causes a warning about missing dependencies > by selecting CONFIG_TYPEC unconditionally: > > WARNING: unmet direct dependencies detected for TYPEC > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] > > WARNING: unmet direct dependencies detected for USB_COMMON > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y] > > Since that is a user-visible option, it should not really be selected > in the first place. Replace the 'select' with a 'depends on' as > we have for similar drivers. > > Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Heiko Stuebner > --- > drivers/phy/rockchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index a752ccdddb86..08b0f4345760 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB > config PHY_ROCKCHIP_USBDP > tristate "Rockchip USBDP COMBO PHY Driver" > depends on ARCH_ROCKCHIP && OF > + depends on TYPEC > select GENERIC_PHY > - select TYPEC > help > Enable this to support the Rockchip USB3.0/DP combo PHY with > Samsung IP block. This is required for USB3 support on RK3588. >