From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1453C433F5 for ; Tue, 30 Nov 2021 13:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=un4Iv1dlMDcLie8DwP1DGT2BZGPXJjbfNotvanX0JOA=; b=AHIMM8vzOCxCcB kaQa4YWOZEJUWVDYN9SVcquknufm3/zv30ZYURaB0A8+hc3h3t5KKXlClkoqZ25GLa/zhLpV9RO5f Urvp+Pihtb9c3u2Ev7W5dY1keRGz/QZpXvDlX5wXlq2a6Jf7qmBKlJeK8PRZY+jfl90Vc59lAWw2J XcIw4IFCK3m/03MUyOvLj5Ca9Uy8kFy1QW2+F5yCdlbV+8pohnZaCsAkVG0w0HmXCw2e+nnF8BiU8 +bOoTeC/3452VrcaMB6Jrm4mSVYg8s3XTOxWs2RarHIptQmZHGGCMRd4oqklxvW+pN3w4HLpfruu6 gUKDN+C34aXZv8O04zig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms3Aw-005KeB-Eb; Tue, 30 Nov 2021 13:28:02 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms3At-005Kco-I4 for linux-riscv@lists.infradead.org; Tue, 30 Nov 2021 13:28:01 +0000 Received: from ip5f5b2004.dynamic.kabel-deutschland.de ([95.91.32.4] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ms3Ak-00058Q-BT; Tue, 30 Nov 2021 14:27:50 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-riscv@lists.infradead.org, Jessica Clarke Cc: Wei Fu , linux-riscv , "linux-kernel@vger.kernel.org List" , taiten.peng@canonical.com, aniket.ponkshe@canonical.com, gordan.markus@canonical.com, Guo Ren , arnd@arndb.de, wens@csie.org, maxime@cerno.tech, Dan Lustig , Greg Favor , andrea.mondelli@huawei.com, behrensj@mit.edu, xinhaoqu@huawei.com, huffman@cadence.com, Nick Kossifidis , Allen Baum , jscheid@ventanamicro.com, rtrauben@gmail.com, Anup Patel , Rob Herring , Anup Patel , atishp04@gmail.com, Palmer Dabbelt , Guo Ren , Christoph =?ISO-8859-1?Q?M=FCllner?= , Philipp Tomsich , hch@lst.de, liush@allwinnertech.com, Wei Wu , drew@beagleboard.org, Heinrich Schuchardt Subject: Re: [PATCH V4 1/2] dt-bindings: riscv: add MMU Standard Extensions support for Svpbmt Date: Tue, 30 Nov 2021 14:27:48 +0100 Message-ID: <2728314.U2HhIfhhqV@diego> In-Reply-To: References: <20211129014007.286478-1-wefu@redhat.com> <1909580.k68io2XIxi@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_052759_631830_18FFE6F6 X-CRM114-Status: GOOD ( 21.37 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGksCgpBbSBEaWVuc3RhZywgMzAuIE5vdmVtYmVyIDIwMjEsIDE0OjE3OjQxIENFVCBzY2hyaWVi IEplc3NpY2EgQ2xhcmtlOgo+IE9uIDMwIE5vdiAyMDIxLCBhdCAxMjowNywgSGVpa28gU3TDvGJu ZXIgPGhlaWtvQHNudGVjaC5kZT4gd3JvdGU6Cj4gPiAKPiA+IEFtIE1vbnRhZywgMjkuIE5vdmVt YmVyIDIwMjEsIDEzOjA2OjIzIENFVCBzY2hyaWViIEhlaWtvIFN0w7xibmVyOgo+ID4+IEFtIE1v bnRhZywgMjkuIE5vdmVtYmVyIDIwMjEsIDA5OjU0OjM5IENFVCBzY2hyaWViIEhlaW5yaWNoIFNj aHVjaGFyZHQ6Cj4gPj4+IE9uIDExLzI5LzIxIDAyOjQwLCB3ZWZ1QHJlZGhhdC5jb20gd3JvdGU6 Cj4gPj4+PiBGcm9tOiBXZWkgRnUgPHdlZnVAcmVkaGF0LmNvbT4KPiA+Pj4+IAo+ID4+Pj4gUHJl dmlvdXMgcGF0Y2ggaGFzIGFkZGVkIHN2cGJtdCBpbiBhcmNoL3Jpc2N2IGFuZCBhZGQgInJpc2N2 LHN2cG1idCIKPiA+Pj4+IGluIHRoZSBEVCBtbXUgbm9kZS4gVXBkYXRlIGR0LWJpbmRpbmdzIHJl bGF0ZWQgcHJvcGVydHkgaGVyZS4KPiA+Pj4+IAo+ID4+Pj4gU2lnbmVkLW9mZi1ieTogV2VpIEZ1 IDx3ZWZ1QHJlZGhhdC5jb20+Cj4gPj4+PiBDby1kZXZlbG9wZWQtYnk6IEd1byBSZW4gPGd1b3Jl bkBrZXJuZWwub3JnPgo+ID4+Pj4gU2lnbmVkLW9mZi1ieTogR3VvIFJlbiA8Z3VvcmVuQGtlcm5l bC5vcmc+Cj4gPj4+PiBDYzogQW51cCBQYXRlbCA8YW51cEBicmFpbmZhdWx0Lm9yZz4KPiA+Pj4+ IENjOiBQYWxtZXIgRGFiYmVsdCA8cGFsbWVyQGRhYmJlbHQuY29tPgo+ID4+Pj4gQ2M6IFJvYiBI ZXJyaW5nIDxyb2JoK2R0QGtlcm5lbC5vcmc+Cj4gPj4+PiAtLS0KPiA+Pj4+ICBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcmlzY3YvY3B1cy55YW1sIHwgMTAgKysrKysrKysrKwo+ ID4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCj4gPj4+PiAKPiA+Pj4+IGRp ZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcmlzY3YvY3B1cy55 YW1sIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Jpc2N2L2NwdXMueWFtbAo+ ID4+Pj4gaW5kZXggYWE1ZmI2NGQ1N2ViLi45ZmY5Y2JkZDhhODUgMTAwNjQ0Cj4gPj4+PiAtLS0g YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcmlzY3YvY3B1cy55YW1sCj4gPj4+ PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcmlzY3YvY3B1cy55YW1s Cj4gPj4+PiBAQCAtNjMsNiArNjMsMTYgQEAgcHJvcGVydGllczoKPiA+Pj4+ICAgICAgICAtIHJp c2N2LHN2NDgKPiA+Pj4+ICAgICAgICAtIHJpc2N2LG5vbmUKPiA+Pj4+IAo+ID4+Pj4gKyAgbW11 Ogo+ID4+PiAKPiA+Pj4gU2hvdWxkbid0IHdlIGtlZXAgdGhlIGl0ZW1zIGJlIGluIGFscGhhYmV0 aWMgb3JkZXIsIGkuZS4gbW11IGJlZm9yZSAKPiA+Pj4gbW11LXR5cGU/Cj4gPj4+IAo+ID4+Pj4g KyAgICBkZXNjcmlwdGlvbjoKPiA+Pj4+ICsgICAgICBEZXNjcmliZXMgdGhlIENQVSdzIE1NVSBT dGFuZGFyZCBFeHRlbnNpb25zIHN1cHBvcnQuCj4gPj4+PiArICAgICAgVGhlc2UgdmFsdWVzIG9y aWdpbmF0ZSBmcm9tIHRoZSBSSVNDLVYgUHJpdmlsZWdlZAo+ID4+Pj4gKyAgICAgIFNwZWNpZmlj YXRpb24gZG9jdW1lbnQsIGF2YWlsYWJsZSBmcm9tCj4gPj4+PiArICAgICAgaHR0cHM6Ly9yaXNj di5vcmcvc3BlY2lmaWNhdGlvbnMvCj4gPj4+PiArICAgICRyZWY6ICcvc2NoZW1hcy90eXBlcy55 YW1sIy9kZWZpbml0aW9ucy9zdHJpbmcnCj4gPj4+PiArICAgIGVudW06Cj4gPj4+PiArICAgICAg LSByaXNjdixzdnBtYnQKPiA+Pj4gCj4gPj4+IFRoZSBwcml2aWxlZ2VkIHNwZWNpZmljYXRpb24g aGFzIG11bHRpcGxlIE1NVSByZWxhdGVkIGV4dGVuc2lvbnM6IAo+ID4+PiBTdm5hcG90LCBTdnBi bXQsIFN2aW52YWwuIFNoYWxsIHRoZXkgYWxsIGJlIG1vZGVsZWQgaW4gdGhpcyBlbnVtPwo+ID4+ IAo+ID4+IEkgcmVtZW1iZXIgaW4gc29tZSBlYXJsaWVyIHZlcnNpb24gc29tZSB3YXkgYmFjayB0 aGVyZSB3YXMgdGhlCj4gPj4gc3VnZ2VzdGlvbiBvZiB1c2luZyBhIHN1Yi1ub2RlIGluc3RlYWQg YW5kIHRoZW4gYWRkaW5nIGJvb2xlYW4KPiA+PiBwcm9wZXJ0aWVzIGZvciB0aGUgc3VwcG9ydGVk IGV4dGVuc2lvbnMuCj4gPj4gCj4gPj4gQWthIHNvbWV0aGluZyBsaWtlCj4gPj4gCW1tdSB7Cj4g Pj4gCQlyaXNjdixzdnBibXQ7CQo+ID4+IAl9Owo+ID4gCj4gPiBGb3IgdGhlIHJlY29yZCwgSSdt IHRhbGtpbmcgYWJvdXQgdGhlIG1haWwgZnJvbSBzZXB0ZW1iZXIKPiA+IGh0dHBzOi8vbG9yZS5r ZXJuZWwub3JnL2xpbnV4LXJpc2N2L0NBQWVMdFVDaGpqekcrUDh5ZzQ1R0xaTUp5NVVSMks1UlJC b0xGVlpodE9hWjVwUHRFQUBtYWlsLmdtYWlsLmNvbS8KPiA+IAo+ID4gU28gaGF2aW5nIGEgc3Vi LW5vZGUgd291bGQgbWFrZSBhZGRpbmcgZnV0dXJlIGV4dGVuc2lvbnMKPiA+IHdheSBuaWNlci4K PiAKPiBTdnBibXQgaXMganVzdCBhbiBJU0EgZXh0ZW5zaW9uLCBhbmQgc2hvdWxkIGJlIHRyZWF0 ZWQgbGlrZSBhbnkgb3RoZXIuCj4gTGV04oCZcyBub3QgaW52ZW50IHR3byBkaWZmZXJlbnQgd2F5 cyBvZiByZXByZXNlbnRpbmcgdGhhdCBpbiB0aGUgZGV2aWNlCj4gdHJlZS4KCkhlaW5yaWNoIGFz a2VkIGhvdyB0aGUgb3RoZXIgZXh0ZW5zaW9ucyBzaG91bGQgYmUgaGFuZGxlZAooU3ZuYXBvdCwg U3ZwYm10LCBTdmludmFsKSwgc28gd2hhdCBkbyB5b3Ugc3VnZ2VzdCB0byBkbyB3aXRoIHRoZXNl PwoKClRoYW5rcwpIZWlrbwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F180EC433EF for ; Tue, 30 Nov 2021 13:28:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240348AbhK3NbU convert rfc822-to-8bit (ORCPT ); Tue, 30 Nov 2021 08:31:20 -0500 Received: from gloria.sntech.de ([185.11.138.130]:48242 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233573AbhK3NbT (ORCPT ); Tue, 30 Nov 2021 08:31:19 -0500 Received: from ip5f5b2004.dynamic.kabel-deutschland.de ([95.91.32.4] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ms3Ak-00058Q-BT; Tue, 30 Nov 2021 14:27:50 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-riscv@lists.infradead.org, Jessica Clarke Cc: Wei Fu , linux-riscv , "linux-kernel@vger.kernel.org List" , taiten.peng@canonical.com, aniket.ponkshe@canonical.com, gordan.markus@canonical.com, Guo Ren , arnd@arndb.de, wens@csie.org, maxime@cerno.tech, Dan Lustig , Greg Favor , andrea.mondelli@huawei.com, behrensj@mit.edu, xinhaoqu@huawei.com, huffman@cadence.com, Nick Kossifidis , Allen Baum , jscheid@ventanamicro.com, rtrauben@gmail.com, Anup Patel , Rob Herring , Anup Patel , atishp04@gmail.com, Palmer Dabbelt , Guo Ren , Christoph =?ISO-8859-1?Q?M=FCllner?= , Philipp Tomsich , hch@lst.de, liush@allwinnertech.com, Wei Wu , drew@beagleboard.org, Heinrich Schuchardt Subject: Re: [PATCH V4 1/2] dt-bindings: riscv: add MMU Standard Extensions support for Svpbmt Date: Tue, 30 Nov 2021 14:27:48 +0100 Message-ID: <2728314.U2HhIfhhqV@diego> In-Reply-To: References: <20211129014007.286478-1-wefu@redhat.com> <1909580.k68io2XIxi@diego> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am Dienstag, 30. November 2021, 14:17:41 CET schrieb Jessica Clarke: > On 30 Nov 2021, at 12:07, Heiko Stübner wrote: > > > > Am Montag, 29. November 2021, 13:06:23 CET schrieb Heiko Stübner: > >> Am Montag, 29. November 2021, 09:54:39 CET schrieb Heinrich Schuchardt: > >>> On 11/29/21 02:40, wefu@redhat.com wrote: > >>>> From: Wei Fu > >>>> > >>>> Previous patch has added svpbmt in arch/riscv and add "riscv,svpmbt" > >>>> in the DT mmu node. Update dt-bindings related property here. > >>>> > >>>> Signed-off-by: Wei Fu > >>>> Co-developed-by: Guo Ren > >>>> Signed-off-by: Guo Ren > >>>> Cc: Anup Patel > >>>> Cc: Palmer Dabbelt > >>>> Cc: Rob Herring > >>>> --- > >>>> Documentation/devicetree/bindings/riscv/cpus.yaml | 10 ++++++++++ > >>>> 1 file changed, 10 insertions(+) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml > >>>> index aa5fb64d57eb..9ff9cbdd8a85 100644 > >>>> --- a/Documentation/devicetree/bindings/riscv/cpus.yaml > >>>> +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml > >>>> @@ -63,6 +63,16 @@ properties: > >>>> - riscv,sv48 > >>>> - riscv,none > >>>> > >>>> + mmu: > >>> > >>> Shouldn't we keep the items be in alphabetic order, i.e. mmu before > >>> mmu-type? > >>> > >>>> + description: > >>>> + Describes the CPU's MMU Standard Extensions support. > >>>> + These values originate from the RISC-V Privileged > >>>> + Specification document, available from > >>>> + https://riscv.org/specifications/ > >>>> + $ref: '/schemas/types.yaml#/definitions/string' > >>>> + enum: > >>>> + - riscv,svpmbt > >>> > >>> The privileged specification has multiple MMU related extensions: > >>> Svnapot, Svpbmt, Svinval. Shall they all be modeled in this enum? > >> > >> I remember in some earlier version some way back there was the > >> suggestion of using a sub-node instead and then adding boolean > >> properties for the supported extensions. > >> > >> Aka something like > >> mmu { > >> riscv,svpbmt; > >> }; > > > > For the record, I'm talking about the mail from september > > https://lore.kernel.org/linux-riscv/CAAeLtUChjjzG+P8yg45GLZMJy5UR2K5RRBoLFVZhtOaZ5pPtEA@mail.gmail.com/ > > > > So having a sub-node would make adding future extensions > > way nicer. > > Svpbmt is just an ISA extension, and should be treated like any other. > Let’s not invent two different ways of representing that in the device > tree. Heinrich asked how the other extensions should be handled (Svnapot, Svpbmt, Svinval), so what do you suggest to do with these? Thanks Heiko