From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328 Date: Mon, 10 Sep 2018 15:57:31 +0200 Message-ID: <2729174.Cl53sqNc79@phil> References: <20180906163956.20667-1-katsuhiro@katsuster.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20180906163956.20667-1-katsuhiro@katsuster.net> Sender: linux-kernel-owner@vger.kernel.org To: Katsuhiro Suzuki Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org Hi, Am Donnerstag, 6. September 2018, 18:39:56 CEST schrieb Katsuhiro Suzuki: > This patch adds port and endpoint of i2s and spdif nodes for rk3328. > Because to use modern sound card interface such as audio-graph-card. > > Signed-off-by: Katsuhiro Suzuki > --- > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > index d3ef6566325e..41f0a20b73ed 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -179,7 +179,13 @@ > clock-names = "i2s_clk", "i2s_hclk"; > dmas = <&dmac 11>, <&dmac 12>; > dma-names = "tx", "rx"; > + #sound-dai-cells = <0>; > status = "disabled"; > + > + i2s0_p0: port@0 { there is only one port per device, so this should probably be i2s0_p0: port { without the address. Same for all others. The of-graph framework should work just fine then as well. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Mon, 10 Sep 2018 15:57:31 +0200 Subject: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328 In-Reply-To: <20180906163956.20667-1-katsuhiro@katsuster.net> References: <20180906163956.20667-1-katsuhiro@katsuster.net> Message-ID: <2729174.Cl53sqNc79@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Am Donnerstag, 6. September 2018, 18:39:56 CEST schrieb Katsuhiro Suzuki: > This patch adds port and endpoint of i2s and spdif nodes for rk3328. > Because to use modern sound card interface such as audio-graph-card. > > Signed-off-by: Katsuhiro Suzuki > --- > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > index d3ef6566325e..41f0a20b73ed 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi > @@ -179,7 +179,13 @@ > clock-names = "i2s_clk", "i2s_hclk"; > dmas = <&dmac 11>, <&dmac 12>; > dma-names = "tx", "rx"; > + #sound-dai-cells = <0>; > status = "disabled"; > + > + i2s0_p0: port at 0 { there is only one port per device, so this should probably be i2s0_p0: port { without the address. Same for all others. The of-graph framework should work just fine then as well. Heiko