All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kumar, M Chetan" <m.chetan.kumar@intel.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: linuxwwan <linuxwwan@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: RE: [PATCH] net: iosm: remove the repeated declaration and comment
Date: Wed, 16 Jun 2021 07:51:23 +0000	[thread overview]
Message-ID: <2735788e3a224cb0b50fc015a76f4f82@intel.com> (raw)
In-Reply-To: <1623828340-2019-1-git-send-email-zhangshaokun@hisilicon.com>

> Function 'ipc_mmio_get_cp_version' is declared twice, so remove the
> repeated declaration and wrong comments.
> 
> Cc: M Chetan Kumar <m.chetan.kumar@intel.com>
> Cc: Intel Corporation <linuxwwan@intel.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  drivers/net/wwan/iosm/iosm_ipc_mmio.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> index bcf77aea06e7..45e6923da78f 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> +++ b/drivers/net/wwan/iosm/iosm_ipc_mmio.h
> @@ -121,16 +121,6 @@ void ipc_mmio_set_contex_info_addr(struct
> iosm_mmio *ipc_mmio,
>  				   phys_addr_t addr);
> 
>  /**
> - * ipc_mmio_get_cp_version - Write context info and AP memory range
> addresses.
> - *			     This needs to be called when CP is in
> - *			     IPC_MEM_DEVICE_IPC_INIT state
> - * @ipc_mmio:	Pointer to mmio instance
> - *
> - * Returns: cp version else failure value on error
> - */
> -int ipc_mmio_get_cp_version(struct iosm_mmio *ipc_mmio);
> -
> -/**
>   * ipc_mmio_get_cp_version - Get the CP IPC version
>   * @ipc_mmio:	Pointer to mmio instance
>   *
> --
> 2.7.4

Thanks,
Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>

      reply	other threads:[~2021-06-16  7:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  7:25 [PATCH] net: iosm: remove the repeated declaration and comment Shaokun Zhang
2021-06-16  7:51 ` Kumar, M Chetan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2735788e3a224cb0b50fc015a76f4f82@intel.com \
    --to=m.chetan.kumar@intel.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linuxwwan@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.