From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Fabrizio Castro Cc: David Airlie , Rob Herring , Geert Uytterhoeven , Mark Rutland , Biju Das , Simon Horman , Magnus Damm , Russell King , "dri-devel@lists.freedesktop.org" , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Chris Paterson Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support Date: Fri, 23 Nov 2018 14:05:23 +0200 Message-ID: <2739044.1unFEStFin@avalon> In-Reply-To: References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <5135719.5JoeYGyzrK@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org List-ID: Hi Fabrizio, On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote: > On 15 October 2018 23:25 Laurent Pinchart wrote: > > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote: > >> From: Biju Das > >> > >> Add support for the R8A7744 DU (which is very similar to the R8A7743 > >> DU); > >> it has 1 DPAD (RGB) output and 1 LVDS output. > >> > >> Signed-off-by: Biju Das > >> Reviewed-by: Fabrizio Castro > >> --- > >> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644 > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info > >> rcar_du_r8a77970_info = { > >> static const struct of_device_id rcar_du_of_table[] = { > >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > >> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info > >> }, > >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, > > > > This looks good to me. I would also apply this change: > > > > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info > > rzg1_du_r8a7743_info = { > > .channels_mask = BIT(1) | BIT(0), > > .routes = { > > /* > > - * R8A7743 has one RGB output and one LVDS output > > + * R8A774[34] has one RGB output and one LVDS output > > */ > > [RCAR_DU_OUTPUT_DPAD0] = { > > .possible_crtcs = BIT(1) | BIT(0), > > > > With this, > > > > Reviewed-by: Laurent Pinchart > > > > There's no need to resubmit, I've applied the patch to my tree with the > > above change. > > I was expecting to see this patch at least on linux-next by now but it looks > like it's not in there, could you please double check what happened to it? I've sent the R-Car DU v4.21 pull request today, it should end up in linux- next in the near future. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Fri, 23 Nov 2018 14:05:23 +0200 Subject: [PATCH 4/5] drm: rcar-du: Add R8A7744 support In-Reply-To: References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <5135719.5JoeYGyzrK@avalon> Message-ID: <2739044.1unFEStFin@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Fabrizio, On Thursday, 22 November 2018 17:59:32 EET Fabrizio Castro wrote: > On 15 October 2018 23:25 Laurent Pinchart wrote: > > On Friday, 21 September 2018 21:08:30 EEST Fabrizio Castro wrote: > >> From: Biju Das > >> > >> Add support for the R8A7744 DU (which is very similar to the R8A7743 > >> DU); > >> it has 1 DPAD (RGB) output and 1 LVDS output. > >> > >> Signed-off-by: Biju Das > >> Reviewed-by: Fabrizio Castro > >> --- > >> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index c07d3f1..2c3d0e5 100644 > >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > >> @@ -321,6 +321,7 @@ static const struct rcar_du_device_info > >> rcar_du_r8a77970_info = { > >> static const struct of_device_id rcar_du_of_table[] = { > >> { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > >> +{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > >> { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > >> { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info > >> }, > >> { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, > > > > This looks good to me. I would also apply this change: > > > > @@ -41,7 +41,7 @@ static const struct rcar_du_device_info > > rzg1_du_r8a7743_info = { > > .channels_mask = BIT(1) | BIT(0), > > .routes = { > > /* > > - * R8A7743 has one RGB output and one LVDS output > > + * R8A774[34] has one RGB output and one LVDS output > > */ > > [RCAR_DU_OUTPUT_DPAD0] = { > > .possible_crtcs = BIT(1) | BIT(0), > > > > With this, > > > > Reviewed-by: Laurent Pinchart > > > > There's no need to resubmit, I've applied the patch to my tree with the > > above change. > > I was expecting to see this patch at least on linux-next by now but it looks > like it's not in there, could you please double check what happened to it? I've sent the R-Car DU v4.21 pull request today, it should end up in linux- next in the near future. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/5] drm: rcar-du: Add R8A7744 support Date: Fri, 23 Nov 2018 14:05:23 +0200 Message-ID: <2739044.1unFEStFin@avalon> References: <1537553311-8831-1-git-send-email-fabrizio.castro@bp.renesas.com> <5135719.5JoeYGyzrK@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabrizio Castro Cc: Mark Rutland , "devicetree@vger.kernel.org" , Chris Paterson , Geert Uytterhoeven , Simon Horman , David Airlie , Magnus Damm , Russell King , "dri-devel@lists.freedesktop.org" , Biju Das , "linux-renesas-soc@vger.kernel.org" , Rob Herring , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org SGkgRmFicml6aW8sCgpPbiBUaHVyc2RheSwgMjIgTm92ZW1iZXIgMjAxOCAxNzo1OTozMiBFRVQg RmFicml6aW8gQ2FzdHJvIHdyb3RlOgo+IE9uIDE1IE9jdG9iZXIgMjAxOCAyMzoyNSBMYXVyZW50 IFBpbmNoYXJ0IHdyb3RlOgo+ID4gT24gRnJpZGF5LCAyMSBTZXB0ZW1iZXIgMjAxOCAyMTowODoz MCBFRVNUIEZhYnJpemlvIENhc3RybyB3cm90ZToKPiA+PiBGcm9tOiBCaWp1IERhcyA8YmlqdS5k YXNAYnAucmVuZXNhcy5jb20+Cj4gPj4gCj4gPj4gQWRkIHN1cHBvcnQgZm9yIHRoZSBSOEE3NzQ0 IERVICh3aGljaCBpcyB2ZXJ5IHNpbWlsYXIgdG8gdGhlIFI4QTc3NDMKPiA+PiBEVSk7Cj4gPj4g aXQgaGFzIDEgRFBBRCAoUkdCKSBvdXRwdXQgYW5kIDEgTFZEUyBvdXRwdXQuCj4gPj4gCj4gPj4g U2lnbmVkLW9mZi1ieTogQmlqdSBEYXMgPGJpanUuZGFzQGJwLnJlbmVzYXMuY29tPgo+ID4+IFJl dmlld2VkLWJ5OiBGYWJyaXppbyBDYXN0cm8gPGZhYnJpemlvLmNhc3Ryb0BicC5yZW5lc2FzLmNv bT4KPiA+PiAtLS0KPiA+PiAKPiA+PiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9k cnYuYyB8IDEgKwo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiA+PiAKPiA+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+ID4+ IGIvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyBpbmRleCBjMDdkM2YxLi4y YzNkMGU1IDEwMDY0NAo+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVf ZHJ2LmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jCj4g Pj4gQEAgLTMyMSw2ICszMjEsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJfZHVfZGV2aWNl X2luZm8KPiA+PiByY2FyX2R1X3I4YTc3OTcwX2luZm8gPSB7Cj4gPj4gIHN0YXRpYyBjb25zdCBz dHJ1Y3Qgb2ZfZGV2aWNlX2lkIHJjYXJfZHVfb2ZfdGFibGVbXSA9IHsKPiA+PiAgeyAuY29tcGF0 aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3NDMiLCAuZGF0YSA9ICZyemcxX2R1X3I4YTc3NDNfaW5m byB9LAo+ID4+ICt7IC5jb21wYXRpYmxlID0gInJlbmVzYXMsZHUtcjhhNzc0NCIsIC5kYXRhID0g JnJ6ZzFfZHVfcjhhNzc0M19pbmZvIH0sCj4gPj4gIHsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxk dS1yOGE3NzQ1IiwgLmRhdGEgPSAmcnpnMV9kdV9yOGE3NzQ1X2luZm8gfSwKPiA+PiAgeyAuY29t cGF0aWJsZSA9ICJyZW5lc2FzLGR1LXI4YTc3NDcwIiwgLmRhdGEgPSAmcnpnMV9kdV9yOGE3NzQ3 MF9pbmZvCj4gPj4gIH0sCj4gPj4gIHsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxkdS1yOGE3Nzc5 IiwgLmRhdGEgPSAmcmNhcl9kdV9yOGE3Nzc5X2luZm8gfSwKPiA+IAo+ID4gVGhpcyBsb29rcyBn b29kIHRvIG1lLiBJIHdvdWxkIGFsc28gYXBwbHkgdGhpcyBjaGFuZ2U6Cj4gPiAKPiA+IEBAIC00 MSw3ICs0MSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmNhcl9kdV9kZXZpY2VfaW5mbwo+ID4g cnpnMV9kdV9yOGE3NzQzX2luZm8gPSB7Cj4gPiAgICAgICAgIC5jaGFubmVsc19tYXNrID0gQklU KDEpIHwgQklUKDApLAo+ID4gICAgICAgICAucm91dGVzID0gewo+ID4gICAgICAgICAgICAgICAg IC8qCj4gPiAtICAgICAgICAgICAgICAgICogUjhBNzc0MyBoYXMgb25lIFJHQiBvdXRwdXQgYW5k IG9uZSBMVkRTIG91dHB1dAo+ID4gKyAgICAgICAgICAgICAgICAqIFI4QTc3NFszNF0gaGFzIG9u ZSBSR0Igb3V0cHV0IGFuZCBvbmUgTFZEUyBvdXRwdXQKPiA+ICAgICAgICAgICAgICAgICAgKi8K PiA+ICAgICAgICAgICAgICAgICBbUkNBUl9EVV9PVVRQVVRfRFBBRDBdID0gewo+ID4gICAgICAg ICAgICAgICAgICAgICAgICAgLnBvc3NpYmxlX2NydGNzID0gQklUKDEpIHwgQklUKDApLAo+ID4g Cj4gPiBXaXRoIHRoaXMsCj4gPiAKPiA+IFJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxs YXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiAKPiA+IFRoZXJlJ3Mgbm8gbmVl ZCB0byByZXN1Ym1pdCwgSSd2ZSBhcHBsaWVkIHRoZSBwYXRjaCB0byBteSB0cmVlIHdpdGggdGhl Cj4gPiBhYm92ZSBjaGFuZ2UuCj4gCj4gSSB3YXMgZXhwZWN0aW5nIHRvIHNlZSB0aGlzIHBhdGNo IGF0IGxlYXN0IG9uIGxpbnV4LW5leHQgYnkgbm93IGJ1dCBpdCBsb29rcwo+IGxpa2UgaXQncyBu b3QgaW4gdGhlcmUsIGNvdWxkIHlvdSBwbGVhc2UgZG91YmxlIGNoZWNrIHdoYXQgaGFwcGVuZWQg dG8gaXQ/CgpJJ3ZlIHNlbnQgdGhlIFItQ2FyIERVIHY0LjIxIHB1bGwgcmVxdWVzdCB0b2RheSwg aXQgc2hvdWxkIGVuZCB1cCBpbiBsaW51eC0KbmV4dCBpbiB0aGUgbmVhciBmdXR1cmUuCgotLSAK UmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==