From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 4/5] app/testpmd: move ethdev events
	registration
Date: Thu, 25 Oct 2018 10:58:48 +0200
Message-ID: <2739182.JckHbNtxNe@xps>
References: <20181024134111.26771-1-thomas@monjalon.net>
 <4409048.vUvRZhrQBt@xps>
 <8CEF83825BEC744B83065625E567D7C260D172FD@IRSMSX107.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "ophirmu@mellanox.com" <ophirmu@mellanox.com>,
 "wisamm@mellanox.com" <wisamm@mellanox.com>, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8155A2BAE
 for <dev@dpdk.org>; Thu, 25 Oct 2018 10:58:47 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D172FD@IRSMSX107.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

25/10/2018 10:54, Iremonger, Bernard:
> Hi Thomas,
> 
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 24/10/2018 17:55, Iremonger, Bernard:
> > > Hi Thomas,
> > >
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > +/* Pretty printing of ethdev events */ static const char * const
> > > > +eth_event_desc[] = {
> > > > +	[RTE_ETH_EVENT_UNKNOWN] = "unknown",
> > > > +	[RTE_ETH_EVENT_INTR_LSC] = "LSC",
> > >
> > > How about replacing "LSC" with "interrupt link status change"
> > 
> > When it is printed, "event" is appended.
> > So I think "interrupt" is a bit too much.
> > OK for "link state change"?
> 
> Yes,
>  
> > > > +	[RTE_ETH_EVENT_QUEUE_STATE] = "queue state",
> > > > +	[RTE_ETH_EVENT_INTR_RESET] = "interrupt reset",
> 
> Should "interrupt" be dropped from "interrupt reset" too for consistency? 

Yes, you're right.

> > > > +	[RTE_ETH_EVENT_VF_MBOX] = "VF mbox",
> > > > +	[RTE_ETH_EVENT_IPSEC] = "IPsec",
> > > > +	[RTE_ETH_EVENT_MACSEC] = "MACsec",
> > > > +	[RTE_ETH_EVENT_INTR_RMV] = "device removal",
> > >
> > > How about replacing "device removal" with "interrupt device removal"
> > 
> > For same reason, I think "device removal" is enough.
> > It will be printed as "device removal event".

I will send a v2 today.
Thanks for the review.