From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Cosmo Chou <chou.cosmo@gmail.com>, openbmc@lists.ozlabs.org
Cc: cosmo.chou@quantatw.com, Amit Sunil Dhamne <amitsd@google.com>
Subject: Re: [PATCH linux dev-6.6] usb: typec: tcpm: Add support for parsing pd-revision DT property
Date: Fri, 16 May 2025 10:29:12 +0930 [thread overview]
Message-ID: <273f8317466446cb997917f9770b6991852e09eb.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250513135324.1616086-1-chou.cosmo@gmail.com>
Hi Cosmo,
On Tue, 2025-05-13 at 21:53 +0800, Cosmo Chou wrote:
> From: Amit Sunil Dhamne <amitsd@google.com>
>
> Add support for parsing "pd-revision" DT property in TCPM and store PD
> revision and version supported by the Type-C connnector.
>
> It should be noted that the PD revision is the maximum possible revision
> supported by the port. This is different from the 2 bit revision set in
> PD msg headers. The purpose of the 2 bit revision value is to negotiate
> between Rev 2.X & 3.X spec rev as part of contract negotiation, while
> this is used for Get_Revision AMS after a contract is in place.
>
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> Reviewed-by: Badhri Jagan Sridharan <badhri@google.com>
> Link: https://lore.kernel.org/r/20241210-get_rev_upstream-v2-2-d0094e52d48f@google.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 46 +++++++++++++++++++++++++++++++++--
> 1 file changed, 44 insertions(+), 2 deletions(-)
I briefly looked at directly backporting this to dev-6.6 from upstream
(8ecf60c3b3d4), but doing so generated conflicts. Did you find the
same? If so, please add a short note about what you fixed to the
trailer as well as your S-o-b tag, e.g.
...
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[Cosmo: Changed <fix summary> to resolve merge conflcts]
Signed-off-by: <Your contact details>
Patch reports fuzz when I apply this to the tip of dev-6.6, which is
currently 5a4c98323b01 ("Merge tag 'v6.6.90' into for/openbmc/dev-
6.6"). Can you address that and re-send?
Cheers,
Andrew
prev parent reply other threads:[~2025-05-16 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 13:53 [PATCH linux dev-6.6] usb: typec: tcpm: Add support for parsing pd-revision DT property Cosmo Chou
2025-05-16 0:59 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=273f8317466446cb997917f9770b6991852e09eb.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=amitsd@google.com \
--cc=chou.cosmo@gmail.com \
--cc=cosmo.chou@quantatw.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.