From: Thomas Monjalon <thomas@monjalon.net>
To: Bing Zhao <bingz@mellanox.com>
Cc: matan@mellanox.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix linking with static ibverbs libraries
Date: Thu, 07 May 2020 00:01:10 +0200 [thread overview]
Message-ID: <2740451.o0KrE1Onz3@thomas> (raw)
In-Reply-To: <1588162315-177263-1-git-send-email-bingz@mellanox.com>
29/04/2020 14:11, Bing Zhao:
> When building a target application with static linking mode via
> makefiles and enable linking to ibverbs libs by setting
> "CONFIG_RTE_IBVERBS_LINK_STATIC=y". The libibverbs.pc will be
> chosen and all the libs listed in the file will be linked
> by default. Some static lib archives may contain the same files
> and common interfaces inside.
> The "--no-whole-archive" needs to be enabled for the linker to
> discard the useless symbols and resolve the symbols redefinition
> error.
>
> Fixes: 95276abaaf0a ("vdpa/mlx5: introduce Mellanox vDPA driver")
The origin is older than vdpa PMD.
It is when introducing ibverbs static linking:
Fixes: 2c0dd7b69fb0 ("config: add static linkage of mlx dependency")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
prev parent reply other threads:[~2020-05-06 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 12:11 [dpdk-dev] [PATCH] mk: fix linking with static ibverbs libraries Bing Zhao
2020-05-06 22:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2740451.o0KrE1Onz3@thomas \
--to=thomas@monjalon.net \
--cc=bingz@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.