All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans-Frieder Vogt <hfvogt@gmx.net>
To: zbr@ioremap.net, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] w1 - call request_module with w1 master mutex unlocked
Date: Sun, 06 Oct 2013 21:13:40 +0200	[thread overview]
Message-ID: <2740843.j7PY66riEd@maximilian> (raw)

request_module for w1 slave modules needs to be called with the w1 master 
mutex
unlocked. Because w1_attach_slave_device gets always(?) called with mutex
locked, we need to temporarily unlock the w1 master mutex for the loading of 
the
w1 slave module.

Signed-off by: Hans-Frieder Vogt <hfvogt@gmx.net>
---
 drivers/w1/w1.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/w1/w1.c	2013-10-06 14:58:45.246528318 +0200
+++ b/drivers/w1/w1.c	2013-10-06 19:13:04.115279322 +0200
@@ -716,7 +716,10 @@ static int w1_attach_slave_device(struct
 	atomic_set(&sl->refcnt, 0);
 	init_completion(&sl->released);
 
+	/* slave modules need to be loaded in a context with unlocked mutex */
+	mutex_unlock(&dev->mutex);
 	request_module("w1-family-0x%0x", rn->family);
+	mutex_lock(&dev->mutex);
 
 	spin_lock(&w1_flock);
 	f = w1_family_registered(rn->family);

Hans-Frieder Vogt                       e-mail: hfvogt <at> gmx .dot. net


                 reply	other threads:[~2013-10-06 19:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2740843.j7PY66riEd@maximilian \
    --to=hfvogt@gmx.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.