From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A1D0CD98F2 for ; Mon, 22 Jun 2026 11:09:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC5B510E626; Mon, 22 Jun 2026 11:09:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nDwCWH5K"; dkim-atps=neutral Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73C4110E626 for ; Mon, 22 Jun 2026 11:09:24 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-490bc6a7958so39502765e9.1 for ; Mon, 22 Jun 2026 04:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782126563; x=1782731363; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mnFRwyog2vTpmK7RSbZ3I519uJGLK8n4WMSRCaUqNSE=; b=nDwCWH5KLNKZpUtAj7PqQLpkNBBT9et+eXkqwv8t3PiazXQTDqE6uw3Hs9ia/Gbh8u UYP8d6MJ7+UV/5S/akoVWZHFEI/TSGvhxYbaf7/IRZd1/lFxCKFZxu0+rPxov4Dl7dKV sxypN4WPlWDl0oKX2iQqmaMZWJ5v6E7avBNTZAZVw0hTCECvCAKkGvgHWN0U4uKu40a7 aTrGKB5KOEuErlgXq2vSyZdSI4umGBM1o69YoRjW6WpK/ZGk5d2x9v+On+KBVG1LVXlq mjsApncynXItrixNs2y1ue5xKikotgWQWS+WeFeBxO5D04hQCDlRcaG/vAgaF7D+g1fL souA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782126563; x=1782731363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mnFRwyog2vTpmK7RSbZ3I519uJGLK8n4WMSRCaUqNSE=; b=acDeI3uW1O44i53Ey/YDO+GKdbmjbmf8GcoFV/Q6qKHHMR+6DaeXlvmpRKhJ4M9gdJ sLXw7CRdxa0941PNmZdfFvw7usrb9/ORXFZTqGJe4nol4fk1/c3VzUmKERhNukxZ2czh EO+kQUMXDhDRNB+/jjAMt3q2lnzvtLXbOXynfN7Q5Rlq0mbpwvpB1sheZMcrKBcBaaWB wVToxwLZYY76pGwcpqPQ0Il6ycjLiKvtTToqWwlyKTr36MXkh4QpsMqpSqXHCvce71kS 0tmVd3ZwRBF2jn03OArY5gsyu3dN9RC5ZGwgYDOVEQST3DfvY6egt6DknVxjXSKy35L4 n09Q== X-Gm-Message-State: AOJu0Yxt706zTmNsSQjNLjtd6GcibknZwA1TQXNwQY4zmbrUI9+eEBR1 5d+ObYcybb51TZM8nWKyNZwK158RxBYeAZdjLuKbMlN00B42IWT+IR3vLslPrQ== X-Gm-Gg: AfdE7cm4S2jtBkLLxzLzz3x4UaeoCoWN42FBL//vDnQQ7HRDUFNNX5k3qTtFglRGRHe wiO7eU/bDTvUqfy06hyQw7IHye9bOScFLT5QCOWIIKBA8sXys+pMdRQ1jfCBJqwMYL4EXBKATuj EMlLeh+6tOl54Hy36tZvDdS9f9jv74vL6ZxOy3Tv1U8fuuovxwrO1Qa7/T6IJWt0dHagPG7dFdK EEzQbVEuxITRsxJk6MTwiOgC4qDWNbt8fM90ZDMT+dRTvZZqinAiT9tIm00JqTs5zQrXFofIVhC j36O/xIgwi8SIz7f8sqV2f48NfOazWS2Lfn6CVhE0Gh31xl8Mw5QlpZiNIhdBtA74oYqi/pJ8kd Yk50GQ8BgD4VDBhOMFRbSqJaTXUlglG15PKm+R1NVHAWM59ZLjVu7d4079JgrAHSlYVECHzuPfN euTSNRc5H/+QiozVMqS2Eao8awqYSdXptqAkh+CSHdcUJLjSW5SaEQ2SFCWeg4yFisq/i2J8Oxr pMuJUFwr28bC3EvXFNXkS0vwxHd8g== X-Received: by 2002:a05:600c:24b:b0:490:bf3d:c7de with SMTP id 5b1f17b1804b1-49240a38c14mr134902725e9.10.1782126562607; Mon, 22 Jun 2026 04:09:22 -0700 (PDT) Received: from timur-max.localnet (20014C4E24F13B00B65759E31FE89790.dsl.pool.telekom.hu. [2001:4c4e:24f1:3b00:b657:59e3:1fe8:9790]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-466648c5413sm26440531f8f.11.2026.06.22.04.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 04:09:22 -0700 (PDT) From: Timur =?UTF-8?B?S3Jpc3TDs2Y=?= To: "Koenig, Christian" , "Deucher, Alexander" , "SHANMUGAM, SRINIVASAN" Cc: "amd-gfx@lists.freedesktop.org" Subject: Re: [PATCH] drm/amdgpu: Reduce stack usage in IP block soft reset Date: Mon, 22 Jun 2026 13:07:58 +0200 Message-ID: <27422769.1r3eYUQgxm@timur-max> In-Reply-To: References: <20260619171733.2976352-1-srinivasan.shanmugam@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 2026. j=C3=BAnius 22., h=C3=A9tf=C5=91 11:10:40 k=C3=B6z=C3=A9p-eur=C3= =B3pai ny=C3=A1ri id=C5=91 SHANMUGAM,=20 SRINIVASAN wrote: >=20 > I took another look at the implementation. The temporary array is > currently only used to collect the subset of affected rings and pass > them to the multi-ring reset helpers. >=20 > amdgpu_filter_rings() simply copies matching entries from > adev->rings[] into a temporary array, and the helpers only iterate > over that array. >=20 > From what I can see, adev->rings[] appears to be a stable device ring > list, so it seems possible to eliminate the intermediate array > entirely and have the helpers iterate directly over adev->rings[] > while applying the same ring_type_mask filter. >=20 > Hi Timur, was the temporary array intended to provide snapshot semantics > for the affected rings, or was it mainly introduced for convenience? >=20 > If there is no snapshot requirement, I'll respin the patch by removing > the temporary array altogether. >=20 > Regards, > Srini Hi Srini, I'm sorry for the trouble, I haven't seen this warning. Please give me a moment, I can send a fix later today. Thanks & best regards, Timur