From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F19CEC6FD1D for ; Wed, 15 Mar 2023 16:06:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DCD351553; Wed, 15 Mar 2023 17:05:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DCD351553 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678896376; bh=86IeAvpsTT3xJy/sz6LqwjgqlIjj1bKneY0DeRcEJvM=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=J80xXMD7HdRKrLCHNUOd9Yw9pYaUz9gNjeXqLOACZa0yEtQi95kieaXvKpV57e1vT P5f9+xSiKZ3SbnOR34dXVgT53I4TzXeDjVS6qFEWI/wTCkTFcJymw2egFKEOV7i6yf gEEt5REmC6Z6dUUepKT20ZnZR2gkG9hv6PjHSN1c= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B2D65F80520; Wed, 15 Mar 2023 17:05:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 56BBDF80527; Wed, 15 Mar 2023 17:05:10 +0100 (CET) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 562BCF80482 for ; Wed, 15 Mar 2023 17:05:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 562BCF80482 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=GYgwADQD Received: by mail-ed1-x52f.google.com with SMTP id w9so6721251edc.3 for ; Wed, 15 Mar 2023 09:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678896305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OrfavOiI9RHFnuLIIn9fSoym+hJaH0KWDtFZHQ7FhFE=; b=GYgwADQDRBv/KWKhXsXUcAUFhDAgznha4R9pZMM9lDygOvRsskp2sjqb5eGtcIsRjb +BQBH+S7c2+bFJrgEcsJ33lmxXF+xaHV+Zf6R1acx0kd4THA11wrWaDE2PS71ADw1nhn Zx65qJONgMbEaCHuppuPpK/f19Y0eRvpyxKFsy2BYQpLOWC1Mysn+5xwS+qj0OBSMovR Uao5l7U1tmHILuzCEi0wR413TLsrQz3cmOUWwtDxd4w6T4wD/oEOOPpUwbCuBoECppEq vBHqkwqTycHcEvSf+HIIuFtDOtNKeTswqPcdwrlIsB2rmFNZOi/+cUOYLoGfJBl78Au4 pr1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678896305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OrfavOiI9RHFnuLIIn9fSoym+hJaH0KWDtFZHQ7FhFE=; b=XLlwFwi9if5HofIt7lOOazq1P/2SDcTiNoe/XUb2Jr6AcCM9RUUKR06oSVKZkR9ifd 2zexoE365nNl2B/kGusug1a7A/Y4t2Iq8Z+GHoGAWhsOQYMncHOAxFR3mRFHTh+hKYyh SbESbyvVZUMEDmrg2udA7YpyqgL5zO3QDjrS14G42/t23euVvsUDQn72FaQ7waqJTdUD qLMqblfR6XLO56pC3GzXKTHmRPTpBWPHfhvCHE7hqmB2KjL4u7XRo+tlqxdRFY3VlrDL 8sv8PIyzb/PLsbcug6CBLdjvlX4C4/ybsJEhCSURaoNbNl30+rFE5ZTbDxK8vtugGOnd Wh9Q== X-Gm-Message-State: AO0yUKWWnORzCWZXecT66F2QbFGFAJ51U/piDy+J4NJQjiOjiA/4gxeA Xvm4pwvk962V3PfQxqcNaOs= X-Google-Smtp-Source: AK7set+myhS2q8BMTQLFMetCV+tCvu86Y0EnLMDAIQz6lrKoBkjoRsSEoQr/z5hKWoUoEpc8DQ+YAQ== X-Received: by 2002:a17:906:d211:b0:926:9c33:ea4 with SMTP id w17-20020a170906d21100b009269c330ea4mr7175408ejz.27.1678896305325; Wed, 15 Mar 2023 09:05:05 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id h11-20020a17090619cb00b008b30e2a450csm2714894ejd.144.2023.03.15.09.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 09:05:04 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , Charles Keepax , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Subject: Re: [PATCH 142/173] ASoC: sunxi: sun4i-spdif: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 17:05:03 +0100 Message-ID: <2745562.BEx9A2HvPv@jernej-laptop> In-Reply-To: <20230315150745.67084-143-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <20230315150745.67084-143-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Message-ID-Hash: DQIJEVTI3ZX45QME3FVGE5FI4HAT4ROC X-Message-ID-Hash: DQIJEVTI3ZX45QME3FVGE5FI4HAT4ROC X-MailFrom: jernej.skrabec@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Dne sreda, 15. marec 2023 ob 16:07:14 CET je Uwe Kleine-K=F6nig napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > sound/soc/sunxi/sun4i-spdif.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > index bcceebca915a..ff18d4113aac 100644 > --- a/sound/soc/sunxi/sun4i-spdif.c > +++ b/sound/soc/sunxi/sun4i-spdif.c > @@ -703,13 +703,11 @@ static int sun4i_spdif_probe(struct platform_device > *pdev) return ret; > } >=20 > -static int sun4i_spdif_remove(struct platform_device *pdev) > +static void sun4i_spdif_remove(struct platform_device *pdev) > { > pm_runtime_disable(&pdev->dev); > if (!pm_runtime_status_suspended(&pdev->dev)) > sun4i_spdif_runtime_suspend(&pdev->dev); > - > - return 0; > } >=20 > static const struct dev_pm_ops sun4i_spdif_pm =3D { > @@ -724,7 +722,7 @@ static struct platform_driver sun4i_spdif_driver =3D { > .pm =3D &sun4i_spdif_pm, > }, > .probe =3D sun4i_spdif_probe, > - .remove =3D sun4i_spdif_remove, > + .remove_new =3D sun4i_spdif_remove, > }; >=20 > module_platform_driver(sun4i_spdif_driver); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 509AEC7618B for ; Wed, 15 Mar 2023 16:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wnFpoRAMQKtKDsAqIr2FtZdld7bbBM3OCyAxR1aLofQ=; b=UOOtC71bH4+tht 7CDTo5OAjjepm3CzzVBtcq6vUZelUmMyj7FRYuULDR5/R0mFnoZr8kMu6UkDRtqSmjg5oFoSCQnc8 Erchl7jG/cPQalio1PaLW812s6tN8idCeURQ1Of8mwqIpdL906T+IYBN61zTRFTylQScQz+x583rX s6NPxXsyRw/hC22o337YVN87xV8oiF95BN/zliDerxpg7sasre/rk79HpyACdsyYa86J4Y7zER3IZ pVU+cz3gLH9HI5G2X9W+ARPk8p8xlpnM1bxz/RdQGaqGboTVBWp1XpZQTVnAH56ER5nzY8OEhv863 nreitAE5e1JztYODq9aQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcTci-00E0Cp-0T; Wed, 15 Mar 2023 16:05:08 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcTcf-00E02T-3A for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 16:05:07 +0000 Received: by mail-ed1-x529.google.com with SMTP id o12so77492553edb.9 for ; Wed, 15 Mar 2023 09:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678896305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OrfavOiI9RHFnuLIIn9fSoym+hJaH0KWDtFZHQ7FhFE=; b=GYgwADQDRBv/KWKhXsXUcAUFhDAgznha4R9pZMM9lDygOvRsskp2sjqb5eGtcIsRjb +BQBH+S7c2+bFJrgEcsJ33lmxXF+xaHV+Zf6R1acx0kd4THA11wrWaDE2PS71ADw1nhn Zx65qJONgMbEaCHuppuPpK/f19Y0eRvpyxKFsy2BYQpLOWC1Mysn+5xwS+qj0OBSMovR Uao5l7U1tmHILuzCEi0wR413TLsrQz3cmOUWwtDxd4w6T4wD/oEOOPpUwbCuBoECppEq vBHqkwqTycHcEvSf+HIIuFtDOtNKeTswqPcdwrlIsB2rmFNZOi/+cUOYLoGfJBl78Au4 pr1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678896305; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OrfavOiI9RHFnuLIIn9fSoym+hJaH0KWDtFZHQ7FhFE=; b=jfeMKxVth2bZA8MzTTgl4VfE4SluRwK8hPfr+nTkUqGumnOrkN2+APAGx3yWzlwq2D V8wB7mRZH4WsyQLv1dzm46s7J/qgFySA1pq5sfvO6GK/NUB+la6TUuLd6ASWnI2b9R6a nbewGVFRi96jJ1T9AimrkzLRVkp9E8BuEbqaBbUg0xyF9VegumKLrp5HaZufmpyMiZT1 yd7lUh8ONX7NNoL/H9MpJSNx9R+aCEynGd1nIwzQcxGfKGY39haRD3xuLAu2nhHq0QgX aRvmXypXPRHOqCSPsBPOAh5mfUixb3DenjNga9ntiVVYitC4E8oIWLGWtbxMboUQK9yT ZPKQ== X-Gm-Message-State: AO0yUKWO0oSnbp9FhDHDbDGPmLXYxDqDkM95JUXONbBncAQ77qsarqfn 0zdNNeEA4qGOvmh5n/FbNXM= X-Google-Smtp-Source: AK7set+myhS2q8BMTQLFMetCV+tCvu86Y0EnLMDAIQz6lrKoBkjoRsSEoQr/z5hKWoUoEpc8DQ+YAQ== X-Received: by 2002:a17:906:d211:b0:926:9c33:ea4 with SMTP id w17-20020a170906d21100b009269c330ea4mr7175408ejz.27.1678896305325; Wed, 15 Mar 2023 09:05:05 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id h11-20020a17090619cb00b008b30e2a450csm2714894ejd.144.2023.03.15.09.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 09:05:04 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , Charles Keepax , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 142/173] ASoC: sunxi: sun4i-spdif: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 17:05:03 +0100 Message-ID: <2745562.BEx9A2HvPv@jernej-laptop> In-Reply-To: <20230315150745.67084-143-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <20230315150745.67084-143-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_090506_016182_F55E64EA X-CRM114-Status: GOOD ( 21.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 15. marec 2023 ob 16:07:14 CET je Uwe Kleine-K=F6nig napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > sound/soc/sunxi/sun4i-spdif.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > index bcceebca915a..ff18d4113aac 100644 > --- a/sound/soc/sunxi/sun4i-spdif.c > +++ b/sound/soc/sunxi/sun4i-spdif.c > @@ -703,13 +703,11 @@ static int sun4i_spdif_probe(struct platform_device > *pdev) return ret; > } > = > -static int sun4i_spdif_remove(struct platform_device *pdev) > +static void sun4i_spdif_remove(struct platform_device *pdev) > { > pm_runtime_disable(&pdev->dev); > if (!pm_runtime_status_suspended(&pdev->dev)) > sun4i_spdif_runtime_suspend(&pdev->dev); > - > - return 0; > } > = > static const struct dev_pm_ops sun4i_spdif_pm =3D { > @@ -724,7 +722,7 @@ static struct platform_driver sun4i_spdif_driver =3D { > .pm =3D &sun4i_spdif_pm, > }, > .probe =3D sun4i_spdif_probe, > - .remove =3D sun4i_spdif_remove, > + .remove_new =3D sun4i_spdif_remove, > }; > = > module_platform_driver(sun4i_spdif_driver); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel