From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:42858 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727795AbeIUO27 (ORCPT ); Fri, 21 Sep 2018 10:28:59 -0400 From: Laurent Pinchart To: Simon Horman Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Ulrich Hecht , Kieran Bingham Subject: Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support Date: Fri, 21 Sep 2018 11:41:21 +0300 Message-ID: <27459145.vaq36xxRCg@avalon> In-Reply-To: <20180921071643.zjivbv3umlgcruzu@verge.net.au> References: <20180914091046.483-1-laurent.pinchart+renesas@ideasonboard.com> <1942172.7Is2si9RQ9@avalon> <20180921071643.zjivbv3umlgcruzu@verge.net.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Simon, On Friday, 21 September 2018 10:16:44 EEST Simon Horman wrote: > On Wed, Sep 19, 2018 at 04:11:36PM +0300, Laurent Pinchart wrote: > > On Wednesday, 19 September 2018 11:35:07 EEST Simon Horman wrote: > >> On Mon, Sep 17, 2018 at 11:59:32AM +0300, Laurent Pinchart wrote: > >>> On Monday, 17 September 2018 11:54:04 EEST Laurent Pinchart wrote: > >>>> On Monday, 17 September 2018 11:47:15 EEST Laurent Pinchart wrote: > >>>>> On Monday, 17 September 2018 11:14:20 EEST Simon Horman wrote: > >>>>>> On Mon, Sep 17, 2018 at 09:50:55AM +0200, Simon Horman wrote: > >>>>>>> On Fri, Sep 14, 2018 at 12:10:43PM +0300, Laurent Pinchart wrote: > >>>>>>>> The R8A77990 (E3) platform has one RGB output and two LVDS > >>>>>>>> outputs connected to the DU. Add the DT nodes for the DU, LVDS > >>>>>>>> encoders and supporting VSP and FCP. > >>>>>>>> > >>>>>>>> Signed-off-by: Laurent Pinchart > >>>>>>>> > >>>>>>>> Tested-by: Jacopo Mondi > >>>>>>>> --- > >>>>>>>> > >>>>>>>> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 167 +++++++++++++++++ > >>>>>>>> 1 file changed, 167 insertions(+) > >>>>>>>> > >>>>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > >>>>>>>> b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index > >>>>>>>> abb14af76c0e..600074ca3ee5 100644 > >>>>>>>> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > >>>>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > > > [snip] > > > >>>>>>>> + lvds0: lvds-encoder@feb90000 { > >>>>>>>> + compatible = "renesas,r8a77990-lvds"; > >>>>>>>> + reg = <0 0xfeb90000 0 0x20>; > >>>>>>>> + clocks = <&cpg CPG_MOD 727>; > >>>>>>>> + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > >>>>>>>> + resets = <&cpg 727>; > >>>>>>>> + status = "disabled"; > >>>>>>>> + > >>>>>>>> + ports { > >>>>>>>> + #address-cells = <1>; > >>>>>>>> + #size-cells = <0>; > >>>>>>>> + > >>>>>>>> + port@0 { > >>>>>>>> + reg = <0>; > >>>>>>>> + lvds0_in: endpoint { > >>>>>>>> + remote-endpoint = <&du_out_lvds0>; > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> + > >>>>>>>> + port@1 { > >>>>>>>> + reg = <1>; > >>>>>>>> + lvds0_out: endpoint { > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> + > >>>>>>>> + lvds1: lvds-encoder@feb90100 { > >>>>>>>> + compatible = "renesas,r8a77990-lvds"; > >>>>>>>> + reg = <0 0xfeb90100 0 0x20>; > >>>>>>>> + clocks = <&cpg CPG_MOD 727>; > >>>>>>>> + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > >>>>>>>> + resets = <&cpg 726>; > >>>>>> > >>>>>> Also, is the missmatch between the index for the clock and reset > >>>>>> intentional? > >>>>> > >>>>> It is. According to the datasheet, the two LVDS encoders have > >>>>> different module stop bits, but share the same reset (lovely > >>>>> hardware design, it will be fun to support that in the driver :-S). > >>>> > >>>> Sorry, I got it wrong. it's bit 725 that is shared between the two > >>>> LVDS encoders, to reset the two LVDS PLLs together. The encoders > >>>> themselves still have independent reset bits. I'll fix this. > >>> > >>> And of course it's the clock you were commenting on, not the reset. > >>> *sigh* > >>> > >>> According to the datasheets the two LVDS encoders share one MSTP. > >>> Whether that's a mistake in the documentation or not I can't tell yet, > >>> as I have only tested LVDS0. > >> > >> Could we follow-up with the HW team? > >> I'm not opposed to taking the patch with this portion as-is > >> but it would be good to clarify this somehow. > > > > I tried setting the clock to MSTP 726, and I then get vblank interrupt > > timeouts. Furthermore I've now tested the LVDS1 output with a display > > panel, and while I still can't get the backlight to work, the panel > > displays the correct image with MSTP 727. I thus conclude that the above > > is correct. > > Thanks for the follow-up, that sounds reasonable to me. > > Am I correct in thinking a v3 of this patchset is on its way regardless? Yes, you're correct. > >>>>>>>> + status = "disabled"; > >>>>>>>> + > >>>>>>>> + ports { > >>>>>>>> + #address-cells = <1>; > >>>>>>>> + #size-cells = <0>; > >>>>>>>> + > >>>>>>>> + port@0 { > >>>>>>>> + reg = <0>; > >>>>>>>> + lvds1_in: endpoint { > >>>>>>>> + remote-endpoint = <&du_out_lvds1>; > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> + > >>>>>>>> + port@1 { > >>>>>>>> + reg = <1>; > >>>>>>>> + lvds1_out: endpoint { > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> + }; > >>>>>>>> + }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support Date: Fri, 21 Sep 2018 11:41:21 +0300 Message-ID: <27459145.vaq36xxRCg@avalon> References: <20180914091046.483-1-laurent.pinchart+renesas@ideasonboard.com> <1942172.7Is2si9RQ9@avalon> <20180921071643.zjivbv3umlgcruzu@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36FA86E718 for ; Fri, 21 Sep 2018 08:41:11 +0000 (UTC) In-Reply-To: <20180921071643.zjivbv3umlgcruzu@verge.net.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Simon Horman Cc: linux-renesas-soc@vger.kernel.org, Ulrich Hecht , Laurent Pinchart , Kieran Bingham , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2ltb24sCgpPbiBGcmlkYXksIDIxIFNlcHRlbWJlciAyMDE4IDEwOjE2OjQ0IEVFU1QgU2lt b24gSG9ybWFuIHdyb3RlOgo+IE9uIFdlZCwgU2VwIDE5LCAyMDE4IGF0IDA0OjExOjM2UE0gKzAz MDAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBXZWRuZXNkYXksIDE5IFNlcHRlbWJl ciAyMDE4IDExOjM1OjA3IEVFU1QgU2ltb24gSG9ybWFuIHdyb3RlOgo+ID4+IE9uIE1vbiwgU2Vw IDE3LCAyMDE4IGF0IDExOjU5OjMyQU0gKzAzMDAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4g Pj4+IE9uIE1vbmRheSwgMTcgU2VwdGVtYmVyIDIwMTggMTE6NTQ6MDQgRUVTVCBMYXVyZW50IFBp bmNoYXJ0IHdyb3RlOgo+ID4+Pj4gT24gTW9uZGF5LCAxNyBTZXB0ZW1iZXIgMjAxOCAxMTo0Nzox NSBFRVNUIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4+Pj4gT24gTW9uZGF5LCAxNyBTZXB0 ZW1iZXIgMjAxOCAxMToxNDoyMCBFRVNUIFNpbW9uIEhvcm1hbiB3cm90ZToKPiA+Pj4+Pj4gT24g TW9uLCBTZXAgMTcsIDIwMTggYXQgMDk6NTA6NTVBTSArMDIwMCwgU2ltb24gSG9ybWFuIHdyb3Rl Ogo+ID4+Pj4+Pj4gT24gRnJpLCBTZXAgMTQsIDIwMTggYXQgMTI6MTA6NDNQTSArMDMwMCwgTGF1 cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4+Pj4+PiBUaGUgUjhBNzc5OTAgKEUzKSBwbGF0Zm9y bSBoYXMgb25lIFJHQiBvdXRwdXQgYW5kIHR3byBMVkRTCj4gPj4+Pj4+Pj4gb3V0cHV0cyBjb25u ZWN0ZWQgdG8gdGhlIERVLiBBZGQgdGhlIERUIG5vZGVzIGZvciB0aGUgRFUsIExWRFMKPiA+Pj4+ Pj4+PiBlbmNvZGVycyBhbmQgc3VwcG9ydGluZyBWU1AgYW5kIEZDUC4KPiA+Pj4+Pj4+PiAKPiA+ Pj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0Cj4gPj4+Pj4+Pj4gPGxhdXJl bnQucGluY2hhcnQrcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+ID4+Pj4+Pj4+IFRlc3RlZC1i eTogSmFjb3BvIE1vbmRpIDxqYWNvcG8rcmVuZXNhc0BqbW9uZGkub3JnPgo+ID4+Pj4+Pj4+IC0t LQo+ID4+Pj4+Pj4+IAo+ID4+Pj4+Pj4+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhh Nzc5OTAuZHRzaSB8IDE2NyArKysrKysrKysrKysrKysrKwo+ID4+Pj4+Pj4+ICAxIGZpbGUgY2hh bmdlZCwgMTY3IGluc2VydGlvbnMoKykKPiA+Pj4+Pj4+PiAKPiA+Pj4+Pj4+PiBkaWZmIC0tZ2l0 IGEvYXJjaC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTkwLmR0c2kKPiA+Pj4+Pj4+PiBi L2FyY2gvYXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk5MC5kdHNpIGluZGV4Cj4gPj4+Pj4+ Pj4gYWJiMTRhZjc2YzBlLi42MDAwNzRjYTNlZTUgMTAwNjQ0Cj4gPj4+Pj4+Pj4gLS0tIGEvYXJj aC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTkwLmR0c2kKPiA+Pj4+Pj4+PiArKysgYi9h cmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5OTAuZHRzaQo+ID4gCj4gPiBbc25pcF0K PiA+IAo+ID4+Pj4+Pj4+ICsJCWx2ZHMwOiBsdmRzLWVuY29kZXJAZmViOTAwMDAgewo+ID4+Pj4+ Pj4+ICsJCQljb21wYXRpYmxlID0gInJlbmVzYXMscjhhNzc5OTAtbHZkcyI7Cj4gPj4+Pj4+Pj4g KwkJCXJlZyA9IDwwIDB4ZmViOTAwMDAgMCAweDIwPjsKPiA+Pj4+Pj4+PiArCQkJY2xvY2tzID0g PCZjcGcgQ1BHX01PRCA3Mjc+Owo+ID4+Pj4+Pj4+ICsJCQlwb3dlci1kb21haW5zID0gPCZzeXNj IFI4QTc3OTkwX1BEX0FMV0FZU19PTj47Cj4gPj4+Pj4+Pj4gKwkJCXJlc2V0cyA9IDwmY3BnIDcy Nz47Cj4gPj4+Pj4+Pj4gKwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gPj4+Pj4+Pj4gKwo+ID4+ Pj4+Pj4+ICsJCQlwb3J0cyB7Cj4gPj4+Pj4+Pj4gKwkJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsK PiA+Pj4+Pj4+PiArCQkJCSNzaXplLWNlbGxzID0gPDA+Owo+ID4+Pj4+Pj4+ICsKPiA+Pj4+Pj4+ PiArCQkJCXBvcnRAMCB7Cj4gPj4+Pj4+Pj4gKwkJCQkJcmVnID0gPDA+Owo+ID4+Pj4+Pj4+ICsJ CQkJCWx2ZHMwX2luOiBlbmRwb2ludCB7Cj4gPj4+Pj4+Pj4gKwkJCQkJCXJlbW90ZS1lbmRwb2lu dCA9IDwmZHVfb3V0X2x2ZHMwPjsKPiA+Pj4+Pj4+PiArCQkJCQl9Owo+ID4+Pj4+Pj4+ICsJCQkJ fTsKPiA+Pj4+Pj4+PiArCj4gPj4+Pj4+Pj4gKwkJCQlwb3J0QDEgewo+ID4+Pj4+Pj4+ICsJCQkJ CXJlZyA9IDwxPjsKPiA+Pj4+Pj4+PiArCQkJCQlsdmRzMF9vdXQ6IGVuZHBvaW50IHsKPiA+Pj4+ Pj4+PiArCQkJCQl9Owo+ID4+Pj4+Pj4+ICsJCQkJfTsKPiA+Pj4+Pj4+PiArCQkJfTsKPiA+Pj4+ Pj4+PiArCQl9Owo+ID4+Pj4+Pj4+ICsKPiA+Pj4+Pj4+PiArCQlsdmRzMTogbHZkcy1lbmNvZGVy QGZlYjkwMTAwIHsKPiA+Pj4+Pj4+PiArCQkJY29tcGF0aWJsZSA9ICJyZW5lc2FzLHI4YTc3OTkw LWx2ZHMiOwo+ID4+Pj4+Pj4+ICsJCQlyZWcgPSA8MCAweGZlYjkwMTAwIDAgMHgyMD47Cj4gPj4+ Pj4+Pj4gKwkJCWNsb2NrcyA9IDwmY3BnIENQR19NT0QgNzI3PjsKPiA+Pj4+Pj4+PiArCQkJcG93 ZXItZG9tYWlucyA9IDwmc3lzYyBSOEE3Nzk5MF9QRF9BTFdBWVNfT04+Owo+ID4+Pj4+Pj4+ICsJ CQlyZXNldHMgPSA8JmNwZyA3MjY+Owo+ID4+Pj4+PiAKPiA+Pj4+Pj4gQWxzbywgaXMgdGhlIG1p c3NtYXRjaCBiZXR3ZWVuIHRoZSBpbmRleCBmb3IgdGhlIGNsb2NrIGFuZCByZXNldAo+ID4+Pj4+ PiBpbnRlbnRpb25hbD8KPiA+Pj4+PiAKPiA+Pj4+PiBJdCBpcy4gQWNjb3JkaW5nIHRvIHRoZSBk YXRhc2hlZXQsIHRoZSB0d28gTFZEUyBlbmNvZGVycyBoYXZlCj4gPj4+Pj4gZGlmZmVyZW50IG1v ZHVsZSBzdG9wIGJpdHMsIGJ1dCBzaGFyZSB0aGUgc2FtZSByZXNldCAobG92ZWx5Cj4gPj4+Pj4g aGFyZHdhcmUgZGVzaWduLCBpdCB3aWxsIGJlIGZ1biB0byBzdXBwb3J0IHRoYXQgaW4gdGhlIGRy aXZlciA6LVMpLgo+ID4+Pj4gCj4gPj4+PiBTb3JyeSwgSSBnb3QgaXQgd3JvbmcuIGl0J3MgYml0 IDcyNSB0aGF0IGlzIHNoYXJlZCBiZXR3ZWVuIHRoZSB0d28KPiA+Pj4+IExWRFMgZW5jb2RlcnMs IHRvIHJlc2V0IHRoZSB0d28gTFZEUyBQTExzIHRvZ2V0aGVyLiBUaGUgZW5jb2RlcnMKPiA+Pj4+ IHRoZW1zZWx2ZXMgc3RpbGwgaGF2ZSBpbmRlcGVuZGVudCByZXNldCBiaXRzLiBJJ2xsIGZpeCB0 aGlzLgo+ID4+PiAKPiA+Pj4gQW5kIG9mIGNvdXJzZSBpdCdzIHRoZSBjbG9jayB5b3Ugd2VyZSBj b21tZW50aW5nIG9uLCBub3QgdGhlIHJlc2V0Lgo+ID4+PiAqc2lnaCoKPiA+Pj4gCj4gPj4+IEFj Y29yZGluZyB0byB0aGUgZGF0YXNoZWV0cyB0aGUgdHdvIExWRFMgZW5jb2RlcnMgc2hhcmUgb25l IE1TVFAuCj4gPj4+IFdoZXRoZXIgdGhhdCdzIGEgbWlzdGFrZSBpbiB0aGUgZG9jdW1lbnRhdGlv biBvciBub3QgSSBjYW4ndCB0ZWxsIHlldCwKPiA+Pj4gYXMgSSBoYXZlIG9ubHkgdGVzdGVkIExW RFMwLgo+ID4+IAo+ID4+IENvdWxkIHdlIGZvbGxvdy11cCB3aXRoIHRoZSBIVyB0ZWFtPwo+ID4+ IEknbSBub3Qgb3Bwb3NlZCB0byB0YWtpbmcgdGhlIHBhdGNoIHdpdGggdGhpcyBwb3J0aW9uIGFz LWlzCj4gPj4gYnV0IGl0IHdvdWxkIGJlIGdvb2QgdG8gY2xhcmlmeSB0aGlzIHNvbWVob3cuCj4g PiAKPiA+IEkgdHJpZWQgc2V0dGluZyB0aGUgY2xvY2sgdG8gTVNUUCA3MjYsIGFuZCBJIHRoZW4g Z2V0IHZibGFuayBpbnRlcnJ1cHQKPiA+IHRpbWVvdXRzLiBGdXJ0aGVybW9yZSBJJ3ZlIG5vdyB0 ZXN0ZWQgdGhlIExWRFMxIG91dHB1dCB3aXRoIGEgZGlzcGxheQo+ID4gcGFuZWwsIGFuZCB3aGls ZSBJIHN0aWxsIGNhbid0IGdldCB0aGUgYmFja2xpZ2h0IHRvIHdvcmssIHRoZSBwYW5lbAo+ID4g ZGlzcGxheXMgdGhlIGNvcnJlY3QgaW1hZ2Ugd2l0aCBNU1RQIDcyNy4gSSB0aHVzIGNvbmNsdWRl IHRoYXQgdGhlIGFib3ZlCj4gPiBpcyBjb3JyZWN0Lgo+IAo+IFRoYW5rcyBmb3IgdGhlIGZvbGxv dy11cCwgdGhhdCBzb3VuZHMgcmVhc29uYWJsZSB0byBtZS4KPiAKPiBBbSBJIGNvcnJlY3QgaW4g dGhpbmtpbmcgYSB2MyBvZiB0aGlzIHBhdGNoc2V0IGlzIG9uIGl0cyB3YXkgcmVnYXJkbGVzcz8K ClllcywgeW91J3JlIGNvcnJlY3QuCgo+ID4+Pj4+Pj4+ICsJCQlzdGF0dXMgPSAiZGlzYWJsZWQi Owo+ID4+Pj4+Pj4+ICsKPiA+Pj4+Pj4+PiArCQkJcG9ydHMgewo+ID4+Pj4+Pj4+ICsJCQkJI2Fk ZHJlc3MtY2VsbHMgPSA8MT47Cj4gPj4+Pj4+Pj4gKwkJCQkjc2l6ZS1jZWxscyA9IDwwPjsKPiA+ Pj4+Pj4+PiArCj4gPj4+Pj4+Pj4gKwkJCQlwb3J0QDAgewo+ID4+Pj4+Pj4+ICsJCQkJCXJlZyA9 IDwwPjsKPiA+Pj4+Pj4+PiArCQkJCQlsdmRzMV9pbjogZW5kcG9pbnQgewo+ID4+Pj4+Pj4+ICsJ CQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmR1X291dF9sdmRzMT47Cj4gPj4+Pj4+Pj4gKwkJCQkJ fTsKPiA+Pj4+Pj4+PiArCQkJCX07Cj4gPj4+Pj4+Pj4gKwo+ID4+Pj4+Pj4+ICsJCQkJcG9ydEAx IHsKPiA+Pj4+Pj4+PiArCQkJCQlyZWcgPSA8MT47Cj4gPj4+Pj4+Pj4gKwkJCQkJbHZkczFfb3V0 OiBlbmRwb2ludCB7Cj4gPj4+Pj4+Pj4gKwkJCQkJfTsKPiA+Pj4+Pj4+PiArCQkJCX07Cj4gPj4+ Pj4+Pj4gKwkJCX07Cj4gPj4+Pj4+Pj4gKwkJfTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5j aGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK