From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] ip_pipeline: add sample
	configuration/script files
Date: Mon, 14 Dec 2015 14:28:33 +0100
Message-ID: <2746388.sSZjSxRLON@xps13>
References: <1450095122-86323-1-git-send-email-jasvinder.singh@intel.com>
 <1450097325-86556-1-git-send-email-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jasvinder Singh <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 8057637B3
 for <dev@dpdk.org>; Mon, 14 Dec 2015 14:29:49 +0100 (CET)
Received: by wmnn186 with SMTP id n186so120866555wmn.0
 for <dev@dpdk.org>; Mon, 14 Dec 2015 05:29:49 -0800 (PST)
In-Reply-To: <1450097325-86556-1-git-send-email-jasvinder.singh@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-14 12:48, Jasvinder Singh:
> This patch includes the configuration and script
> files of the some applications which can
> be built using DPDK Packet Framework. A
> configuration file defines the application
> structure which include packet processing stages
> (knowns as pipelines), their connectivity and
> other parameters necessary to start and run the
> application. A script file specifies CLI commands
> required for loading table entries (rules/routes,
> etc). The configuration/script files for simple
> applications such as l2 forwarding, l3 forwarding
> have been presented. In addition, to demonstrate
> the use and inter-connectivity of various pipeline
> modules (which are avilable in packet framework),
> a complex packet processing workload i.e. edge
> router is considered. The configuration of the
> pipeline stages used for upstream and downstream
> flow processing has been specified separately in
> two configuration files. All these configuration
> and script files don't affect the compilation.

Please use at least 70 chars-wide lines.
It would also be easier to read with some paragraphs.

> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

> ---
> *v2
> - correct date in license header(edge_router_downstream/upstream.cfg)
> - modify commit message
> 
> *v3
> - correct date in license header(l2fwd.cfg, l3fwd.cfg)
> 
>  .../ip_pipeline/config/edge_router_downstream.cfg  |  85 ++++++++++++++++
>  .../ip_pipeline/config/edge_router_downstream.sh   |  10 ++
>  .../ip_pipeline/config/edge_router_upstream.cfg    | 110 +++++++++++++++++++++
>  .../ip_pipeline/config/edge_router_upstream.sh     |  38 +++++++
>  examples/ip_pipeline/config/l2fwd.cfg              |  55 +++++++++++
>  examples/ip_pipeline/config/l3fwd.cfg              |  63 ++++++++++++
>  examples/ip_pipeline/config/l3fwd.sh               |   9 ++
>  7 files changed, 370 insertions(+)
>  create mode 100755 examples/ip_pipeline/config/edge_router_downstream.cfg
>  create mode 100755 examples/ip_pipeline/config/edge_router_downstream.sh
>  create mode 100755 examples/ip_pipeline/config/edge_router_upstream.cfg
>  create mode 100755 examples/ip_pipeline/config/edge_router_upstream.sh
>  create mode 100755 examples/ip_pipeline/config/l2fwd.cfg
>  create mode 100755 examples/ip_pipeline/config/l3fwd.cfg
>  create mode 100755 examples/ip_pipeline/config/l3fwd.sh

checkpatch says:
EXECUTE_PERMISSIONS: do not set execute permissions for source files