From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver Date: Wed, 30 May 2012 16:12:38 +0200 Message-ID: <2750730.NlmEPQp3o6@avalon> References: <1338381179-13290-1-git-send-email-laurent.pinchart@ideasonboard.com> <1338381179-13290-5-git-send-email-laurent.pinchart@ideasonboard.com> <20120530134324.GK30400@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id 717869E954 for ; Wed, 30 May 2012 07:12:16 -0700 (PDT) In-Reply-To: <20120530134324.GK30400@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Sascha, On Wednesday 30 May 2012 15:43:24 Sascha Hauer wrote: > Hi Laurent, > > On Wed, May 30, 2012 at 02:32:59PM +0200, Laurent Pinchart wrote: > > The SH Mobile LCD controller (LCDC) DRM driver supports the main > > graphics plane in RGB and YUV formats, as well as the overlay planes (in > > alpha-blending mode only). > > > > Only flat panel outputs using the parallel interface are supported. > > Support for SYS panels, HDMI and DSI is currently not implemented. > > Have you seen > > http://lists.freedesktop.org/archives/dri-devel/2012-May/023536.html > > and > > http://lists.freedesktop.org/archives/dri-devel/2012-May/023544.html No I hadn't. Thanks for the information. > The first patch is a generic gem helper for dma_alloc_* backed memory > which could serve as a drop in replacement for your gem code. The > latter is a generic helper for the framebuffer handling on these > devices. I saw that your driver supports planes which Lars' patch > currently doesn't, but it should be easy to add support for this. > > I hope these are useful, if not, could you tell what's missing? I'll try to use those and I'll report back. -- Regards, Laurent Pinchart