From: Steven Seeger <steven.seeger@nasa.gov>
To: Philippe Gerum <rpm@xenomai.org>
Cc: Adnan Ali <adnan.ali@wapice.com>,
Sakari Junnila <sakari.junnila@wapice.com>,
"xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: Re: [Xenomai] Unrecoverable FP Unavailable Exception 801
Date: Tue, 24 Apr 2018 14:54:39 -0400 [thread overview]
Message-ID: <2756112.fl8kL14NfF@wirbelwind> (raw)
In-Reply-To: <4715a857-f535-fe49-2506-5abbb16553ed@xenomai.org>
On Wednesday, April 25, 2018 12:49:53 PM EDT Philippe Gerum wrote:
> The fix makes a lot of sense, thanks. This bug slipped under the radar
> for years likely because enabling the ppc fpu in kernel context mainly
> happens when fixing up alignment issues, which rt apps tend to avoid in
> the first place for performance reason by only using aligned memory
> accesses (synchronous exceptions are not that cheap latency-wise).
>
> Regarding the ipipe-4.9.y series, there are several other spots touching
> the msr in this file which may be affected the same way (vsx, altivec,
> spe, anything that involves calling msr_check_and_set/clear_msr() under
> hard masking basically).
>
> Adding a dedicated irq_restore helper which does not touch any other bit
> aside of MSR_EE would make sense there. The BOOK-E version of
> irq_save/restore specifically uses the wrtee* instructions not to touch
> those bits, so we may assume this would be semantically correct to do
> the same for BOOK3-S.
>
> PS: CCing Steven who took over the maintenance of the ppc pipeline from
> kernel 4.14 and on.
Hi guys. Thanks for pointing this out, Jouko. I've looked over this briefly
and agree this is a pretty wide-spread problem. I will take a stab at it
tomorrow.
Regards,
Steven
next prev parent reply other threads:[~2018-04-24 18:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.27.1522680894.4366.xenomai@xenomai.org>
2018-04-03 13:57 ` [Xenomai] Unrecoverable FP Unavailable Exception 801 Steven Seeger
2018-04-03 18:31 ` Lennart Sorensen
2018-04-03 18:34 ` Steven Seeger
2018-04-04 10:10 ` Sagi Maimon
2018-04-04 10:17 ` Sagi Maimon
2018-04-04 12:55 ` Seeger, Steven D. (GSFC-582.0)[Embedded Flight Systems, Inc]
2018-04-04 12:57 ` Sagi Maimon
2018-04-04 14:45 ` Lennart Sorensen
2018-04-04 14:53 ` Sagi Maimon
2018-04-04 15:25 ` Steven Seeger
2018-04-04 15:42 ` Sagi Maimon
2018-04-04 17:16 ` Steven Seeger
2018-04-25 8:54 ` Jouko Haapaluoma
2018-04-25 10:03 ` Sagi Maimon
2018-04-25 16:49 ` Philippe Gerum
2018-04-24 18:54 ` Steven Seeger [this message]
2018-04-30 3:21 ` Steven Seeger
2018-04-02 12:56 Sagi Maimon
2018-04-02 14:19 ` Philippe Gerum
2018-04-02 15:23 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2756112.fl8kL14NfF@wirbelwind \
--to=steven.seeger@nasa.gov \
--cc=adnan.ali@wapice.com \
--cc=rpm@xenomai.org \
--cc=sakari.junnila@wapice.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.