From: Tomasz Figa <tomasz.figa@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Kukjin Kim <kgene@kernel.org>,
Jungseok Lee <jays.lee@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH V2] ARM: EXYNOS: implement pm_power_off for EXYNOS5440
Date: Mon, 30 Sep 2013 10:41:06 +0200 [thread overview]
Message-ID: <2759812.IaDDKuvX2H@flatron> (raw)
In-Reply-To: <CAK9yfHyQdswnNXVo_Wwz7y40URGOzecJ0juqFeSAMsDO1K3Nmw@mail.gmail.com>
On Monday 30 of September 2013 13:56:39 Sachin Kamat wrote:
> On 30 September 2013 12:55, Kukjin Kim <kgene@kernel.org> wrote:
> > I think current patch looks good to me, and in this case I don't have
> > any idea why we should macro for just one time usage.
>
> It is not the question of one time usage, it is just to make the code
> more readable.
I tend to agree with Sachin on this. Code as in current version of the
patch reads as "write 0x1 to register offset by 0x14 from clock controller
base", while it should read "write RESET_VAL to RESET_CTRL register of
clock controller" (names made up) for people doing further work on this
file to quickly find what the code does or allow referring to SoC
documentation.
Best regards,
Tomasz
prev parent reply other threads:[~2013-09-30 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 1:32 [PATCH V2] ARM: EXYNOS: implement pm_power_off for EXYNOS5440 Jungseok Lee
2013-09-30 3:03 ` Sachin Kamat
2013-09-30 5:20 ` Jungseok Lee
2013-09-30 7:25 ` Kukjin Kim
2013-09-30 8:26 ` Sachin Kamat
2013-09-30 8:41 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2759812.IaDDKuvX2H@flatron \
--to=tomasz.figa@gmail.com \
--cc=jays.lee@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.