From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04C8B13AD22 for ; Wed, 17 Apr 2024 13:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713361945; cv=none; b=sjmPavy2Bpg6bw2sJ9XYecmD13NFPX/0uSdIw06DcOd643MJUVodtVerzPrnCRbigdeoyNV9veVF8KBhSQN2H0e4F1ehlZGvGQyMZnw80Hk5Em70vDzwHZz+cRJ2rM1iNU/58fbmqfkUGu5omrQs3Llz1lCo7W6jYYELX/nlX00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713361945; c=relaxed/simple; bh=VxunfktQMOjppOCQpES9K8zlG6woQD+gav0HVLUYdWw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=QzRr1mOSwGAseqNlI1327cDrVhPiNHph6UUyk5CkquYFuuKZiJxXYytVfFwbICmRqawEBJhH8qUHdt8ztY9Z5i43XNh1ZG8J9yOvPt+Zns8qnrMEzmRF4Uo0aHCe868/kJZBxv8QiNuZ3VD6B0GHnGLyLEPFWVTWyyNilY31EZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Mykj5nAq; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Mykj5nAq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713361942; bh=VxunfktQMOjppOCQpES9K8zlG6woQD+gav0HVLUYdWw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Mykj5nAq4uZmDGUy8aeGxuqe1I9F/q86kU0nNQ1xVNXcg8XVae31Bm2y0lTzMLRxz sCbBts3Q1SnTtyf+WFufvN7v6WNYpJwBUoN1k7kZTBFXzQr3V5p5NWX3Od/aVo/z13 dcyJZqtU2prWJkdPjLYZkRNp7EoJzGjc7SHTX5MKlH0rQh2+K9hh1JGB/+PJkfi8iK 58QYY/y1ZXU2KXl29NUD5sHJrhTDD3on7edMTS7rVk+37dU6erHEzcqvjviarUFc6h M0BkSzY5TVdDI0g1canrfGMTmTSWsLkVVnnRDYmVwIiYpaCBC2x2gaSqy9+8cL/6e8 jsIu2PVVQMrHQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 7EB49378001E; Wed, 17 Apr 2024 13:52:21 +0000 (UTC) Message-ID: <275e760d-e4e2-4a6b-88f7-9a8590b0773b@collabora.com> Date: Wed, 17 Apr 2024 15:52:20 +0200 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value To: Wojciech Macek , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev References: <20240417103819.990512-1-wmacek@chromium.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240417103819.990512-1-wmacek@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 17/04/24 12:38, Wojciech Macek ha scritto: > In case there is no DP device attached to the port the > transfer function should return IO error, similar to what > other drivers do. > In case EAGAIN is returned then any read from /dev/drm_dp_aux > device ends up in an infinite loop as the upper layers > constantly repeats the transfer request. > > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > Signed-off-by: Wojciech Macek Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8472C4345F for ; Wed, 17 Apr 2024 13:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VYBsRw0tfkMoTstavqNApYMxiQbIE542RkGGr7LgO6s=; b=Oc3ZXAyEsJpNpgDKdg4qp0n/oa dHz2GmAll8eQtLJI/9wCG4CefPQSp2McXIJ3k69B65S3XRWmecrn0W2x6ybltVQh8ttrmnqp2rM7l NZOs9zzTTxH8pighwbAk7wqz8+5XgdtIxHyc4GoDZO7ita2D6Ofr3WU7Nq90bYKTJsYZ88gQokCnh K6KeF/Z4apsiIKKxjHArEHg02UdT6oUSoky479t1211UhQ2LgJXs5+C8cN8FhpO5t8Mn4ehJ20Vmp LD/k34kyI1jQbIXPbFsTEugtYkO7RuSJTD/M4Z3n65nXqt1QldZhpP9Mja8HBGmZ+QCdB0/CA71CX nrcPywVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx5i7-0000000GEwG-3dV8; Wed, 17 Apr 2024 13:52:27 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx5i4-0000000GEvW-3Jbv; Wed, 17 Apr 2024 13:52:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713361942; bh=VxunfktQMOjppOCQpES9K8zlG6woQD+gav0HVLUYdWw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Mykj5nAq4uZmDGUy8aeGxuqe1I9F/q86kU0nNQ1xVNXcg8XVae31Bm2y0lTzMLRxz sCbBts3Q1SnTtyf+WFufvN7v6WNYpJwBUoN1k7kZTBFXzQr3V5p5NWX3Od/aVo/z13 dcyJZqtU2prWJkdPjLYZkRNp7EoJzGjc7SHTX5MKlH0rQh2+K9hh1JGB/+PJkfi8iK 58QYY/y1ZXU2KXl29NUD5sHJrhTDD3on7edMTS7rVk+37dU6erHEzcqvjviarUFc6h M0BkSzY5TVdDI0g1canrfGMTmTSWsLkVVnnRDYmVwIiYpaCBC2x2gaSqy9+8cL/6e8 jsIu2PVVQMrHQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 7EB49378001E; Wed, 17 Apr 2024 13:52:21 +0000 (UTC) Message-ID: <275e760d-e4e2-4a6b-88f7-9a8590b0773b@collabora.com> Date: Wed, 17 Apr 2024 15:52:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/mediatek/dp: fix mtk_dp_aux_transfer return value To: Wojciech Macek , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev References: <20240417103819.990512-1-wmacek@chromium.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240417103819.990512-1-wmacek@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_065225_051153_F9F44D73 X-CRM114-Status: UNSURE ( 6.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 17/04/24 12:38, Wojciech Macek ha scritto: > In case there is no DP device attached to the port the > transfer function should return IO error, similar to what > other drivers do. > In case EAGAIN is returned then any read from /dev/drm_dp_aux > device ends up in an infinite loop as the upper layers > constantly repeats the transfer request. > > Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") > Signed-off-by: Wojciech Macek Reviewed-by: AngeloGioacchino Del Regno _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel