From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 3/5] drm/i915: WaInsertNoopAfterBatchEndCommand
Date: Thu, 18 Oct 2012 12:24:50 +0100 [thread overview]
Message-ID: <275ffc$71tsso@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1350553794-5534-4-git-send-email-daniel.vetter@ffwll.ch>
On Thu, 18 Oct 2012 11:49:52 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Comment says that this applies to earlier gens, too. Since two more
> MI_NOOP's can't hurt that much, I've figured I'll apply this w/a down
> to gen2.
>
> v2: Correct the ringbuffer dword count for gen3, spotted by Chris
> Wilson.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I'm just not sold on this one, surely we would have spotted a need
before now? 12 extra cycles after every batch! :-p
Can you please fix up the cut'n'paste comments to not refer to
generations that never call the function?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-18 11:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 9:49 [PATCH 0/5] pile of ilk related workarounds Daniel Vetter
2012-10-18 9:49 ` [PATCH 1/5] drm/i915: implement WaIssueDummyWriteToWakupFromRC6 Daniel Vetter
2012-10-18 11:10 ` Chris Wilson
2012-10-18 12:14 ` [PATCH] drm/i915: implement WaIssueDummyWriteToWakeupFromRC6 Daniel Vetter
2012-10-18 12:16 ` Daniel Vetter
2012-10-18 11:17 ` [PATCH 1/5] drm/i915: implement WaIssueDummyWriteToWakupFromRC6 Chris Wilson
2012-10-18 11:21 ` Daniel Vetter
2012-10-18 11:25 ` Lespiau, Damien
2012-10-18 9:49 ` [PATCH 2/5] drm/i915: implement WaDisableRenderCachePipelinedFlush Daniel Vetter
2012-10-18 11:21 ` Chris Wilson
2012-10-29 21:33 ` Daniel Vetter
2012-10-18 9:49 ` [PATCH 3/5] drm/i915: WaInsertNoopAfterBatchEndCommand Daniel Vetter
2012-10-18 11:24 ` Chris Wilson [this message]
2012-10-18 12:19 ` [PATCH] " Daniel Vetter
2012-10-18 9:49 ` [PATCH 4/5] drm/i915: implement WaDisableSpriteDestColorKey Daniel Vetter
2012-10-18 11:32 ` Chris Wilson
2012-10-18 9:49 ` [PATCH 5/5] drm/i915: document a few more already implemented ilk w/as Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='275ffc$71tsso@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.