From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: be less verbose about inability to provide vendor backlight Date: Thu, 25 Oct 2012 09:51:06 +0100 Message-ID: <275ffc$74tp0r@fmsmga002.fm.intel.com> References: <1351151859-24853-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F6D99E837 for ; Thu, 25 Oct 2012 01:51:42 -0700 (PDT) In-Reply-To: <1351151859-24853-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: jani.nikula@intel.com List-Id: intel-gfx@lists.freedesktop.org On Thu, 25 Oct 2012 10:57:38 +0300, Jani Nikula wrote: > commit 28dcc2d60cb570d9f549c329b2f51400553412a1 > Author: Jani Nikula > Date: Mon Sep 3 16:25:12 2012 +0300 > > drm/i915: do not expose a dysfunctional backlight interface to userspace > > prevents backlight interface creation if the BIOS has not set the backlight > PWM CTL registers that contain the max PWM value. It's apparently normal on > those machines, so demote the message about it to debug level. > > Reported-by: Orion Poplawski > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330 > Signed-off-by: Jani Nikula We may want to create an explicit bug/task to track the missing initialisation as a reminder as well. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre