From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/5] drm/i915: Allocate seqno conditionally in i915_add_request Date: Thu, 22 Nov 2012 11:13:04 +0000 Message-ID: <275ffc$7h3g4p@fmsmga002.fm.intel.com> References: <1353581490-5822-1-git-send-email-mika.kuoppala@intel.com> <1353581490-5822-5-git-send-email-mika.kuoppala@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id BA8D8E5EC0 for ; Thu, 22 Nov 2012 03:13:16 -0800 (PST) In-Reply-To: <1353581490-5822-5-git-send-email-mika.kuoppala@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org On Thu, 22 Nov 2012 12:51:29 +0200, Mika Kuoppala wrote: > If seqno already exists, add request with that seqno. Otherwise > allocate new seqno for this request. Make i915_gem_check_olr use > already allocated seqnos in order to avoid nesting into > i915_gem_alloc_seqno during i915_gem_idle(). I really don't like that mess in i915_add_request(). I was thinking more alongthe lines of: http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=bug55984&id=87cf35086182f9ce36bb8d85a0fe4cfc136cb3e2 -Chris -- Chris Wilson, Intel Open Source Technology Centre