From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Fix pte updates in ggtt clear range Date: Tue, 27 Nov 2012 16:42:30 +0000 Message-ID: <275ffc$7ja45m@fmsmga002.fm.intel.com> References: <1353995574-1021-1-git-send-email-ben@bwidawsk.net> <20121127083257.00003a39@unknown> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 04E35E62B6 for ; Tue, 27 Nov 2012 08:42:36 -0800 (PST) In-Reply-To: <20121127083257.00003a39@unknown> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 27 Nov 2012 08:32:57 -0800, Ben Widawsky wrote: > On Tue, 27 Nov 2012 08:22:01 +0000 > Chris Wilson wrote: > > > On Mon, 26 Nov 2012 21:52:54 -0800, Ben Widawsky > > wrote: > > > This bug was introduced by me: > > > commit e76e9aebcdbfebae8f4cd147e3c0f800d36e97f3 > > > Author: Ben Widawsky > > > Date: Sun Nov 4 09:21:27 2012 -0800 > > > > > > drm/i915: Stop using AGP layer for GEN6+ > > > > > > The existing code uses memset_io which follows memset semantics in > > > only guaranteeing a write of individual bytes. Since a PTE entry is > > > 4 bytes, this can only be correct if the scratch page address is 0. > > > > Gah. Wasn't there an iowrite32_rep? > > And you would hope it does what you want... but it seems like just a > memcpy of dword sized chunks. I feel suitably embarassed at missing it the first time, especially as we've had similar conversations in the past. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre