From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 10/16] drm/i915: Handle stolen objects for pread Date: Fri, 30 Nov 2012 23:46:13 +0000 Message-ID: <275ffc$7lerml@fmsmga002.fm.intel.com> References: <1352979151-9934-1-git-send-email-chris@chris-wilson.co.uk> <1352979151-9934-11-git-send-email-chris@chris-wilson.co.uk> <20121130223342.GC4384@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E7B4E63C4 for ; Sat, 1 Dec 2012 04:15:54 -0800 (PST) In-Reply-To: <20121130223342.GC4384@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 30 Nov 2012 23:33:43 +0100, Daniel Vetter wrote: > On Thu, Nov 15, 2012 at 11:32:25AM +0000, Chris Wilson wrote: > > Signed-off-by: Chris Wilson > > Tbh I don't see any reason for handling pwrite/pread support for stolen > mem backed objects. I'll leave these two patches here (plus the prep one > to differentiate between stolen and dma_bufs) for now until a user pops The problem is that constitutes a change in ABI, so I was trying to make sure stolen buffer objects were first class from day one. The only saving grace is that userspace can only access the stolen object for fbcon, but it is still available... -Chris -- Chris Wilson, Intel Open Source Technology Centre