From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2943BC433EF for ; Wed, 17 Nov 2021 15:16:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C31866187F for ; Wed, 17 Nov 2021 15:16:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C31866187F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YMsnsFkduSGoBRUCFibybPogEL+xDdTnATZAkmkiSn8=; b=3KrihwbmVU203p 8rz6OdrYC/qQTmYlG9JrP6HLlZLGrsnCNwZHfcF3r6AqCIwRBBohmfDQ7ZhEu/rhhZE2GIL7JZZCY mzgyeQHNwI9udxaGH65VwH4uOPrqrpFvbOUdkAUjwmtDVnhZ6+Ha9M8yZ5weJ3FJ1gmdRrt7Sy+nZ HUdbbiCHUZxIWOSnc0mKJUVKOb1ZYS/qMNLrBzsD6o9WX01kSRQxBtGvVt4rwSJdDmUg+03goMzDB hpsfsJspDZcRVmt8wCNE+Cjjhxm1IAsJlwvdPBfINozWaNT7wkdz1UsoIUG7UGCmkm1jHQI4Ckhr9 SxmvvpK+Ciup6Mi0C1oA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnMfx-005Ldm-Sw; Wed, 17 Nov 2021 15:16:41 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnMfj-005Lae-DR; Wed, 17 Nov 2021 15:16:28 +0000 Received: from ip5f5a6e92.dynamic.kabel-deutschland.de ([95.90.110.146] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnMfh-0004un-MX; Wed, 17 Nov 2021 16:16:25 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH 11/12] drm/rockchip: Make VOP driver optional Date: Wed, 17 Nov 2021 16:16:24 +0100 Message-ID: <2763206.1bNW4tK36S@diego> In-Reply-To: <20211117145054.GL6556@pengutronix.de> References: <20211117143347.314294-1-s.hauer@pengutronix.de> <15744316.EhFUcUTHNY@diego> <20211117145054.GL6556@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_071627_488096_3D923C12 X-CRM114-Status: GOOD ( 24.14 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Am Mittwoch, 17. November 2021, 15:50:54 CET schrieb Sascha Hauer: > On Wed, Nov 17, 2021 at 03:40:26PM +0100, Heiko St=FCbner wrote: > > Am Mittwoch, 17. November 2021, 15:33:46 CET schrieb Sascha Hauer: > > > With upcoming VOP2 support VOP won't be the only choice anymore, so m= ake > > > the VOP driver optional. > > > = > > > Signed-off-by: Sascha Hauer > > > --- > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > arch/arm64/configs/defconfig | 1 + > > > drivers/gpu/drm/rockchip/Kconfig | 7 +++++++ > > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > > 5 files changed, 12 insertions(+), 2 deletions(-) > > > = > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/m= ulti_v7_defconfig > > > index c951aeed2138c..fc123e8f3e2f9 100644 > > > --- a/arch/arm/configs/multi_v7_defconfig > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > @@ -667,6 +667,7 @@ CONFIG_DRM_EXYNOS_DPI=3Dy > > > CONFIG_DRM_EXYNOS_DSI=3Dy > > > CONFIG_DRM_EXYNOS_HDMI=3Dy > > > CONFIG_DRM_ROCKCHIP=3Dm > > > +CONFIG_ROCKCHIP_VOP=3Dy > > > CONFIG_ROCKCHIP_ANALOGIX_DP=3Dy > > > CONFIG_ROCKCHIP_DW_HDMI=3Dy > > > CONFIG_ROCKCHIP_DW_MIPI_DSI=3Dy > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defcon= fig > > > index f2e2b9bdd7024..a623386473dc9 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -682,6 +682,7 @@ CONFIG_DRM_EXYNOS_DSI=3Dy > > > CONFIG_DRM_EXYNOS_HDMI=3Dy > > > CONFIG_DRM_EXYNOS_MIC=3Dy > > > CONFIG_DRM_ROCKCHIP=3Dm > > > +CONFIG_ROCKCHIP_VOP=3Dy > > > CONFIG_ROCKCHIP_ANALOGIX_DP=3Dy > > > CONFIG_ROCKCHIP_CDN_DP=3Dy > > > CONFIG_ROCKCHIP_DW_HDMI=3Dy > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockc= hip/Kconfig > > > index 9f1ecefc39332..a1c4158259099 100644 > > > --- a/drivers/gpu/drm/rockchip/Kconfig > > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > > @@ -21,8 +21,15 @@ config DRM_ROCKCHIP > > > = > > > if DRM_ROCKCHIP > > > = > > > +config ROCKCHIP_VOP > > > + bool "Rockchip VOP driver" > > = > > would this benefit from a default-y ? > > For builds reusing preexisting .configs. > = > I enabled CONFIG_ROCKCHIP_VOP for all configs in the tree that enable > CONFIG_DRM_ROCKCHIP, so defconfig users shouldn't see any surprises. > That won't help users of custom configs of course. > = > I don't know what's preferred in such cases, I can change to default-y > if you like. default-y would keep the behaviour identical for all existing configs I guess and right now vop(1) is still the most used variant and will stay that way for a while longer, so I guess my preference would be for going that route - also so that we don't drown in "my display stopped working" during 5.17 ;-) Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFBDC433EF for ; Wed, 17 Nov 2021 15:18:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE3FF61465 for ; Wed, 17 Nov 2021 15:18:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE3FF61465 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5vdcE8l4RN5TBuN0+WISx1lwNNY0tCrrYLnSvU4ovNI=; b=H5Q1h6f/e1K9Zq jrHWqmT4uMB6JNgS87jA9EOWFj8ZvxGet5+EZMLRD3Js2PZl1OkYtS/NW64rxpt9E6EUQTGKp+0hg cykDnqSYbqfcCgmCN/VEbUxNgxY9s+Ceia6Mlqcc7fsyiRvhmbJSQHJjEwjS8sTrtiPabno45/uoa tzipKAzkELeSAvRffuSzgg/syyVTFdEF3cNvXaRZZoJiFEYlByOnRtULYhxUud5Y9Fqv6B37gbk0u oWfWPQpDWZzCmBvtJpnFg7QvqSz5mUyRoZshLatnXZFWNp3QpAl2Q6EQGG/EMvbEQ0EO+q6MZZgGM 689ztymCfZrkAFN28FNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnMfn-005Lbd-Up; Wed, 17 Nov 2021 15:16:32 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnMfj-005Lae-DR; Wed, 17 Nov 2021 15:16:28 +0000 Received: from ip5f5a6e92.dynamic.kabel-deutschland.de ([95.90.110.146] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnMfh-0004un-MX; Wed, 17 Nov 2021 16:16:25 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH 11/12] drm/rockchip: Make VOP driver optional Date: Wed, 17 Nov 2021 16:16:24 +0100 Message-ID: <2763206.1bNW4tK36S@diego> In-Reply-To: <20211117145054.GL6556@pengutronix.de> References: <20211117143347.314294-1-s.hauer@pengutronix.de> <15744316.EhFUcUTHNY@diego> <20211117145054.GL6556@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_071627_488096_3D923C12 X-CRM114-Status: GOOD ( 24.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 17. November 2021, 15:50:54 CET schrieb Sascha Hauer: > On Wed, Nov 17, 2021 at 03:40:26PM +0100, Heiko St=FCbner wrote: > > Am Mittwoch, 17. November 2021, 15:33:46 CET schrieb Sascha Hauer: > > > With upcoming VOP2 support VOP won't be the only choice anymore, so m= ake > > > the VOP driver optional. > > > = > > > Signed-off-by: Sascha Hauer > > > --- > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > arch/arm64/configs/defconfig | 1 + > > > drivers/gpu/drm/rockchip/Kconfig | 7 +++++++ > > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > > 5 files changed, 12 insertions(+), 2 deletions(-) > > > = > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/m= ulti_v7_defconfig > > > index c951aeed2138c..fc123e8f3e2f9 100644 > > > --- a/arch/arm/configs/multi_v7_defconfig > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > @@ -667,6 +667,7 @@ CONFIG_DRM_EXYNOS_DPI=3Dy > > > CONFIG_DRM_EXYNOS_DSI=3Dy > > > CONFIG_DRM_EXYNOS_HDMI=3Dy > > > CONFIG_DRM_ROCKCHIP=3Dm > > > +CONFIG_ROCKCHIP_VOP=3Dy > > > CONFIG_ROCKCHIP_ANALOGIX_DP=3Dy > > > CONFIG_ROCKCHIP_DW_HDMI=3Dy > > > CONFIG_ROCKCHIP_DW_MIPI_DSI=3Dy > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defcon= fig > > > index f2e2b9bdd7024..a623386473dc9 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -682,6 +682,7 @@ CONFIG_DRM_EXYNOS_DSI=3Dy > > > CONFIG_DRM_EXYNOS_HDMI=3Dy > > > CONFIG_DRM_EXYNOS_MIC=3Dy > > > CONFIG_DRM_ROCKCHIP=3Dm > > > +CONFIG_ROCKCHIP_VOP=3Dy > > > CONFIG_ROCKCHIP_ANALOGIX_DP=3Dy > > > CONFIG_ROCKCHIP_CDN_DP=3Dy > > > CONFIG_ROCKCHIP_DW_HDMI=3Dy > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockc= hip/Kconfig > > > index 9f1ecefc39332..a1c4158259099 100644 > > > --- a/drivers/gpu/drm/rockchip/Kconfig > > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > > @@ -21,8 +21,15 @@ config DRM_ROCKCHIP > > > = > > > if DRM_ROCKCHIP > > > = > > > +config ROCKCHIP_VOP > > > + bool "Rockchip VOP driver" > > = > > would this benefit from a default-y ? > > For builds reusing preexisting .configs. > = > I enabled CONFIG_ROCKCHIP_VOP for all configs in the tree that enable > CONFIG_DRM_ROCKCHIP, so defconfig users shouldn't see any surprises. > That won't help users of custom configs of course. > = > I don't know what's preferred in such cases, I can change to default-y > if you like. default-y would keep the behaviour identical for all existing configs I guess and right now vop(1) is still the most used variant and will stay that way for a while longer, so I guess my preference would be for going that route - also so that we don't drown in "my display stopped working" during 5.17 ;-) Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC635C433F5 for ; Wed, 17 Nov 2021 15:16:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B04FA61BE2 for ; Wed, 17 Nov 2021 15:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232713AbhKQPT1 convert rfc822-to-8bit (ORCPT ); Wed, 17 Nov 2021 10:19:27 -0500 Received: from gloria.sntech.de ([185.11.138.130]:60726 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233092AbhKQPT1 (ORCPT ); Wed, 17 Nov 2021 10:19:27 -0500 Received: from ip5f5a6e92.dynamic.kabel-deutschland.de ([95.90.110.146] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnMfh-0004un-MX; Wed, 17 Nov 2021 16:16:25 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH 11/12] drm/rockchip: Make VOP driver optional Date: Wed, 17 Nov 2021 16:16:24 +0100 Message-ID: <2763206.1bNW4tK36S@diego> In-Reply-To: <20211117145054.GL6556@pengutronix.de> References: <20211117143347.314294-1-s.hauer@pengutronix.de> <15744316.EhFUcUTHNY@diego> <20211117145054.GL6556@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Mittwoch, 17. November 2021, 15:50:54 CET schrieb Sascha Hauer: > On Wed, Nov 17, 2021 at 03:40:26PM +0100, Heiko Stübner wrote: > > Am Mittwoch, 17. November 2021, 15:33:46 CET schrieb Sascha Hauer: > > > With upcoming VOP2 support VOP won't be the only choice anymore, so make > > > the VOP driver optional. > > > > > > Signed-off-by: Sascha Hauer > > > --- > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > arch/arm64/configs/defconfig | 1 + > > > drivers/gpu/drm/rockchip/Kconfig | 7 +++++++ > > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > > 5 files changed, 12 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > > > index c951aeed2138c..fc123e8f3e2f9 100644 > > > --- a/arch/arm/configs/multi_v7_defconfig > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > @@ -667,6 +667,7 @@ CONFIG_DRM_EXYNOS_DPI=y > > > CONFIG_DRM_EXYNOS_DSI=y > > > CONFIG_DRM_EXYNOS_HDMI=y > > > CONFIG_DRM_ROCKCHIP=m > > > +CONFIG_ROCKCHIP_VOP=y > > > CONFIG_ROCKCHIP_ANALOGIX_DP=y > > > CONFIG_ROCKCHIP_DW_HDMI=y > > > CONFIG_ROCKCHIP_DW_MIPI_DSI=y > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index f2e2b9bdd7024..a623386473dc9 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -682,6 +682,7 @@ CONFIG_DRM_EXYNOS_DSI=y > > > CONFIG_DRM_EXYNOS_HDMI=y > > > CONFIG_DRM_EXYNOS_MIC=y > > > CONFIG_DRM_ROCKCHIP=m > > > +CONFIG_ROCKCHIP_VOP=y > > > CONFIG_ROCKCHIP_ANALOGIX_DP=y > > > CONFIG_ROCKCHIP_CDN_DP=y > > > CONFIG_ROCKCHIP_DW_HDMI=y > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > > > index 9f1ecefc39332..a1c4158259099 100644 > > > --- a/drivers/gpu/drm/rockchip/Kconfig > > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > > @@ -21,8 +21,15 @@ config DRM_ROCKCHIP > > > > > > if DRM_ROCKCHIP > > > > > > +config ROCKCHIP_VOP > > > + bool "Rockchip VOP driver" > > > > would this benefit from a default-y ? > > For builds reusing preexisting .configs. > > I enabled CONFIG_ROCKCHIP_VOP for all configs in the tree that enable > CONFIG_DRM_ROCKCHIP, so defconfig users shouldn't see any surprises. > That won't help users of custom configs of course. > > I don't know what's preferred in such cases, I can change to default-y > if you like. default-y would keep the behaviour identical for all existing configs I guess and right now vop(1) is still the most used variant and will stay that way for a while longer, so I guess my preference would be for going that route - also so that we don't drown in "my display stopped working" during 5.17 ;-) Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70A47C433EF for ; Wed, 17 Nov 2021 15:16:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B091861BFA for ; Wed, 17 Nov 2021 15:16:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B091861BFA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04DE76E8E1; Wed, 17 Nov 2021 15:16:29 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB7D86E8E1 for ; Wed, 17 Nov 2021 15:16:27 +0000 (UTC) Received: from ip5f5a6e92.dynamic.kabel-deutschland.de ([95.90.110.146] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnMfh-0004un-MX; Wed, 17 Nov 2021 16:16:25 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Sascha Hauer Subject: Re: [PATCH 11/12] drm/rockchip: Make VOP driver optional Date: Wed, 17 Nov 2021 16:16:24 +0100 Message-ID: <2763206.1bNW4tK36S@diego> In-Reply-To: <20211117145054.GL6556@pengutronix.de> References: <20211117143347.314294-1-s.hauer@pengutronix.de> <15744316.EhFUcUTHNY@diego> <20211117145054.GL6556@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Mittwoch, 17. November 2021, 15:50:54 CET schrieb Sascha Hauer: > On Wed, Nov 17, 2021 at 03:40:26PM +0100, Heiko St=FCbner wrote: > > Am Mittwoch, 17. November 2021, 15:33:46 CET schrieb Sascha Hauer: > > > With upcoming VOP2 support VOP won't be the only choice anymore, so m= ake > > > the VOP driver optional. > > >=20 > > > Signed-off-by: Sascha Hauer > > > --- > > > arch/arm/configs/multi_v7_defconfig | 1 + > > > arch/arm64/configs/defconfig | 1 + > > > drivers/gpu/drm/rockchip/Kconfig | 7 +++++++ > > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > > 5 files changed, 12 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/m= ulti_v7_defconfig > > > index c951aeed2138c..fc123e8f3e2f9 100644 > > > --- a/arch/arm/configs/multi_v7_defconfig > > > +++ b/arch/arm/configs/multi_v7_defconfig > > > @@ -667,6 +667,7 @@ CONFIG_DRM_EXYNOS_DPI=3Dy > > > CONFIG_DRM_EXYNOS_DSI=3Dy > > > CONFIG_DRM_EXYNOS_HDMI=3Dy > > > CONFIG_DRM_ROCKCHIP=3Dm > > > +CONFIG_ROCKCHIP_VOP=3Dy > > > CONFIG_ROCKCHIP_ANALOGIX_DP=3Dy > > > CONFIG_ROCKCHIP_DW_HDMI=3Dy > > > CONFIG_ROCKCHIP_DW_MIPI_DSI=3Dy > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defcon= fig > > > index f2e2b9bdd7024..a623386473dc9 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -682,6 +682,7 @@ CONFIG_DRM_EXYNOS_DSI=3Dy > > > CONFIG_DRM_EXYNOS_HDMI=3Dy > > > CONFIG_DRM_EXYNOS_MIC=3Dy > > > CONFIG_DRM_ROCKCHIP=3Dm > > > +CONFIG_ROCKCHIP_VOP=3Dy > > > CONFIG_ROCKCHIP_ANALOGIX_DP=3Dy > > > CONFIG_ROCKCHIP_CDN_DP=3Dy > > > CONFIG_ROCKCHIP_DW_HDMI=3Dy > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockc= hip/Kconfig > > > index 9f1ecefc39332..a1c4158259099 100644 > > > --- a/drivers/gpu/drm/rockchip/Kconfig > > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > > @@ -21,8 +21,15 @@ config DRM_ROCKCHIP > > > =20 > > > if DRM_ROCKCHIP > > > =20 > > > +config ROCKCHIP_VOP > > > + bool "Rockchip VOP driver" > >=20 > > would this benefit from a default-y ? > > For builds reusing preexisting .configs. >=20 > I enabled CONFIG_ROCKCHIP_VOP for all configs in the tree that enable > CONFIG_DRM_ROCKCHIP, so defconfig users shouldn't see any surprises. > That won't help users of custom configs of course. >=20 > I don't know what's preferred in such cases, I can change to default-y > if you like. default-y would keep the behaviour identical for all existing configs I guess and right now vop(1) is still the most used variant and will stay that way for a while longer, so I guess my preference would be for going that route - also so that we don't drown in "my display stopped working" during 5.17 ;-) Heiko