All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Nicolas Chautru <nicolas.chautru@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc: fix PDF build of bbdev prog guide
Date: Thu, 18 Jul 2019 15:53:56 +0200	[thread overview]
Message-ID: <2765522.ij6KrxUR9P@xps> (raw)
In-Reply-To: <1563431079-14170-1-git-send-email-nicolas.chautru@intel.com>

18/07/2019 08:24, Nicolas Chautru:
> -Figure 13.1 above showing the Turbo encoding of CBs using BBDEV
> +Figure :numref:`figure_turbo_tb_encode` above showing the Turbo encoding of CBs using BBDEV
>  interface in TB-mode is also valid for LDPC encode.
[...]
> -Figure 13.2 above showing the Turbo decoding of CBs using BBDEV
> +Figure :numref:`figure_turbo_tb_decode` above showing the Turbo decoding of CBs using BBDEV
>  interface in TB-mode is also valid for LDPC decode.

3 comments above the change of references:

- there are a lot more, please search for the word "section"

- it deserves a separate commit

- the line length should be below 100 chars, better below 80.
The ideal is to break lines logically after a punctuation sign,
or between "subject" and "verb", etc.
Example:
	Figure :numref:`figure_turbo_tb_encode` above
	showing the Turbo encoding of CBs using BBDEV interface in TB-mode
	is also valid for LDPC encode.



  reply	other threads:[~2019-07-18 13:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18  6:24 [dpdk-dev] [PATCH] doc: fix PDF build of bbdev prog guide Nicolas Chautru
2019-07-18 13:53 ` Thomas Monjalon [this message]
2019-07-18 14:43   ` Chautru, Nicolas
2019-07-18 15:01     ` Thomas Monjalon
2019-07-18 15:09       ` Chautru, Nicolas
2019-07-18 13:57 ` Thomas Monjalon
2019-07-18 14:51   ` Chautru, Nicolas
2019-07-18 15:05     ` Thomas Monjalon
2019-07-18 21:49 ` Thomas Monjalon
2019-07-18 22:01 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2019-07-18 22:04   ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2019-07-17 22:01 [dpdk-dev] [PATCH] " Thomas Monjalon
2019-07-18 13:33 ` Chautru, Nicolas
2019-07-18 13:47   ` Thomas Monjalon
2019-07-18 14:59     ` Chautru, Nicolas
2019-07-18 15:09       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2765522.ij6KrxUR9P@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=nicolas.chautru@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.