From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: arm64: dts: rockchip: Disable HS400 for mmc on rk3399-roc-pc Date: Thu, 14 Nov 2019 14:10:39 +0100 Message-ID: <2766673.iMURPl8gB5@phil> References: <20190301153348.29870-1-christoph.muellner@theobroma-systems.com> <20190301153348.29870-2-christoph.muellner@theobroma-systems.com> <367bf78a-f079-f0b4-68fe-52c86823c174@fivetechno.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <367bf78a-f079-f0b4-68fe-52c86823c174@fivetechno.de> Sender: linux-kernel-owner@vger.kernel.org To: Markus Reichl Cc: Christoph Muellner , robh+dt@kernel.org, mark.rutland@arm.com, shawn.lin@rock-chips.com, devicetree@vger.kernel.org, Jeffy Chen , linux-kernel@vger.kernel.org, Viresh Kumar , Brian Norris , Douglas Anderson , Vicente Bergas , Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, Tony Xie , Klaus Goger , Enric Balletbo i Serra , Randy Li , Philipp Tomsich , Ezequiel Garcia , linux-arm-kernel@lists.infradead.or List-Id: linux-mmc@vger.kernel.org Hi Markus, $subject is missing the [PATCH] prefix Am Montag, 11. November 2019, 10:51:04 CET schrieb Markus Reichl: > Working with rootfs on two 128GB mmcs on rk3399-roc-pc. > > One (mmc name 128G72, one screw hole) works fine in HS400 mode. > Other (mmc name DJNB4R, firefly on pcb, two screw holes) gets lots of > mmc1: "running CQE recovery", even hangs with damaged fs, > when running under heavy load, e.g. compiling kernel. > Both run fine with HS200. > > Disabling CQ with patch mmc: core: Add MMC Command Queue Support kernel parameter [0] did not help. > [0] https://gitlab.com/ayufan-repos/rock64/linux-mainline-kernel/commit/54e264154b87dfe32a8359b2726e2d5611adbaf3 I'm hoping for some input from other people in Cc but your mail headers also referenced the drive-impendance series from Christoph [0], which it seems we need to poke the phy maintainer again. Did you check if changing the impedance helped (like the signal dampening Philipp described in one of the replies there). [0] https://patchwork.kernel.org/patch/10835567/ most current v2 it seems is https://patchwork.kernel.org/patch/10842421/ > Therefore I propose to disable HS400 mode on roc-pc for now. Hoping for more input :-) Heiko > Signed-off-by: Markus Reichl > --- > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > index 29a50a083c42..33df95e384b4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > @@ -660,8 +660,6 @@ > > &sdhci { > bus-width = <8>; > - mmc-hs400-1_8v; > - mmc-hs400-enhanced-strobe; > non-removable; > status = "okay"; > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB931C432C3 for ; Thu, 14 Nov 2019 13:11:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A39F82071F for ; Thu, 14 Nov 2019 13:11:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XwzS92Jx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A39F82071F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=quSnSiYne+L+eD5qN8Vxk7qltqgZju01g3ECTO0bOgg=; b=XwzS92JxbtsatB 2pmUatdYfnonW1vYzi0yQs8klCZjuOMbziekX/AdMdP0ffsKbpg3V2O2jnPID3LDqhxBqY4flDBQI wZ9eDqMPghE3e8I3Iiby2oqDRzlnmoYpiUPp9LTu2T9gKakfmp8D25Z7Qc+GXECZj7PF5rIR2V8Sn tsSdktjQizPJ2D4g+mU/gzThqEgxQP6RNE2bvwTyZ+FqfgT7HYaKCGTmX2kgDUwYvac8hp3W0i8fk W2JWrOJ5MvNFkrPcI4EgyqnKASThbNuCuTsm1WIVqq2ttmXPe51QsuCJKp5BqO+3KY7Q0v7Zu9vls YNN9df+vn2iU9LBtRolA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVEtv-000243-Kg; Thu, 14 Nov 2019 13:11:07 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVEtq-00022f-U1; Thu, 14 Nov 2019 13:11:04 +0000 Received: from wf0530.dip.tu-dresden.de ([141.76.182.18] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVEtU-0002Qj-R0; Thu, 14 Nov 2019 14:10:40 +0100 From: Heiko Stuebner To: Markus Reichl Subject: Re: arm64: dts: rockchip: Disable HS400 for mmc on rk3399-roc-pc Date: Thu, 14 Nov 2019 14:10:39 +0100 Message-ID: <2766673.iMURPl8gB5@phil> In-Reply-To: <367bf78a-f079-f0b4-68fe-52c86823c174@fivetechno.de> References: <20190301153348.29870-1-christoph.muellner@theobroma-systems.com> <20190301153348.29870-2-christoph.muellner@theobroma-systems.com> <367bf78a-f079-f0b4-68fe-52c86823c174@fivetechno.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_051103_118578_217210A6 X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Brian Norris , Tony Xie , Viresh Kumar , shawn.lin@rock-chips.com, Jeffy Chen , "linux-mmc@vger.kernel.org" , linux-kernel@vger.kernel.org, Vicente Bergas , Douglas Anderson , linux-rockchip@lists.infradead.org, robh+dt@kernel.org, Klaus Goger , Enric Balletbo i Serra , Philipp Tomsich , Randy Li , Kishon Vijay Abraham I , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Christoph Muellner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Markus, $subject is missing the [PATCH] prefix Am Montag, 11. November 2019, 10:51:04 CET schrieb Markus Reichl: > Working with rootfs on two 128GB mmcs on rk3399-roc-pc. > > One (mmc name 128G72, one screw hole) works fine in HS400 mode. > Other (mmc name DJNB4R, firefly on pcb, two screw holes) gets lots of > mmc1: "running CQE recovery", even hangs with damaged fs, > when running under heavy load, e.g. compiling kernel. > Both run fine with HS200. > > Disabling CQ with patch mmc: core: Add MMC Command Queue Support kernel parameter [0] did not help. > [0] https://gitlab.com/ayufan-repos/rock64/linux-mainline-kernel/commit/54e264154b87dfe32a8359b2726e2d5611adbaf3 I'm hoping for some input from other people in Cc but your mail headers also referenced the drive-impendance series from Christoph [0], which it seems we need to poke the phy maintainer again. Did you check if changing the impedance helped (like the signal dampening Philipp described in one of the replies there). [0] https://patchwork.kernel.org/patch/10835567/ most current v2 it seems is https://patchwork.kernel.org/patch/10842421/ > Therefore I propose to disable HS400 mode on roc-pc for now. Hoping for more input :-) Heiko > Signed-off-by: Markus Reichl > --- > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > index 29a50a083c42..33df95e384b4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > @@ -660,8 +660,6 @@ > > &sdhci { > bus-width = <8>; > - mmc-hs400-1_8v; > - mmc-hs400-enhanced-strobe; > non-removable; > status = "okay"; > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55677C432C3 for ; Thu, 14 Nov 2019 13:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3673120709 for ; Thu, 14 Nov 2019 13:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbfKNNLE (ORCPT ); Thu, 14 Nov 2019 08:11:04 -0500 Received: from gloria.sntech.de ([185.11.138.130]:34068 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbfKNNLE (ORCPT ); Thu, 14 Nov 2019 08:11:04 -0500 Received: from wf0530.dip.tu-dresden.de ([141.76.182.18] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVEtU-0002Qj-R0; Thu, 14 Nov 2019 14:10:40 +0100 From: Heiko Stuebner To: Markus Reichl Cc: Christoph Muellner , robh+dt@kernel.org, mark.rutland@arm.com, shawn.lin@rock-chips.com, devicetree@vger.kernel.org, Jeffy Chen , linux-kernel@vger.kernel.org, Viresh Kumar , Brian Norris , Douglas Anderson , Vicente Bergas , Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, Tony Xie , Klaus Goger , Enric Balletbo i Serra , Randy Li , Philipp Tomsich , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, "linux-mmc@vger.kernel.org" Subject: Re: arm64: dts: rockchip: Disable HS400 for mmc on rk3399-roc-pc Date: Thu, 14 Nov 2019 14:10:39 +0100 Message-ID: <2766673.iMURPl8gB5@phil> In-Reply-To: <367bf78a-f079-f0b4-68fe-52c86823c174@fivetechno.de> References: <20190301153348.29870-1-christoph.muellner@theobroma-systems.com> <20190301153348.29870-2-christoph.muellner@theobroma-systems.com> <367bf78a-f079-f0b4-68fe-52c86823c174@fivetechno.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Markus, $subject is missing the [PATCH] prefix Am Montag, 11. November 2019, 10:51:04 CET schrieb Markus Reichl: > Working with rootfs on two 128GB mmcs on rk3399-roc-pc. > > One (mmc name 128G72, one screw hole) works fine in HS400 mode. > Other (mmc name DJNB4R, firefly on pcb, two screw holes) gets lots of > mmc1: "running CQE recovery", even hangs with damaged fs, > when running under heavy load, e.g. compiling kernel. > Both run fine with HS200. > > Disabling CQ with patch mmc: core: Add MMC Command Queue Support kernel parameter [0] did not help. > [0] https://gitlab.com/ayufan-repos/rock64/linux-mainline-kernel/commit/54e264154b87dfe32a8359b2726e2d5611adbaf3 I'm hoping for some input from other people in Cc but your mail headers also referenced the drive-impendance series from Christoph [0], which it seems we need to poke the phy maintainer again. Did you check if changing the impedance helped (like the signal dampening Philipp described in one of the replies there). [0] https://patchwork.kernel.org/patch/10835567/ most current v2 it seems is https://patchwork.kernel.org/patch/10842421/ > Therefore I propose to disable HS400 mode on roc-pc for now. Hoping for more input :-) Heiko > Signed-off-by: Markus Reichl > --- > arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > index 29a50a083c42..33df95e384b4 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi > @@ -660,8 +660,6 @@ > > &sdhci { > bus-width = <8>; > - mmc-hs400-1_8v; > - mmc-hs400-enhanced-strobe; > non-removable; > status = "okay"; > }; >