From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:41900 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728626AbeHFTSS (ORCPT ); Mon, 6 Aug 2018 15:18:18 -0400 From: Laurent Pinchart To: kieran.bingham+renesas@ideasonboard.com Cc: Jacopo Mondi , David Airlie , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" , open list , Laurent Pinchart Subject: Re: [PATCH 2/3] drm: rcar-du: Rename var to a more precise name Date: Mon, 06 Aug 2018 20:08:59 +0300 Message-ID: <2766858.dkh6WOvVc0@avalon> In-Reply-To: <8ddd8179-a0c7-1fbe-0390-ea8fd8c0ff7b@ideasonboard.com> References: <1532971214-17962-1-git-send-email-jacopo@jmondi.org> <1532971214-17962-3-git-send-email-jacopo@jmondi.org> <8ddd8179-a0c7-1fbe-0390-ea8fd8c0ff7b@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, On Monday, 6 August 2018 18:49:12 EEST Kieran Bingham wrote: > On 30/07/18 18:20, Jacopo Mondi wrote: > > Rename the 'value' variable, only used to for writing to DMSR register to > > a more precise 'dmsr' name. > > > > Signed-off-by: Laurent Pinchart > > > > Signed-off-by: Jacopo Mondi > > --- > > > > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 6d55cec..4d7907c 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > > @@ -208,7 +208,7 @@ static void rcar_du_crtc_set_display_timing(struct > > rcar_du_crtc *rcrtc)> > > const struct drm_display_mode *mode = &rcrtc->crtc.state- >adjusted_mode; > > struct rcar_du_device *rcdu = rcrtc->group->dev; > > unsigned long mode_clock = mode->clock * 1000; > > > > - u32 value; > > + u32 dsmr; > > > > u32 escr; > > > > if (rcdu->info->dpll_ch & (1 << rcrtc->index)) { > > > > @@ -299,11 +299,11 @@ static void rcar_du_crtc_set_display_timing(struct > > rcar_du_crtc *rcrtc)> > > rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? OTAR2 : OTAR, 0); > > > > /* Signal polarities */ > > > > - value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? DSMR_VSL : 0) > > - | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? DSMR_HSL : 0) > > - | ((mode->flags & DRM_MODE_FLAG_INTERLACE) ? DSMR_ODEV : 0) > > - | DSMR_DIPM_DISP | DSMR_CSPM; > > - rcar_du_crtc_write(rcrtc, DSMR, value); > > + dsmr = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? DSMR_VSL : 0) > > + | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? DSMR_HSL : 0) > > + | ((mode->flags & DRM_MODE_FLAG_INTERLACE) ? DSMR_ODEV : 0) > > + | DSMR_DIPM_DISP | DSMR_CSPM; > > Quite nit-picky I'm afraid, but here, you have increased the indent such > that the '|' operator is now aligned with the first '(', rather than the > '=' as used by the rest of the driver. > > Was this intentional ? > > I think it should be brought forwards to align under the '=' to match. Agreed. For the record, this change was part of patch 1/3 that I provided on its own to Jacopo, who then split it out. I'd be inclined to squash the two changes back together, I don't think this rename requires a patch of its own. > > + rcar_du_crtc_write(rcrtc, DSMR, dsmr); > > > > /* Display timings */ > > rcar_du_crtc_write(rcrtc, HDSR, mode->htotal - mode->hsync_start - 19); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/3] drm: rcar-du: Rename var to a more precise name Date: Mon, 06 Aug 2018 20:08:59 +0300 Message-ID: <2766858.dkh6WOvVc0@avalon> References: <1532971214-17962-1-git-send-email-jacopo@jmondi.org> <1532971214-17962-3-git-send-email-jacopo@jmondi.org> <8ddd8179-a0c7-1fbe-0390-ea8fd8c0ff7b@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2227F898F1 for ; Mon, 6 Aug 2018 17:08:18 +0000 (UTC) In-Reply-To: <8ddd8179-a0c7-1fbe-0390-ea8fd8c0ff7b@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: kieran.bingham+renesas@ideasonboard.com Cc: Jacopo Mondi , Laurent Pinchart , David Airlie , open list , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gTW9uZGF5LCA2IEF1Z3VzdCAyMDE4IDE4OjQ5OjEyIEVFU1QgS2llcmFu IEJpbmdoYW0gd3JvdGU6Cj4gT24gMzAvMDcvMTggMTg6MjAsIEphY29wbyBNb25kaSB3cm90ZToK PiA+IFJlbmFtZSB0aGUgJ3ZhbHVlJyB2YXJpYWJsZSwgb25seSB1c2VkIHRvIGZvciB3cml0aW5n IHRvIERNU1IgcmVnaXN0ZXIgdG8KPiA+IGEgbW9yZSBwcmVjaXNlICdkbXNyJyBuYW1lLgo+ID4g Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0Cj4gPiA8bGF1cmVudC5waW5jaGFy dCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBKYWNvcG8gTW9u ZGkgPGphY29wb0BqbW9uZGkub3JnPgo+ID4gLS0tCj4gPiAKPiA+ICBkcml2ZXJzL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X2NydGMuYyB8IDEyICsrKysrKy0tLS0tLQo+ID4gIDEgZmlsZSBjaGFu Z2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYwo+ID4gYi9kcml2ZXJzL2dw dS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYyBpbmRleCA2ZDU1Y2VjLi40ZDc5MDdjIDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5jCj4gPiBAQCAtMjA4LDcg KzIwOCw3IEBAIHN0YXRpYyB2b2lkIHJjYXJfZHVfY3J0Y19zZXRfZGlzcGxheV90aW1pbmcoc3Ry dWN0Cj4gPiByY2FyX2R1X2NydGMgKnJjcnRjKT4gCj4gPiAgCWNvbnN0IHN0cnVjdCBkcm1fZGlz cGxheV9tb2RlICptb2RlID0gJnJjcnRjLT5jcnRjLnN0YXRlLQo+YWRqdXN0ZWRfbW9kZTsKPiA+ ICAJc3RydWN0IHJjYXJfZHVfZGV2aWNlICpyY2R1ID0gcmNydGMtPmdyb3VwLT5kZXY7Cj4gPiAg CXVuc2lnbmVkIGxvbmcgbW9kZV9jbG9jayA9IG1vZGUtPmNsb2NrICogMTAwMDsKPiA+IAo+ID4g LQl1MzIgdmFsdWU7Cj4gPiArCXUzMiBkc21yOwo+ID4gCj4gPiAgCXUzMiBlc2NyOwo+ID4gIAkK PiA+ICAJaWYgKHJjZHUtPmluZm8tPmRwbGxfY2ggJiAoMSA8PCByY3J0Yy0+aW5kZXgpKSB7Cj4g PiAKPiA+IEBAIC0yOTksMTEgKzI5OSwxMSBAQCBzdGF0aWMgdm9pZCByY2FyX2R1X2NydGNfc2V0 X2Rpc3BsYXlfdGltaW5nKHN0cnVjdAo+ID4gcmNhcl9kdV9jcnRjICpyY3J0Yyk+IAo+ID4gIAly Y2FyX2R1X2dyb3VwX3dyaXRlKHJjcnRjLT5ncm91cCwgcmNydGMtPmluZGV4ICUgMiA/IE9UQVIy IDogT1RBUiwgMCk7Cj4gPiAgCQo+ID4gIAkvKiBTaWduYWwgcG9sYXJpdGllcyAqLwo+ID4gCj4g PiAtCXZhbHVlID0gKChtb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfUFZTWU5DKSA/IERTTVJf VlNMIDogMCkKPiA+IC0JICAgICAgfCAoKG1vZGUtPmZsYWdzICYgRFJNX01PREVfRkxBR19QSFNZ TkMpID8gRFNNUl9IU0wgOiAwKQo+ID4gLQkgICAgICB8ICgobW9kZS0+ZmxhZ3MgJiBEUk1fTU9E RV9GTEFHX0lOVEVSTEFDRSkgPyBEU01SX09ERVYgOiAwKQo+ID4gLQkgICAgICB8IERTTVJfRElQ TV9ESVNQIHwgRFNNUl9DU1BNOwo+ID4gLQlyY2FyX2R1X2NydGNfd3JpdGUocmNydGMsIERTTVIs IHZhbHVlKTsKPiA+ICsJZHNtciA9ICgobW9kZS0+ZmxhZ3MgJiBEUk1fTU9ERV9GTEFHX1BWU1lO QykgPyBEU01SX1ZTTCA6IDApCj4gPiArCSAgICAgICB8ICgobW9kZS0+ZmxhZ3MgJiBEUk1fTU9E RV9GTEFHX1BIU1lOQykgPyBEU01SX0hTTCA6IDApCj4gPiArCSAgICAgICB8ICgobW9kZS0+Zmxh Z3MgJiBEUk1fTU9ERV9GTEFHX0lOVEVSTEFDRSkgPyBEU01SX09ERVYgOiAwKQo+ID4gKwkgICAg ICAgfCBEU01SX0RJUE1fRElTUCB8IERTTVJfQ1NQTTsKPiAKPiBRdWl0ZSBuaXQtcGlja3kgSSdt IGFmcmFpZCwgYnV0IGhlcmUsIHlvdSBoYXZlIGluY3JlYXNlZCB0aGUgaW5kZW50IHN1Y2gKPiB0 aGF0IHRoZSAnfCcgb3BlcmF0b3IgaXMgbm93IGFsaWduZWQgd2l0aCB0aGUgZmlyc3QgJygnLCBy YXRoZXIgdGhhbiB0aGUKPiAnPScgYXMgdXNlZCBieSB0aGUgcmVzdCBvZiB0aGUgZHJpdmVyLgo+ IAo+IFdhcyB0aGlzIGludGVudGlvbmFsID8KPiAKPiBJIHRoaW5rIGl0IHNob3VsZCBiZSBicm91 Z2h0IGZvcndhcmRzIHRvIGFsaWduIHVuZGVyIHRoZSAnPScgdG8gbWF0Y2guCgpBZ3JlZWQuCgpG b3IgdGhlIHJlY29yZCwgdGhpcyBjaGFuZ2Ugd2FzIHBhcnQgb2YgcGF0Y2ggMS8zIHRoYXQgSSBw cm92aWRlZCBvbiBpdHMgb3duIAp0byBKYWNvcG8sIHdobyB0aGVuIHNwbGl0IGl0IG91dC4gSSdk IGJlIGluY2xpbmVkIHRvIHNxdWFzaCB0aGUgdHdvIGNoYW5nZXMgCmJhY2sgdG9nZXRoZXIsIEkg ZG9uJ3QgdGhpbmsgdGhpcyByZW5hbWUgcmVxdWlyZXMgYSBwYXRjaCBvZiBpdHMgb3duLgoKPiA+ ICsJcmNhcl9kdV9jcnRjX3dyaXRlKHJjcnRjLCBEU01SLCBkc21yKTsKPiA+IAo+ID4gIAkvKiBE aXNwbGF5IHRpbWluZ3MgKi8KPiA+ICAJcmNhcl9kdV9jcnRjX3dyaXRlKHJjcnRjLCBIRFNSLCBt b2RlLT5odG90YWwgLSBtb2RlLT5oc3luY19zdGFydCAtIDE5KTsKCi0tIApSZWdhcmRzLAoKTGF1 cmVudCBQaW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK