From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation Date: Mon, 01 May 2017 15:18:11 +0200 Message-ID: <2767337.ChMh6S42Js@xps> References: <20170424123358.5959-1-olivier.matz@6wind.com> <9BB6961774997848B5B42BEC655768F810D5A14D@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: stable@dpdk.org, "Wu, Jingjing" , dev@dpdk.org, "Richardson, Bruce" To: Olivier Matz Return-path: In-Reply-To: <9BB6961774997848B5B42BEC655768F810D5A14D@SHSMSX103.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/04/2017 10:51, Wu, Jingjing: > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > Since > > commit 999b2ee0fe45 ("app/testpmd: enable NUMA support by default"), > > testpmd is started with numa enabled by default. This highlights a floating point > > exception when started with --total-num-mbufs without any port (division by 0). > > This bug was already triggered before this commit if the --no-numa option was > > given. > > > > This commit adds a check of the nb_ports value before doing the division. By > > looking at this code, it appears that the creation of the mbuf pool is not > > consistent for the number of mbufs depending on the configuration. This is fixed > > in the next commit. > > > > Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device") > > > > CC: stable@dpdk.org > > Signed-off-by: Olivier Matz > > Acked-by: Jingjing Wu Series applied, thanks