From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Schiers <carsten@schiers.de>
Subject: AW: Problem compiling Kernel 2.6.18 - netfront.c
Date: Tue, 12 Oct 2010 12:34:36 +0200
Message-ID: <27710945.71286879676308.JavaMail.root@uhura>
References: <4CB44C8B020000780001C6EA@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4CB44C8B020000780001C6EA@vpn.id2.novell.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>, Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ky Srinivasan <KSrinivasan@novell.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Sorry, my machine is pretty slow and I wanted to do a fresh compile...

Yes, solves the issue. Just saw that the patch is already in the repo.

Thanks,
Carsten.


----- Originalnachricht -----
Von: Jan Beulich <JBeulich@novell.com>
Gesendet: Die, 12.10.2010 11:54
An: Ian Campbell <Ian.Campbell@citrix.com> ; Carsten Schiers <carsten@schiers.de>
Cc: xen-devel@lists.xensource.com ; Ky Srinivasan <KSrinivasan@novell.com>
Betreff: Re: [Xen-devel] Problem compiling Kernel 2.6.18 - netfront.c

>>> On 12.10.10 at 11:20, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> Looks like 2.6.18 sysfs differs from whichever kernel the patch was
> originally written against.

Yes, I'm sorry for that, I didn't notice that the corresponding code in
netback changed twice (in .21 and .30).

> Untested patch based on the netback get_drvinfo method from 2.6.18
> below, does it work for you?

Looks exactly like what's needed.

Acked-by: Jan Beulich <jbeulich@novell.com>

> diff -r 578f036ec7dd drivers/xen/netfront/netfront.c
> --- a/drivers/xen/netfront/netfront.c    Mon Oct 11 10:25:55 2010 +0100
> +++ b/drivers/xen/netfront/netfront.c    Tue Oct 12 10:19:15 2010 +0100
> @@ -1776,7 +1776,7 @@ static void netfront_get_drvinfo(struct 
>                   struct ethtool_drvinfo *info)
>  {
>      strcpy(info->driver, "netfront");
> -    strcpy(info->bus_info, dev_name(dev->dev.parent));
> +    strcpy(info->bus_info, dev->class_dev.dev->bus_id);
>  }
>  
>  static int network_connect(struct net_device *dev)
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com 
> http://lists.xensource.com/xen-devel