From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.xyz (Icenowy Zheng) Date: Sun, 21 Aug 2016 22:32:09 +0800 Subject: [PATCH v3 5/7] phy-sun4i-usb: Warn when external vbus is detected In-Reply-To: <1471781799-10457-5-git-send-email-hdegoede@redhat.com> References: <1471781799-10457-1-git-send-email-hdegoede@redhat.com> <1471781799-10457-5-git-send-email-hdegoede@redhat.com> Message-ID: <27711471789929@web21g.yandex.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 21.08.2016, 20:22, "Hans de Goede" : > Warn when external vbus is detected when we're trying to enable our > own vbus. Will it lead to a dmesg flood if a not-well-connected USB OTG Charging Hub is present? > > Signed-off-by: Hans de Goede > --- > Changes in v2: > -No changes > Changes in v3: > -No changes > --- > ?drivers/phy/phy-sun4i-usb.c | 4 +++- > ?1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c > index af42f8d..03f030b 100644 > --- a/drivers/phy/phy-sun4i-usb.c > +++ b/drivers/phy/phy-sun4i-usb.c > @@ -390,8 +390,10 @@ static int sun4i_usb_phy_power_on(struct phy *_phy) > > ?????????/* For phy0 only turn on Vbus if we don't have an ext. Vbus */ > ?????????if (phy->index == 0 && sun4i_usb_phy0_have_vbus_det(data) && > - data->vbus_det) > + data->vbus_det) { > + dev_warn(&_phy->dev, "External vbus detected, not enabling our own vbus\n"); > ?????????????????return 0; > + } > > ?????????ret = regulator_enable(phy->vbus); > ?????????if (ret) > -- > 2.7.4 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH v3 5/7] phy-sun4i-usb: Warn when external vbus is detected Date: Sun, 21 Aug 2016 22:32:09 +0800 Message-ID: <27711471789929@web21g.yandex.ru> References: <1471781799-10457-1-git-send-email-hdegoede@redhat.com> <1471781799-10457-5-git-send-email-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1471781799-10457-5-git-send-email-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hans de Goede , Bin Liu , Greg Kroah-Hartman , Kishon Vijay Abraham I Cc: devicetree , Chen-Yu Tsai , "linux-usb@vger.kernel.org" , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org CgoyMS4wOC4yMDE2LCAyMDoyMiwgIkhhbnMgZGUgR29lZGUiIDxoZGVnb2VkZUByZWRoYXQuY29t PjoKPiBXYXJuIHdoZW4gZXh0ZXJuYWwgdmJ1cyBpcyBkZXRlY3RlZCB3aGVuIHdlJ3JlIHRyeWlu ZyB0byBlbmFibGUgb3VyCj4gb3duIHZidXMuCgpXaWxsIGl0IGxlYWQgdG8gYSBkbWVzZyBmbG9v ZCBpZiBhIG5vdC13ZWxsLWNvbm5lY3RlZCBVU0IgT1RHIENoYXJnaW5nIEh1YgppcyBwcmVzZW50 PwoKPgo+IFNpZ25lZC1vZmYtYnk6IEhhbnMgZGUgR29lZGUgPGhkZWdvZWRlQHJlZGhhdC5jb20+ Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2MjoKPiAtTm8gY2hhbmdlcwo+IENoYW5nZXMgaW4gdjM6Cj4g LU5vIGNoYW5nZXMKPiAtLS0KPiDCoGRyaXZlcnMvcGh5L3BoeS1zdW40aS11c2IuYyB8IDQgKysr LQo+IMKgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3BoeS1zdW40aS11c2IuYyBiL2RyaXZlcnMvcGh5L3Bo eS1zdW40aS11c2IuYwo+IGluZGV4IGFmNDJmOGQuLjAzZjAzMGIgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9waHkvcGh5LXN1bjRpLXVzYi5jCj4gKysrIGIvZHJpdmVycy9waHkvcGh5LXN1bjRpLXVz Yi5jCj4gQEAgLTM5MCw4ICszOTAsMTAgQEAgc3RhdGljIGludCBzdW40aV91c2JfcGh5X3Bvd2Vy X29uKHN0cnVjdCBwaHkgKl9waHkpCj4KPiDCoMKgwqDCoMKgwqDCoMKgwqAvKiBGb3IgcGh5MCBv bmx5IHR1cm4gb24gVmJ1cyBpZiB3ZSBkb24ndCBoYXZlIGFuIGV4dC4gVmJ1cyAqLwo+IMKgwqDC oMKgwqDCoMKgwqDCoGlmIChwaHktPmluZGV4ID09IDAgJiYgc3VuNGlfdXNiX3BoeTBfaGF2ZV92 YnVzX2RldChkYXRhKSAmJgo+IC0gZGF0YS0+dmJ1c19kZXQpCj4gKyBkYXRhLT52YnVzX2RldCkg ewo+ICsgZGV2X3dhcm4oJl9waHktPmRldiwgIkV4dGVybmFsIHZidXMgZGV0ZWN0ZWQsIG5vdCBl bmFibGluZyBvdXIgb3duIHZidXNcbiIpOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqByZXR1cm4gMDsKPiArIH0KPgo+IMKgwqDCoMKgwqDCoMKgwqDCoHJldCA9IHJlZ3VsYXRv cl9lbmFibGUocGh5LT52YnVzKTsKPiDCoMKgwqDCoMKgwqDCoMKgwqBpZiAocmV0KQo+IC0tCj4g Mi43LjQKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKPiBsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKPiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK