From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 345F5CF6497 for ; Mon, 30 Sep 2024 07:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HUCt+xZTInxrw53BIJZWWp/iKOdM6S6+KhWtIYfTTFI=; b=YlK4o9Yp85mPbw T3m692SYPLEBO+Ia/1HBvpZWjqUEDAg6SXhdGczK4gZPcfTmV0DdacuzDU6nZG9t74tvBn4WILARt flYJX2kpe1501fKmNxkSwUH10ERXH6PYtgNXc6XFOVxLkKGuXfN++Cy4rXE73Gk53pAYvGtiCo/IL pDNcSUK5a7mKtENhMBsDo+SIq/pdpoVn5HkeWiEJOsgFRXLScenkjzUIUW/HPy107Wpjig5oB0PIQ EhVJtnDGMywVnUwEcxC4OvUJeWJ8NMaBLzq+hxJblP7Ab2xz8ELvSfGC7p0KbrycCeopV+HMyj9/Y uQ/Bxe6ZLoDpY4IgrNqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svBFO-0000000GF3y-17CQ; Mon, 30 Sep 2024 07:55:10 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svBFC-0000000GF0e-0PXN for linux-rockchip@lists.infradead.org; Mon, 30 Sep 2024 07:55:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TJrcEaW6HT4SoDeeGrgXvKVgSSQglptoRfRJ+5BZeQs=; b=L+4+21w+05Mh3Y+/dKq6oGqy6/ Cy7719Xxxx+vqaAGFhPMBr6edFt1veot/+tcyZqMOwZg+r5EGuamfUcFc65k/ZBx0BvVVNoxfGxPz tsDUDVm8ftp/2oldw4tplBhFJ9XcBBWK3ruM3UYerHxCeBhudfDq5AN/7IX2BgsKhOkLb6ae9n5bC IbWCW9sr0NT+5b7UmiK9EOfKrSBJaesWXzx/WKFNrSwtKMcW4gtdqMiZcEh3MAlf+3fcAxq+dQRW+ fiD6A8rf+H9J68jQ6HhB5XO1ShL/+F2Y11FseiAskDUGke0SxtU8wfgBY85wPqHVp7GIxZPZCbXZm /b8U3BrQ==; Received: from i5e861925.versanet.de ([94.134.25.37] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1svBF2-0003T3-Fe; Mon, 30 Sep 2024 09:54:48 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: FUKAUMI Naoki Cc: linux-rockchip@lists.infradead.org, FUKAUMI Naoki Subject: Re: [PATCH] arm64: dts: rockchip: fix pinctrl for pcie2x1l2 for Radxa ROCK 5A Date: Mon, 30 Sep 2024 09:54:47 +0200 Message-ID: <2772744.mvXUDI8C0e@diego> In-Reply-To: <20240930022837.885-1-naoki@radxa.com> References: <20240930022837.885-1-naoki@radxa.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240930_005458_190657_D7A62701 X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, Am Montag, 30. September 2024, 04:28:37 CEST schrieb FUKAUMI Naoki: > for pcie2x1l2, only pcie20x1_2_perstn_m0 is required. > fix pinctrl definitions for pcie2x1l2. I guess the other pins are used for something different? Not criticizing the change itself, but for a "fixes", I do expect some explanation, why the previous setting is _wrong_ . Thanks Heiko > Fixes: b728d4c51f0c ("arm64: dts: rockchip: enable PCIe on M.2 E key for Radxa ROCK 5A") > Signed-off-by: FUKAUMI Naoki > --- > arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > index 435355433bbd..1d7adece42a5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts > @@ -310,7 +310,7 @@ rgmii_phy1: ethernet-phy@1 { > }; > > &pcie2x1l2 { > - pinctrl-0 = <&pcie20x1m0_pins>; > + pinctrl-0 = <&pcie20x1_2_perstn_m0>; > pinctrl-names = "default"; > reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>; > vpcie3v3-supply = <&vcc3v3_wf>; > @@ -325,6 +325,10 @@ io_led: io-led { > }; > > pcie { > + pcie20x1_2_perstn_m0: pcie20x1-2-perstn-m0 { > + rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + > pow_en: pow-en { > rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>; > }; > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip