From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com ([192.55.52.88]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SgMf4-0002oJ-RV for openembedded-devel@lists.openembedded.org; Sun, 17 Jun 2012 23:05:32 +0200 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 17 Jun 2012 13:54:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="166728086" Received: from unknown (HELO helios.localnet) ([10.252.120.142]) by fmsmga001.fm.intel.com with ESMTP; 17 Jun 2012 13:54:47 -0700 From: Paul Eggleton To: Martin Jansa Date: Sun, 17 Jun 2012 21:54:46 +0100 Message-ID: <2772761.yp5Fv9bbrf@helios> Organization: Intel Corporation User-Agent: KMail/4.8.3 (Linux/3.2.0-25-generic-pae; KDE/4.8.3; i686; ; ) In-Reply-To: <20120616194018.GF3178@jama.jama.net> References: <1337788237-9475-1-git-send-email-Martin.Jansa@gmail.com> <20120616193756.GE3178@jama.jama.net> <20120616194018.GF3178@jama.jama.net> MIME-Version: 1.0 Cc: openembedded-devel@lists.openembedded.org Subject: Re: [meta-handheld][PATCH] meta-handheld: append to BBPATH instead of prepend so order of bblayers.conf is respected X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2012 21:05:32 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Saturday 16 June 2012 21:40:18 Martin Jansa wrote: > On Sat, Jun 16, 2012 at 09:37:56PM +0200, Martin Jansa wrote: > > On Sat, Jun 16, 2012 at 08:28:28PM +0100, Paul Eggleton wrote: > > > On Saturday 16 June 2012 09:01:17 Martin Jansa wrote: > > > > On Wed, May 23, 2012 at 05:50:37PM +0200, Martin Jansa wrote: > > > > > Signed-off-by: Martin Jansa > > > > > > > > ping > > > > > > > > > --- > > > > > > > > > > conf/layer.conf | 11 ++++++++--- > > > > > 1 files changed, 8 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/conf/layer.conf b/conf/layer.conf > > > > > index 7a2441b..31dcb16 100644 > > > > > --- a/conf/layer.conf > > > > > +++ b/conf/layer.conf > > > > > @@ -1,13 +1,18 @@ > > > > > > > > > > # Layer configuration for meta-handheld layer > > > > > # Copyright 2011 Intel Corporation > > > > > > > > > > -# We have a conf and classes directory, prepend to BBPATH to prefer > > > > > our > > > > > versions -BBPATH := "${LAYERDIR}:${BBPATH}" > > > > > +# We have a conf and classes directory, append to BBPATH > > > > > +BBPATH .= ":${LAYERDIR}" > > > > > > > > > > # We have a recipes directory, add to BBFILES > > > > > > > > > > -BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb > > > > > ${LAYERDIR}/recipes-*/*/*.bbappend" > > > > > +BBFILES += > > > > > "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"> > > > > > > > > > > BBFILE_COLLECTIONS += "meta-handheld" > > > > > BBFILE_PATTERN_meta-handheld := "^${LAYERDIR}/" > > > > > > I was all set to apply this now (sorry for the delay) and then I noticed > > > you changed the above without comment - why was that? > > > > Just to match what other layers do, or is there some advantage of using > > > > := instead of += in BBFILES? > > And IIRC there was some discussion about BBFILES :=/+= on ML before > ba31e4eabd31af63eb0244096c8bcdcac185fac6 changed it in other layers. Hmm, I couldn't find that discussion, but it doesn't seem to behave any differently; but looking at BitBake's layer.conf handling code we explicitly expand the LAYERDIR reference immediately anyway, so immediate expansion (:=) doesn't do anything. I guess this means the += form is perhaps preferred since it makes what we are trying to do more obvious. Now I've understood the above I've merged this patch, thanks. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre