From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3525AF41808 for ; Tue, 10 Mar 2026 09:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x+sKkqEen+FTZVcatdq7BWmJBRObIwAqW8MBSeFsbCg=; b=fHITspOJUhH+ymLN/ZUONQAGNn VMVeiiuDwiST9IN7d9reKLGhFFi/xGh80HgfHPERLtTvKLTkICNN6Z9c4HSEzrTTe9wS5oz+nN54t tlkK000uxma3azRCOlf7UNTTTdUSmVkpBJZXUVrNiB3Fdt6xwwLDvDM8DA7OEC9FH+ALcEpJTRJ/L WDkq2wHR9Vu7uI0GvQG2wcdTBF9YXiGwIrWZbHFp86zgBf5sLuTxPeslbtFNimAOeKGLegvwqjo13 xnKfT+VZ62e/e0LXj2oJYIiQCc99Qg6jgI65DGs3/5lu7U6lTLpEtu10dLjSC3ef6kvpgjEwORkZy oaF1Tlrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzt4h-000000092VJ-27uz; Tue, 10 Mar 2026 09:08:23 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzt4e-000000092T7-0tTH; Tue, 10 Mar 2026 09:08:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=x+sKkqEen+FTZVcatdq7BWmJBRObIwAqW8MBSeFsbCg=; b=2P8w16KW4mcJ4VoQcD9GwW+Aaw LPnWPTjV+iBSgpGU8VvlZBgivFQ41jbbUv9xPLTe0UGiC2O/TtxW9n87YjtaKXtEvok+d9X3m90n3 88MyVWdnk4KdCug4lCgmQ65VmF5YA3tIEvuVR5jNAJV+kyyiI3aJ/12D7cJW361aI64t62QfKt+G8 DpRgtf8aKTCqaf2K91HStN6cfzfIMJzfn16r4ZEdGteuKTcM5375CxPjFb+Zcjq9TyhP53oWNANrb QG5VUTphEsm3do+5av7k096Uzt/+LkiRWIWXHy5//oKgMhx3VYbZAmsubGNimoJORazjXzWfE9QP0 iOm5zq+A==; From: Heiko Stuebner To: Vladimir Oltean Cc: linux-phy@lists.infradead.org, Vinod Koul , Neil Armstrong , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com, Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH v3 phy-next 10/24] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Date: Tue, 10 Mar 2026 10:08:07 +0100 Message-ID: <2772778.X9hSmTKtgW@phil> In-Reply-To: <20260310083752.ms6u4qpy3snl4h6w@skbuf> References: <20260309190842.927634-1-vladimir.oltean@nxp.com> <2218670.OBFZWjSADL@phil> <20260310083752.ms6u4qpy3snl4h6w@skbuf> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260310_020820_252540_E1A53DBC X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 10. M=C3=A4rz 2026, 09:37:52 Mitteleurop=C3=A4ische Normalzeit= schrieb Vladimir Oltean: > On Tue, Mar 10, 2026 at 09:24:43AM +0100, Heiko Stuebner wrote: > > Am Montag, 9. M=C3=A4rz 2026, 20:08:28 Mitteleurop=C3=A4ische Normalzei= t schrieb Vladimir Oltean: > > > The dw_hdmi-rockchip driver validates pixel clock rates against the > > > HDMI PHY's internal clock provider on certain SoCs like RK3328. > > > This is currently achieved by dereferencing hdmi->phy->dev.of_node > > > to obtain the provider node, which violates the Generic PHY API's > > > encapsulation (the goal is for struct phy to be an opaque pointer). > > >=20 > > > Refactor dw_hdmi_rockchip_bind() to perform a manual phandle lookup > > > on the "hdmi" PHY index within the controller's DT node. This provides > > > a parallel path to the clock provider's OF node without relying on the > > > internal structure of the struct phy handle. > > >=20 > > > Signed-off-by: Vladimir Oltean > > > --- > > > Cc: Sandy Huang > > > Cc: "Heiko St=C3=BCbner" > > > Cc: Andy Yan > > > Cc: Maarten Lankhorst > > > Cc: Maxime Ripard > > > Cc: Thomas Zimmermann > > > Cc: David Airlie > > > Cc: Simona Vetter > > >=20 > > > v1->v3: none > > > --- > >=20 > > [...] > >=20 > > > @@ -588,13 +589,17 @@ static int dw_hdmi_rockchip_bind(struct device = *dev, struct device *master, > > > return dev_err_probe(hdmi->dev, ret, "failed to get phy\n"); > > > } > > > =20 > > > - if (hdmi->phy) { > >=20 > > nit: a comment would be nice here. I.e. hdmi->phy being an opaque point= er > > so checking hdmi->phy !=3D NULL is not possible. > >=20 > > With that being a "goal", I assume that information is not widely spread > > so this would prevent the next developer trying to change it back to > > "if (hdmi->phy)" while that handling change trickles down. >=20 > Testing the NULL quality of "struct phy *phy" is still possible and legal. > It means that you called an "optional" variant of phy_get(), and there > was no PHY. ok, I'll keep that in mind :-) Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 493BAEA8550 for ; Tue, 10 Mar 2026 09:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6rby9oEKUZ5oLU4NaQ5KYDteUzr83zMB5n0aTQxTvag=; b=SFMDQNLSoImAN6 bi+upJY7MNTWBVAyVhET0Q7IBb/lPNqNrrzohpZnLLoyq4uP+TuHEuhrQDRO2jCMyeGNFdJlWCwVS seMRv/anpZmn/GJkHNUCnb+ZwGp5iRWSHp+enaCdi8VxMd5QqDQw+PzYHOH8DIrjCTaHYUmtAJiZp RKjZsBeu8PtaG+z/+2KsbdYf1nJnnNOmIknwE7Mk4quQVcEqUSHTMZz7rJle+QWbjdYRvs7b5qBhz zumHU/2pbdiyZpN/iDW1TqW1rvv13qVeA8bvb+gzx7/2nraF0r3343PeVQZft3nLfA3srWQh85Xzi KTRm+25sSPueBYOLGs2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzt4g-000000092Uo-0607; Tue, 10 Mar 2026 09:08:22 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzt4e-000000092T7-0tTH; Tue, 10 Mar 2026 09:08:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=x+sKkqEen+FTZVcatdq7BWmJBRObIwAqW8MBSeFsbCg=; b=2P8w16KW4mcJ4VoQcD9GwW+Aaw LPnWPTjV+iBSgpGU8VvlZBgivFQ41jbbUv9xPLTe0UGiC2O/TtxW9n87YjtaKXtEvok+d9X3m90n3 88MyVWdnk4KdCug4lCgmQ65VmF5YA3tIEvuVR5jNAJV+kyyiI3aJ/12D7cJW361aI64t62QfKt+G8 DpRgtf8aKTCqaf2K91HStN6cfzfIMJzfn16r4ZEdGteuKTcM5375CxPjFb+Zcjq9TyhP53oWNANrb QG5VUTphEsm3do+5av7k096Uzt/+LkiRWIWXHy5//oKgMhx3VYbZAmsubGNimoJORazjXzWfE9QP0 iOm5zq+A==; From: Heiko Stuebner To: Vladimir Oltean Cc: linux-phy@lists.infradead.org, Vinod Koul , Neil Armstrong , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com, Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH v3 phy-next 10/24] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Date: Tue, 10 Mar 2026 10:08:07 +0100 Message-ID: <2772778.X9hSmTKtgW@phil> In-Reply-To: <20260310083752.ms6u4qpy3snl4h6w@skbuf> References: <20260309190842.927634-1-vladimir.oltean@nxp.com> <2218670.OBFZWjSADL@phil> <20260310083752.ms6u4qpy3snl4h6w@skbuf> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260310_020820_252540_E1A53DBC X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org QW0gRGllbnN0YWcsIDEwLiBNw6RyeiAyMDI2LCAwOTozNzo1MiBNaXR0ZWxldXJvcMOkaXNjaGUg Tm9ybWFsemVpdCBzY2hyaWViIFZsYWRpbWlyIE9sdGVhbjoKPiBPbiBUdWUsIE1hciAxMCwgMjAy NiBhdCAwOToyNDo0M0FNICswMTAwLCBIZWlrbyBTdHVlYm5lciB3cm90ZToKPiA+IEFtIE1vbnRh ZywgOS4gTcOkcnogMjAyNiwgMjA6MDg6MjggTWl0dGVsZXVyb3DDpGlzY2hlIE5vcm1hbHplaXQg c2NocmllYiBWbGFkaW1pciBPbHRlYW46Cj4gPiA+IFRoZSBkd19oZG1pLXJvY2tjaGlwIGRyaXZl ciB2YWxpZGF0ZXMgcGl4ZWwgY2xvY2sgcmF0ZXMgYWdhaW5zdCB0aGUKPiA+ID4gSERNSSBQSFkn cyBpbnRlcm5hbCBjbG9jayBwcm92aWRlciBvbiBjZXJ0YWluIFNvQ3MgbGlrZSBSSzMzMjguCj4g PiA+IFRoaXMgaXMgY3VycmVudGx5IGFjaGlldmVkIGJ5IGRlcmVmZXJlbmNpbmcgaGRtaS0+cGh5 LT5kZXYub2Zfbm9kZQo+ID4gPiB0byBvYnRhaW4gdGhlIHByb3ZpZGVyIG5vZGUsIHdoaWNoIHZp b2xhdGVzIHRoZSBHZW5lcmljIFBIWSBBUEkncwo+ID4gPiBlbmNhcHN1bGF0aW9uICh0aGUgZ29h bCBpcyBmb3Igc3RydWN0IHBoeSB0byBiZSBhbiBvcGFxdWUgcG9pbnRlcikuCj4gPiA+IAo+ID4g PiBSZWZhY3RvciBkd19oZG1pX3JvY2tjaGlwX2JpbmQoKSB0byBwZXJmb3JtIGEgbWFudWFsIHBo YW5kbGUgbG9va3VwCj4gPiA+IG9uIHRoZSAiaGRtaSIgUEhZIGluZGV4IHdpdGhpbiB0aGUgY29u dHJvbGxlcidzIERUIG5vZGUuIFRoaXMgcHJvdmlkZXMKPiA+ID4gYSBwYXJhbGxlbCBwYXRoIHRv IHRoZSBjbG9jayBwcm92aWRlcidzIE9GIG5vZGUgd2l0aG91dCByZWx5aW5nIG9uIHRoZQo+ID4g PiBpbnRlcm5hbCBzdHJ1Y3R1cmUgb2YgdGhlIHN0cnVjdCBwaHkgaGFuZGxlLgo+ID4gPiAKPiA+ ID4gU2lnbmVkLW9mZi1ieTogVmxhZGltaXIgT2x0ZWFuIDx2bGFkaW1pci5vbHRlYW5AbnhwLmNv bT4KPiA+ID4gLS0tCj4gPiA+IENjOiBTYW5keSBIdWFuZyA8aGpjQHJvY2stY2hpcHMuY29tPgo+ ID4gPiBDYzogIkhlaWtvIFN0w7xibmVyIiA8aGVpa29Ac250ZWNoLmRlPgo+ID4gPiBDYzogQW5k eSBZYW4gPGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgo+ID4gPiBDYzogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ID4gQ2M6IE1heGltZSBS aXBhcmQgPG1yaXBhcmRAa2VybmVsLm9yZz4KPiA+ID4gQ2M6IFRob21hcyBaaW1tZXJtYW5uIDx0 emltbWVybWFubkBzdXNlLmRlPgo+ID4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGdtYWls LmNvbT4KPiA+ID4gQ2M6IFNpbW9uYSBWZXR0ZXIgPHNpbW9uYUBmZndsbC5jaD4KPiA+ID4gCj4g PiA+IHYxLT52Mzogbm9uZQo+ID4gPiAtLS0KPiA+IAo+ID4gWy4uLl0KPiA+IAo+ID4gPiBAQCAt NTg4LDEzICs1ODksMTcgQEAgc3RhdGljIGludCBkd19oZG1pX3JvY2tjaGlwX2JpbmQoc3RydWN0 IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsCj4gPiA+ICAJCXJldHVybiBkZXZf ZXJyX3Byb2JlKGhkbWktPmRldiwgcmV0LCAiZmFpbGVkIHRvIGdldCBwaHlcbiIpOwo+ID4gPiAg CX0KPiA+ID4gIAo+ID4gPiAtCWlmIChoZG1pLT5waHkpIHsKPiA+IAo+ID4gbml0OiBhIGNvbW1l bnQgd291bGQgYmUgbmljZSBoZXJlLiBJLmUuIGhkbWktPnBoeSBiZWluZyBhbiBvcGFxdWUgcG9p bnRlcgo+ID4gc28gY2hlY2tpbmcgaGRtaS0+cGh5ICE9IE5VTEwgaXMgbm90IHBvc3NpYmxlLgo+ ID4gCj4gPiBXaXRoIHRoYXQgYmVpbmcgYSAiZ29hbCIsIEkgYXNzdW1lIHRoYXQgaW5mb3JtYXRp b24gaXMgbm90IHdpZGVseSBzcHJlYWQKPiA+IHNvIHRoaXMgd291bGQgcHJldmVudCB0aGUgbmV4 dCBkZXZlbG9wZXIgdHJ5aW5nIHRvIGNoYW5nZSBpdCBiYWNrIHRvCj4gPiAiaWYgKGhkbWktPnBo eSkiIHdoaWxlIHRoYXQgaGFuZGxpbmcgY2hhbmdlIHRyaWNrbGVzIGRvd24uCj4gCj4gVGVzdGlu ZyB0aGUgTlVMTCBxdWFsaXR5IG9mICJzdHJ1Y3QgcGh5ICpwaHkiIGlzIHN0aWxsIHBvc3NpYmxl IGFuZCBsZWdhbC4KPiBJdCBtZWFucyB0aGF0IHlvdSBjYWxsZWQgYW4gIm9wdGlvbmFsIiB2YXJp YW50IG9mIHBoeV9nZXQoKSwgYW5kIHRoZXJlCj4gd2FzIG5vIFBIWS4KCm9rLCBJJ2xsIGtlZXAg dGhhdCBpbiBtaW5kIDotKQoKCkhlaWtvCgoKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0Cmxp bnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 806B9EFCD9F for ; Tue, 10 Mar 2026 09:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=syPwVN2xMp1WwQMfsQeVIDV1I13ZRhyVXanFQHrTFkY=; b=lN9wHgOS89vcJf +hHEj/OQjW5+ZplEn54Jd8y0Sd71UeKrR/0i19NWCMnLEV2R8hVv/qVWbmRwTln/iCQSbWQA3QOlH 1w4ku6hU8KRXm2sEg0UOKKK5WIg8g3mYUsVaKApN/8sfnRjMf/HA59VqS2SOKhfhSieX6jsifcCVX Vi1f0nlMROHXFN4gFs4Kca6gt9M2/+SEJH089UB8Aj0lyVKAwHpI5d+BsfueVa5kzmlM08wLYTaht G6eFoMaArMljZRM7WqnsOtlO4eHi7DqLcQWzwlTaM0p0Dob5o6Cz6pg0Mjkzxkyj56Foq93brlv8D zPigmDakHvnPvtVGVXSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzt4j-000000092Wl-1mzk; Tue, 10 Mar 2026 09:08:25 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzt4e-000000092T7-0tTH; Tue, 10 Mar 2026 09:08:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=x+sKkqEen+FTZVcatdq7BWmJBRObIwAqW8MBSeFsbCg=; b=2P8w16KW4mcJ4VoQcD9GwW+Aaw LPnWPTjV+iBSgpGU8VvlZBgivFQ41jbbUv9xPLTe0UGiC2O/TtxW9n87YjtaKXtEvok+d9X3m90n3 88MyVWdnk4KdCug4lCgmQ65VmF5YA3tIEvuVR5jNAJV+kyyiI3aJ/12D7cJW361aI64t62QfKt+G8 DpRgtf8aKTCqaf2K91HStN6cfzfIMJzfn16r4ZEdGteuKTcM5375CxPjFb+Zcjq9TyhP53oWNANrb QG5VUTphEsm3do+5av7k096Uzt/+LkiRWIWXHy5//oKgMhx3VYbZAmsubGNimoJORazjXzWfE9QP0 iOm5zq+A==; From: Heiko Stuebner To: Vladimir Oltean Cc: linux-phy@lists.infradead.org, Vinod Koul , Neil Armstrong , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com, Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH v3 phy-next 10/24] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Date: Tue, 10 Mar 2026 10:08:07 +0100 Message-ID: <2772778.X9hSmTKtgW@phil> In-Reply-To: <20260310083752.ms6u4qpy3snl4h6w@skbuf> References: <20260309190842.927634-1-vladimir.oltean@nxp.com> <2218670.OBFZWjSADL@phil> <20260310083752.ms6u4qpy3snl4h6w@skbuf> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260310_020820_252540_E1A53DBC X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gRGllbnN0YWcsIDEwLiBNw6RyeiAyMDI2LCAwOTozNzo1MiBNaXR0ZWxldXJvcMOkaXNjaGUg Tm9ybWFsemVpdCBzY2hyaWViIFZsYWRpbWlyIE9sdGVhbjoKPiBPbiBUdWUsIE1hciAxMCwgMjAy NiBhdCAwOToyNDo0M0FNICswMTAwLCBIZWlrbyBTdHVlYm5lciB3cm90ZToKPiA+IEFtIE1vbnRh ZywgOS4gTcOkcnogMjAyNiwgMjA6MDg6MjggTWl0dGVsZXVyb3DDpGlzY2hlIE5vcm1hbHplaXQg c2NocmllYiBWbGFkaW1pciBPbHRlYW46Cj4gPiA+IFRoZSBkd19oZG1pLXJvY2tjaGlwIGRyaXZl ciB2YWxpZGF0ZXMgcGl4ZWwgY2xvY2sgcmF0ZXMgYWdhaW5zdCB0aGUKPiA+ID4gSERNSSBQSFkn cyBpbnRlcm5hbCBjbG9jayBwcm92aWRlciBvbiBjZXJ0YWluIFNvQ3MgbGlrZSBSSzMzMjguCj4g PiA+IFRoaXMgaXMgY3VycmVudGx5IGFjaGlldmVkIGJ5IGRlcmVmZXJlbmNpbmcgaGRtaS0+cGh5 LT5kZXYub2Zfbm9kZQo+ID4gPiB0byBvYnRhaW4gdGhlIHByb3ZpZGVyIG5vZGUsIHdoaWNoIHZp b2xhdGVzIHRoZSBHZW5lcmljIFBIWSBBUEkncwo+ID4gPiBlbmNhcHN1bGF0aW9uICh0aGUgZ29h bCBpcyBmb3Igc3RydWN0IHBoeSB0byBiZSBhbiBvcGFxdWUgcG9pbnRlcikuCj4gPiA+IAo+ID4g PiBSZWZhY3RvciBkd19oZG1pX3JvY2tjaGlwX2JpbmQoKSB0byBwZXJmb3JtIGEgbWFudWFsIHBo YW5kbGUgbG9va3VwCj4gPiA+IG9uIHRoZSAiaGRtaSIgUEhZIGluZGV4IHdpdGhpbiB0aGUgY29u dHJvbGxlcidzIERUIG5vZGUuIFRoaXMgcHJvdmlkZXMKPiA+ID4gYSBwYXJhbGxlbCBwYXRoIHRv IHRoZSBjbG9jayBwcm92aWRlcidzIE9GIG5vZGUgd2l0aG91dCByZWx5aW5nIG9uIHRoZQo+ID4g PiBpbnRlcm5hbCBzdHJ1Y3R1cmUgb2YgdGhlIHN0cnVjdCBwaHkgaGFuZGxlLgo+ID4gPiAKPiA+ ID4gU2lnbmVkLW9mZi1ieTogVmxhZGltaXIgT2x0ZWFuIDx2bGFkaW1pci5vbHRlYW5AbnhwLmNv bT4KPiA+ID4gLS0tCj4gPiA+IENjOiBTYW5keSBIdWFuZyA8aGpjQHJvY2stY2hpcHMuY29tPgo+ ID4gPiBDYzogIkhlaWtvIFN0w7xibmVyIiA8aGVpa29Ac250ZWNoLmRlPgo+ID4gPiBDYzogQW5k eSBZYW4gPGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgo+ID4gPiBDYzogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ID4gQ2M6IE1heGltZSBS aXBhcmQgPG1yaXBhcmRAa2VybmVsLm9yZz4KPiA+ID4gQ2M6IFRob21hcyBaaW1tZXJtYW5uIDx0 emltbWVybWFubkBzdXNlLmRlPgo+ID4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGdtYWls LmNvbT4KPiA+ID4gQ2M6IFNpbW9uYSBWZXR0ZXIgPHNpbW9uYUBmZndsbC5jaD4KPiA+ID4gCj4g PiA+IHYxLT52Mzogbm9uZQo+ID4gPiAtLS0KPiA+IAo+ID4gWy4uLl0KPiA+IAo+ID4gPiBAQCAt NTg4LDEzICs1ODksMTcgQEAgc3RhdGljIGludCBkd19oZG1pX3JvY2tjaGlwX2JpbmQoc3RydWN0 IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsCj4gPiA+ICAJCXJldHVybiBkZXZf ZXJyX3Byb2JlKGhkbWktPmRldiwgcmV0LCAiZmFpbGVkIHRvIGdldCBwaHlcbiIpOwo+ID4gPiAg CX0KPiA+ID4gIAo+ID4gPiAtCWlmIChoZG1pLT5waHkpIHsKPiA+IAo+ID4gbml0OiBhIGNvbW1l bnQgd291bGQgYmUgbmljZSBoZXJlLiBJLmUuIGhkbWktPnBoeSBiZWluZyBhbiBvcGFxdWUgcG9p bnRlcgo+ID4gc28gY2hlY2tpbmcgaGRtaS0+cGh5ICE9IE5VTEwgaXMgbm90IHBvc3NpYmxlLgo+ ID4gCj4gPiBXaXRoIHRoYXQgYmVpbmcgYSAiZ29hbCIsIEkgYXNzdW1lIHRoYXQgaW5mb3JtYXRp b24gaXMgbm90IHdpZGVseSBzcHJlYWQKPiA+IHNvIHRoaXMgd291bGQgcHJldmVudCB0aGUgbmV4 dCBkZXZlbG9wZXIgdHJ5aW5nIHRvIGNoYW5nZSBpdCBiYWNrIHRvCj4gPiAiaWYgKGhkbWktPnBo eSkiIHdoaWxlIHRoYXQgaGFuZGxpbmcgY2hhbmdlIHRyaWNrbGVzIGRvd24uCj4gCj4gVGVzdGlu ZyB0aGUgTlVMTCBxdWFsaXR5IG9mICJzdHJ1Y3QgcGh5ICpwaHkiIGlzIHN0aWxsIHBvc3NpYmxl IGFuZCBsZWdhbC4KPiBJdCBtZWFucyB0aGF0IHlvdSBjYWxsZWQgYW4gIm9wdGlvbmFsIiB2YXJp YW50IG9mIHBoeV9nZXQoKSwgYW5kIHRoZXJlCj4gd2FzIG5vIFBIWS4KCm9rLCBJJ2xsIGtlZXAg dGhhdCBpbiBtaW5kIDotKQoKCkhlaWtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2Nr Y2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC33FEFCD9F for ; Tue, 10 Mar 2026 09:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=86NDnFsi3bKkPbQRW49S7xPNuOXHsa+WacN3oYrmFGM=; b=1eIeyz/X5diBOf KrOwXRh9aFVwwq0PYG8CXc7IJZgjv6jF75U6ZNDNhKMaiK5dDCZzUdY+Z0TZ0ictl7lM3IZPo7qrO zW5x9s4R14rn/+3GNCijFJBzwkY38ZDoIZ+Q96rSBsCC57pt8Apt5Wc4rwMz4ftm7HlDJjAk6pMW3 Ema9JGXihaaeDqn6LQBgQeWFqLJf2XNExoy18+z7d5fkC4C45BpHKIBBBjq94Sm0l/cEC30YdKxz4 1sF9z/R4RbzVd3zf3bp2IYigwWzBLF7ZxZwEn+Y6aaw7Vm0QjTzBNi+FtiKUcwhvNZEr/pErvJGHS ORhw4sjsL3wd27KZ03NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzt4h-000000092Vz-3SV8; Tue, 10 Mar 2026 09:08:23 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzt4e-000000092T7-0tTH; Tue, 10 Mar 2026 09:08:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=x+sKkqEen+FTZVcatdq7BWmJBRObIwAqW8MBSeFsbCg=; b=2P8w16KW4mcJ4VoQcD9GwW+Aaw LPnWPTjV+iBSgpGU8VvlZBgivFQ41jbbUv9xPLTe0UGiC2O/TtxW9n87YjtaKXtEvok+d9X3m90n3 88MyVWdnk4KdCug4lCgmQ65VmF5YA3tIEvuVR5jNAJV+kyyiI3aJ/12D7cJW361aI64t62QfKt+G8 DpRgtf8aKTCqaf2K91HStN6cfzfIMJzfn16r4ZEdGteuKTcM5375CxPjFb+Zcjq9TyhP53oWNANrb QG5VUTphEsm3do+5av7k096Uzt/+LkiRWIWXHy5//oKgMhx3VYbZAmsubGNimoJORazjXzWfE9QP0 iOm5zq+A==; From: Heiko Stuebner To: Vladimir Oltean Cc: linux-phy@lists.infradead.org, Vinod Koul , Neil Armstrong , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, spacemit@lists.linux.dev, UNGLinuxDriver@microchip.com, Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH v3 phy-next 10/24] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node Date: Tue, 10 Mar 2026 10:08:07 +0100 Message-ID: <2772778.X9hSmTKtgW@phil> In-Reply-To: <20260310083752.ms6u4qpy3snl4h6w@skbuf> References: <20260309190842.927634-1-vladimir.oltean@nxp.com> <2218670.OBFZWjSADL@phil> <20260310083752.ms6u4qpy3snl4h6w@skbuf> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260310_020820_252540_E1A53DBC X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org QW0gRGllbnN0YWcsIDEwLiBNw6RyeiAyMDI2LCAwOTozNzo1MiBNaXR0ZWxldXJvcMOkaXNjaGUg Tm9ybWFsemVpdCBzY2hyaWViIFZsYWRpbWlyIE9sdGVhbjoKPiBPbiBUdWUsIE1hciAxMCwgMjAy NiBhdCAwOToyNDo0M0FNICswMTAwLCBIZWlrbyBTdHVlYm5lciB3cm90ZToKPiA+IEFtIE1vbnRh ZywgOS4gTcOkcnogMjAyNiwgMjA6MDg6MjggTWl0dGVsZXVyb3DDpGlzY2hlIE5vcm1hbHplaXQg c2NocmllYiBWbGFkaW1pciBPbHRlYW46Cj4gPiA+IFRoZSBkd19oZG1pLXJvY2tjaGlwIGRyaXZl ciB2YWxpZGF0ZXMgcGl4ZWwgY2xvY2sgcmF0ZXMgYWdhaW5zdCB0aGUKPiA+ID4gSERNSSBQSFkn cyBpbnRlcm5hbCBjbG9jayBwcm92aWRlciBvbiBjZXJ0YWluIFNvQ3MgbGlrZSBSSzMzMjguCj4g PiA+IFRoaXMgaXMgY3VycmVudGx5IGFjaGlldmVkIGJ5IGRlcmVmZXJlbmNpbmcgaGRtaS0+cGh5 LT5kZXYub2Zfbm9kZQo+ID4gPiB0byBvYnRhaW4gdGhlIHByb3ZpZGVyIG5vZGUsIHdoaWNoIHZp b2xhdGVzIHRoZSBHZW5lcmljIFBIWSBBUEkncwo+ID4gPiBlbmNhcHN1bGF0aW9uICh0aGUgZ29h bCBpcyBmb3Igc3RydWN0IHBoeSB0byBiZSBhbiBvcGFxdWUgcG9pbnRlcikuCj4gPiA+IAo+ID4g PiBSZWZhY3RvciBkd19oZG1pX3JvY2tjaGlwX2JpbmQoKSB0byBwZXJmb3JtIGEgbWFudWFsIHBo YW5kbGUgbG9va3VwCj4gPiA+IG9uIHRoZSAiaGRtaSIgUEhZIGluZGV4IHdpdGhpbiB0aGUgY29u dHJvbGxlcidzIERUIG5vZGUuIFRoaXMgcHJvdmlkZXMKPiA+ID4gYSBwYXJhbGxlbCBwYXRoIHRv IHRoZSBjbG9jayBwcm92aWRlcidzIE9GIG5vZGUgd2l0aG91dCByZWx5aW5nIG9uIHRoZQo+ID4g PiBpbnRlcm5hbCBzdHJ1Y3R1cmUgb2YgdGhlIHN0cnVjdCBwaHkgaGFuZGxlLgo+ID4gPiAKPiA+ ID4gU2lnbmVkLW9mZi1ieTogVmxhZGltaXIgT2x0ZWFuIDx2bGFkaW1pci5vbHRlYW5AbnhwLmNv bT4KPiA+ID4gLS0tCj4gPiA+IENjOiBTYW5keSBIdWFuZyA8aGpjQHJvY2stY2hpcHMuY29tPgo+ ID4gPiBDYzogIkhlaWtvIFN0w7xibmVyIiA8aGVpa29Ac250ZWNoLmRlPgo+ID4gPiBDYzogQW5k eSBZYW4gPGFuZHkueWFuQHJvY2stY2hpcHMuY29tPgo+ID4gPiBDYzogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ID4gQ2M6IE1heGltZSBS aXBhcmQgPG1yaXBhcmRAa2VybmVsLm9yZz4KPiA+ID4gQ2M6IFRob21hcyBaaW1tZXJtYW5uIDx0 emltbWVybWFubkBzdXNlLmRlPgo+ID4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGdtYWls LmNvbT4KPiA+ID4gQ2M6IFNpbW9uYSBWZXR0ZXIgPHNpbW9uYUBmZndsbC5jaD4KPiA+ID4gCj4g PiA+IHYxLT52Mzogbm9uZQo+ID4gPiAtLS0KPiA+IAo+ID4gWy4uLl0KPiA+IAo+ID4gPiBAQCAt NTg4LDEzICs1ODksMTcgQEAgc3RhdGljIGludCBkd19oZG1pX3JvY2tjaGlwX2JpbmQoc3RydWN0 IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsCj4gPiA+ICAJCXJldHVybiBkZXZf ZXJyX3Byb2JlKGhkbWktPmRldiwgcmV0LCAiZmFpbGVkIHRvIGdldCBwaHlcbiIpOwo+ID4gPiAg CX0KPiA+ID4gIAo+ID4gPiAtCWlmIChoZG1pLT5waHkpIHsKPiA+IAo+ID4gbml0OiBhIGNvbW1l bnQgd291bGQgYmUgbmljZSBoZXJlLiBJLmUuIGhkbWktPnBoeSBiZWluZyBhbiBvcGFxdWUgcG9p bnRlcgo+ID4gc28gY2hlY2tpbmcgaGRtaS0+cGh5ICE9IE5VTEwgaXMgbm90IHBvc3NpYmxlLgo+ ID4gCj4gPiBXaXRoIHRoYXQgYmVpbmcgYSAiZ29hbCIsIEkgYXNzdW1lIHRoYXQgaW5mb3JtYXRp b24gaXMgbm90IHdpZGVseSBzcHJlYWQKPiA+IHNvIHRoaXMgd291bGQgcHJldmVudCB0aGUgbmV4 dCBkZXZlbG9wZXIgdHJ5aW5nIHRvIGNoYW5nZSBpdCBiYWNrIHRvCj4gPiAiaWYgKGhkbWktPnBo eSkiIHdoaWxlIHRoYXQgaGFuZGxpbmcgY2hhbmdlIHRyaWNrbGVzIGRvd24uCj4gCj4gVGVzdGlu ZyB0aGUgTlVMTCBxdWFsaXR5IG9mICJzdHJ1Y3QgcGh5ICpwaHkiIGlzIHN0aWxsIHBvc3NpYmxl IGFuZCBsZWdhbC4KPiBJdCBtZWFucyB0aGF0IHlvdSBjYWxsZWQgYW4gIm9wdGlvbmFsIiB2YXJp YW50IG9mIHBoeV9nZXQoKSwgYW5kIHRoZXJlCj4gd2FzIG5vIFBIWS4KCm9rLCBJJ2xsIGtlZXAg dGhhdCBpbiBtaW5kIDotKQoKCkhlaWtvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcmlzY3YK