From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters. Date: Mon, 09 Nov 2015 20:49:18 +0100 Message-ID: <2772927.crXiDc9cOV@phil> References: <1445267270-23126-1-git-send-email-Liviu.Dudau@arm.com> <20151109120334.GZ8644@n2100.arm.linux.org.uk> <20151109120720.GF963@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20151109120720.GF963@e106497-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: Russell King - ARM Linux , Daniel Vetter , LKML , dri-devel , linux-rockchip , LAKML List-Id: linux-rockchip.vger.kernel.org SGkgTGl2aXUsCgpBbSBNb250YWcsIDkuIE5vdmVtYmVyIDIwMTUsIDEyOjA3OjIwIHNjaHJpZWIg TGl2aXUgRHVkYXU6Cj4gT24gTW9uLCBOb3YgMDksIDIwMTUgYXQgMTI6MDM6MzVQTSArMDAwMCwg UnVzc2VsbCBLaW5nIC0gQVJNIExpbnV4IHdyb3RlOgo+ID4gT24gTW9uLCBOb3YgMDksIDIwMTUg YXQgMTE6NTc6MjdBTSArMDAwMCwgTGl2aXUgRHVkYXUgd3JvdGU6Cj4gPiA+IE1lYW53aGlsZSwg d2hhdCBpcyB5b3VyIHN1Z2dlc3Rpb24gcmVnYXJkaW5nIHRoZSBwYXRjaHNldC4gSSd2ZSBzZWVu IERhdmlkIGhhcwo+ID4gPiBzZW50IExpbnVzIGEgcHVsbCByZXF1ZXN0IGZvciA0LjQtcmMxIHRo YXQgaW5jbHVkZXMgaXQuIFNob3VsZCB3ZSBzZW5kIGEKPiA+ID4gcmV2ZXJ0IGZvciByb2NrY2hp cCBjb21taXQgYW5kIHRoZW4gcGF0Y2ggbGF0ZXIgdGhlIGZ1bmN0aW9uPwo+ID4gCj4gPiBJdCBk ZWZpbml0ZWx5IG5lZWRzIHRvIGJlIGZpeGVkLCBhbmQgSSdkIHN1Z2dlc3QgaXRzIGVhcmx5IGVu b3VnaCBpbiB0aGUKPiA+IC1yYyBjeWNsZSAod2hpY2ggaGFzbid0IGJlZ3VuIHlldCkgdG8gc2lt cGx5IGZpeCBkcm1fb2ZfY29tcG9uZW50X3Byb2JlKCkKPiA+IHRvIHRha2UgdHdvIGNvbXBhcmUg ZnVuY3Rpb25zLgo+IAo+IEkgc3RpbGwgZG9uJ3QgaGF2ZSBhIFJvY2tjaGlwIGJvYXJkIHRvIHRl c3QgdGhlIHBhdGNoLCBzbyBJIG5lZWQgdG8gZmluZCBvdXQKPiBzb21lb25lIHdpbGxpbmcgdG8g dGVzdCB0aGVtLiBNYXJrPwoKSSBvZiBjb3Vyc2UgYWxzbyBoYXZlIGEgcGxldGhvcmEgb2Ygcm9j a2NoaXAgYm9hcmRzLCBzbyBjYW4gdGVzdCBzdHVmZgphcyB3ZWxsLgoKCkhlaWtvCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Mon, 09 Nov 2015 20:49:18 +0100 Subject: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters. In-Reply-To: <20151109120720.GF963@e106497-lin.cambridge.arm.com> References: <1445267270-23126-1-git-send-email-Liviu.Dudau@arm.com> <20151109120334.GZ8644@n2100.arm.linux.org.uk> <20151109120720.GF963@e106497-lin.cambridge.arm.com> Message-ID: <2772927.crXiDc9cOV@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Liviu, Am Montag, 9. November 2015, 12:07:20 schrieb Liviu Dudau: > On Mon, Nov 09, 2015 at 12:03:35PM +0000, Russell King - ARM Linux wrote: > > On Mon, Nov 09, 2015 at 11:57:27AM +0000, Liviu Dudau wrote: > > > Meanwhile, what is your suggestion regarding the patchset. I've seen David has > > > sent Linus a pull request for 4.4-rc1 that includes it. Should we send a > > > revert for rockchip commit and then patch later the function? > > > > It definitely needs to be fixed, and I'd suggest its early enough in the > > -rc cycle (which hasn't begun yet) to simply fix drm_of_component_probe() > > to take two compare functions. > > I still don't have a Rockchip board to test the patch, so I need to find out > someone willing to test them. Mark? I of course also have a plethora of rockchip boards, so can test stuff as well. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbbKITtn (ORCPT ); Mon, 9 Nov 2015 14:49:43 -0500 Received: from gloria.sntech.de ([95.129.55.99]:34877 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbbKITtm (ORCPT ); Mon, 9 Nov 2015 14:49:42 -0500 From: Heiko Stuebner To: Liviu Dudau Cc: Russell King - ARM Linux , Mark yao , David Airlie , Daniel Vetter , Philipp Zabel , dri-devel , linux-rockchip , LAKML , LKML Subject: Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters. Date: Mon, 09 Nov 2015 20:49:18 +0100 Message-ID: <2772927.crXiDc9cOV@phil> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: <20151109120720.GF963@e106497-lin.cambridge.arm.com> References: <1445267270-23126-1-git-send-email-Liviu.Dudau@arm.com> <20151109120334.GZ8644@n2100.arm.linux.org.uk> <20151109120720.GF963@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liviu, Am Montag, 9. November 2015, 12:07:20 schrieb Liviu Dudau: > On Mon, Nov 09, 2015 at 12:03:35PM +0000, Russell King - ARM Linux wrote: > > On Mon, Nov 09, 2015 at 11:57:27AM +0000, Liviu Dudau wrote: > > > Meanwhile, what is your suggestion regarding the patchset. I've seen David has > > > sent Linus a pull request for 4.4-rc1 that includes it. Should we send a > > > revert for rockchip commit and then patch later the function? > > > > It definitely needs to be fixed, and I'd suggest its early enough in the > > -rc cycle (which hasn't begun yet) to simply fix drm_of_component_probe() > > to take two compare functions. > > I still don't have a Rockchip board to test the patch, so I need to find out > someone willing to test them. Mark? I of course also have a plethora of rockchip boards, so can test stuff as well. Heiko