From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbbK0OOl (ORCPT ); Fri, 27 Nov 2015 09:14:41 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:53945 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754705AbbK0OOj (ORCPT ); Fri, 27 Nov 2015 09:14:39 -0500 From: Arnd Bergmann Cc: Thomas Winischhofer , Jean-Christophe Plagniol-Villard , linux-kernel@vger.kernel.org Subject: [PATCH] fbdev: sis: enforce selection of at least one backend Date: Fri, 27 Nov 2015 15:12:03 +0100 Message-ID: <2773236.jQdVLDMmiK@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:y89NRXu0uNf+VDuiKDqZwjDrCo/wvk/KH0dfc1HUPb+yUITAOY0 2SfUHF149mFJiNr/z1Cw7hpMQSPUvVZlur2lV3uhGMQ+TOwkHeCgHH5586ZlBknYEfHX52Y rcE7kAEsy9IHD1xSdzgPNTU1METGIdXhjmBeppZIKQxgsT/myFScu0uHxndW2ZpY202uTln xRVj/vx01BqL6QCc5VNTw== X-UI-Out-Filterresults: notjunk:1;V01:K0:wGS2eQgOOYA=:AR8oFOiqFpFIgqIrQwZmEl SvXH4fC+zswgt0/+J9EIj3+97ausIm0xjfC8pwVAVENcD6KhVWOMWpGU+3nBfkR6FPHzBB11K 77Plr1nQnX0mXoLY3oo0U9L7cknNFyiED6DI07pkDDMQLnf1lo0ZnRDNMofh7RUXzdiUDwoDr tHXveSW5uPpFXrF10zpQLyWEWkq94PFQYF7+dPppXVVtStouUJP0akOM/m9QOenHc15F9BBm5 SbVzuXRyEmOUOiofTcxWMK2NbTDH5QdqBDsGx8Cz0AUuxYxb6rI1tIJVn3UKvJRYLnLrUUaXZ xL1S1+L1wzWx5qkdIS6PehLeQbK8KMCrJaB27m8haxBICV5NxzDOwhVDCFMqOo4XYQ3H0SdT6 iufXVX4qhdWL0DIVprmrYvjfNnB6v2F14m1ic3rklcoDyEPbMXos9i6sUOoXXqE3vyQqVwXIj inazhMBzcAmTpNnhZLgA5LzZ2JKywRxHf9+6FhNiD344iBjRx95InQoyYB2jWSrcurMfdTvEx XbnMrbAkPCIak0xpizvF9mkeDDE4d+3fv6aGpDVuxyv1tYMKr8rYDCp6aH/GWmB+l7aiMyrai xQJH7i7KwthIfZzTu4t3XsjAd52S6sbrKJcHLoIYT+2FyV5D6RkUzIpLaVI5uxgxmSOekHdXI SwoJn5Msv11cIQvXhf0jOTLvcG5Sxj64RfuoLFRfOHvW7u4lnjKB40agnrTscfEm2JK8hllAd Yzli+BqWuPnfvgww To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sis framebuffer driver complains with a compile-time warning if neither the FB_SIS_300 nor FB_SIS_315 symbols are selected: drivers/video/fbdev/sis/sis_main.c:61:2: warning: #warning Neither CONFIG_FB_SIS_300 nor CONFIG_FB_SIS_315 is se This is reasonable because it doesn't work in that case, but it's also annoying for randconfig builds and is one of the most common warnings I'm seeing on ARM now. This changes the Kconfig logic to prevent the silly configuration, by always selecting the FB_SIS_300 variant if the other one is not set. Signed-off-by: Arnd Bergmann diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e6d16d65e4e6..8a27c1443d01 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1506,6 +1506,7 @@ config FB_SIS select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT select FB_BOOT_VESA_SUPPORT if FB_SIS = y + select FB_SIS_300 if !FB_SIS_315 help This is the frame buffer device driver for the SiS 300, 315, 330 and 340 series as well as XGI V3XT, V5, V8, Z7 graphics chipsets.