Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Arvind,

Thank you for the patch.

On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote:
> snd_pcm_ops are not supposed to change at runtime. All functions
> working with snd_pcm_ops provided by <sound/pcm.h> work with
> const snd_pcm_ops. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index
> 8f2d137..cf3f0ca 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct
> snd_pcm_substream *substream) return bytes_to_frames(runtime,
> dw->buf_offset);
>  }
> 
> -static struct snd_pcm_ops snd_dw_hdmi_ops = {
> +static const struct snd_pcm_ops snd_dw_hdmi_ops = {
>  	.open = dw_hdmi_open,
>  	.close = dw_hdmi_close,
>  	.ioctl = snd_pcm_lib_ioctl,

-- 
Regards,

Laurent Pinchart