From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] app/test: enhance sanity script Date: Mon, 14 May 2018 17:29:41 +0200 Message-ID: <27756474.fd2W5nfMBH@xps> References: <1524835241-12778-1-git-send-email-reshma.pattan@intel.com> <2992140.TScDacoaO3@xps> <3AEA2BF9852C6F48A459DA490692831F2A2F0B5C@irsmsx110.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Parthasarathy, JananeeX M" , "dev@dpdk.org" , "Burakov, Anatoly" , "Jain, Deepak K" To: "Pattan, Reshma" Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B57831C91A for ; Mon, 14 May 2018 17:29:43 +0200 (CEST) In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2F0B5C@irsmsx110.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/05/2018 17:26, Pattan, Reshma: > Hi Thomas, > > > > 2. Fixed in autotest_test_funcs.py to handle test cases which returns > > > "Skipped" as result. > > > The issue was skipped test cases got timed out, causing delay in > > > sanity script execution. > > > 3. Enhanced support for FreeBSD, > > > as FreeBSD doesn't support socket-mem, file-prefix options. > > > > Please do 3 patches. > > Why do we need 3 patches here? Any reason? Because it's easier to review and better for the history to have patches with only one goal. It is a basic rule: one fix = one patch. It is also easier to backport.