Re: [RFC v2 8/9] uapi: import VFIO header

[Thomas Monjalon <thomas@monjalon.net>]

06/09/2025 06:11, Stephen Hemminger:
> On Wed,  3 Sep 2025 17:17:58 +0200
> David Marchand <david.marchand@redhat.com> wrote:
> 
> > Import VFIO header (from v6.16) to be included in many parts of DPDK.
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> >  kernel/linux/uapi/linux/vfio.h | 1836 ++++++++++++++++++++++++++++++++
> >  kernel/linux/uapi/version      |    2 +-
> >  2 files changed, 1837 insertions(+), 1 deletion(-)
> >  create mode 100644 kernel/linux/uapi/linux/vfio.h
> 
> The linux kernel source tree has a well defined method for making exported
> uapi headers: 
> 	make headers_install
> 
> DPDK should not be inventing its own method for this.
> 
> If you use this on current released kernel (6.16) you will get slightly different file.
> The point of having DPDK vfio.h was to workaround case where distro was too old;
> not to be different.

The diff below is because of a different (but compatible) version.
I don't see the point about the method.

[...]
>  struct vfio_device_bind_iommufd {
>  	__u32		argsz;
>  	__u32		flags;
> +#define VFIO_DEVICE_BIND_FLAG_TOKEN (1 << 0)
>  	__s32		iommufd;
>  	__u32		out_devid;
> +	__aligned_u64	token_uuid_ptr;
>  };