From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind Date: Wed, 28 Feb 2018 15:37:40 +0100 Message-ID: <2776489.2p7NH6SBud@diego> References: <20180130202913.28724-1-thierry.escande@collabora.com> <20180130202913.28724-6-thierry.escande@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180130202913.28724-6-thierry.escande@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-rockchip@lists.infradead.org, Marc Zyngier Cc: Douglas Anderson , Thierry Escande , Lin Huang , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomasz Figa , Thierry Reding , Yakir Yang , Enric Balletbo i Serra , =?ISO-8859-1?Q?=D8rjan?= Eide , Haixia Shi , Zain Wang , Mark Yao List-Id: linux-rockchip.vger.kernel.org QW0gRGllbnN0YWcsIDMwLiBKYW51YXIgMjAxOCwgMjE6Mjg6MzUgQ0VUIHNjaHJpZWIgVGhpZXJy eSBFc2NhbmRlOgo+IEZyb206IHphaW4gd2FuZyA8d3p6QHJvY2stY2hpcHMuY29tPgo+IAo+IFRo ZSBicmlkZ2UgZG9lcyBub3QgbmVlZCB0byBiZSBwb3dlcmVkIGluIGFuYWxvZ2l4X2RwX2JpbmQo KSwgc28KPiByZW1vdmUgdGhlIGNhbGxzIHRvIHBtX3J1bnRpbWVfZ2V0KCkvcGh5X3Bvd2VyX29u KCkvYW5hbG9naXhfZHBfaW5pdF9kcCgpCj4gYXMgd2VsbCBhcyB0aGVpciBwb3dlci1vZmYgY291 bnRlcnBhcnRzLgo+IAo+IENjOiBTdMOpcGhhbmUgTWFyY2hlc2luIDxtYXJjaGV1QGNocm9taXVt Lm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiB6YWluIHdhbmcgPHd6ekByb2NrLWNoaXBzLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBDYWVzYXIgV2FuZyA8d3h0QHJvY2stY2hpcHMuY29tPgo+IFt0aGUgcGF0 Y2ggb3JpZ2luYWxseSBqdXN0IHJlbW92ZWQgdGhlIHBvd2VyX29uIHBvcnRpb24sIHNlYW5wYXVs IHJlbW92ZWQKPiB0aGUgcG93ZXIgb2ZmIGNvZGUgYXMgd2VsbCBhcyBpbXByb3ZlZCB0aGUgY29t bWl0IG1lc3NhZ2VdCj4gU2lnbmVkLW9mZi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1 bS5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogVGhpZXJyeSBFc2NhbmRlIDx0aGllcnJ5LmVzY2FuZGVA Y29sbGFib3JhLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9h bmFsb2dpeF9kcF9jb3JlLmMgfCAxMCAtLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFs b2dpeC9hbmFsb2dpeF9kcF9jb3JlLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9n aXgvYW5hbG9naXhfZHBfY29yZS5jIGluZGV4Cj4gY2I1ZTE4ZDZiYTA0Li4xNDc3ZWE5YmE4NWQg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9k cF9jb3JlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4 X2RwX2NvcmUuYwo+IEBAIC0xMzgyLDExICsxMzgyLDYgQEAgYW5hbG9naXhfZHBfYmluZChzdHJ1 Y3QgZGV2aWNlICpkZXYsIHN0cnVjdAo+IGRybV9kZXZpY2UgKmRybV9kZXYsCj4gCj4gIAlwbV9y dW50aW1lX2VuYWJsZShkZXYpOwo+IAo+IC0JcG1fcnVudGltZV9nZXRfc3luYyhkZXYpOwo+IC0J cGh5X3Bvd2VyX29uKGRwLT5waHkpOwo+IC0KPiAtCWFuYWxvZ2l4X2RwX2luaXRfZHAoZHApOwo+ IC0KPiAgCXJldCA9IGRldm1fcmVxdWVzdF90aHJlYWRlZF9pcnEoJnBkZXYtPmRldiwgZHAtPmly cSwKPiAgCQkJCQlhbmFsb2dpeF9kcF9oYXJkaXJxLAo+ICAJCQkJCWFuYWxvZ2l4X2RwX2lycV90 aHJlYWQsCgpOb3QgMTAwJSBzdXJlIGhlcmUsIGFzIHRoZSBkcml2ZXIgaGFzIHRoZSByZXF1ZXN0 LWlycSArIGRpc2FibGUtaXJxIGhhY2sKaGVyZS4gU28gYSBwZW5kaW5nIGludGVycnVwdCBjb3Vs ZCBwb3NzaWJseSBmaXJlIGJldHdlZW4gcmVxdWVzdCBhbmQKZGlzYWJsZS4KClJpZ2h0IG5vdyB0 aGUgYmxvY2sgc2hvdWxkIGJlIG9uLCBidXQgY2FuIGl0IHN0aWxsIGhhbmRsZSBzdWNoIGFuIGly cQp3aGVuIHRoZSBwb3dlciBpcyByZW1vdmVkPwoKU28gYmVmb3JlIHJlbW92aW5nIHRoZSBwb3dl ciBoZXJlLCB3ZSBtaWdodCB3YW50IHNvbWV0aGluZwpzaW1pbGFyIHRvIHdoYXQgTWFyYyBwb3N0 ZWQgZm9yIHRoZSB2b3AgWzBdIGZvciB0aGUgYW5hbG9naXgtZHA/CgoKSGVpa28KClswXSBodHRw czovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzEwMjEwNTEzLwoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752807AbeB1OiA convert rfc822-to-8bit (ORCPT ); Wed, 28 Feb 2018 09:38:00 -0500 Received: from gloria.sntech.de ([95.129.55.99]:55670 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbeB1Oh6 (ORCPT ); Wed, 28 Feb 2018 09:37:58 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-rockchip@lists.infradead.org, Marc Zyngier Cc: Thierry Escande , Archit Taneja , Inki Dae , Thierry Reding , Sandy Huang , Sean Paul , David Airlie , Tomasz Figa , Enric Balletbo i Serra , Zain Wang , Lin Huang , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yakir Yang , =?ISO-8859-1?Q?=D8rjan?= Eide , Mark Yao , Haixia Shi Subject: Re: [PATCH v3 05/43] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind Date: Wed, 28 Feb 2018 15:37:40 +0100 Message-ID: <2776489.2p7NH6SBud@diego> In-Reply-To: <20180130202913.28724-6-thierry.escande@collabora.com> References: <20180130202913.28724-1-thierry.escande@collabora.com> <20180130202913.28724-6-thierry.escande@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 30. Januar 2018, 21:28:35 CET schrieb Thierry Escande: > From: zain wang > > The bridge does not need to be powered in analogix_dp_bind(), so > remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() > as well as their power-off counterparts. > > Cc: Stéphane Marchesin > Signed-off-by: zain wang > Signed-off-by: Caesar Wang > [the patch originally just removed the power_on portion, seanpaul removed > the power off code as well as improved the commit message] > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index > cb5e18d6ba04..1477ea9ba85d 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -1382,11 +1382,6 @@ analogix_dp_bind(struct device *dev, struct > drm_device *drm_dev, > > pm_runtime_enable(dev); > > - pm_runtime_get_sync(dev); > - phy_power_on(dp->phy); > - > - analogix_dp_init_dp(dp); > - > ret = devm_request_threaded_irq(&pdev->dev, dp->irq, > analogix_dp_hardirq, > analogix_dp_irq_thread, Not 100% sure here, as the driver has the request-irq + disable-irq hack here. So a pending interrupt could possibly fire between request and disable. Right now the block should be on, but can it still handle such an irq when the power is removed? So before removing the power here, we might want something similar to what Marc posted for the vop [0] for the analogix-dp? Heiko [0] https://patchwork.kernel.org/patch/10210513/