All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/1] mtd: mtdram: Add parameter for setting writebuf size
Date: Wed, 02 Mar 2016 11:41:34 +0100	[thread overview]
Message-ID: <2781096.oJXdWOB4df@ws-stein> (raw)
In-Reply-To: <CAFLxGvzbrqmeepS_kK3KOun+x7XTTN=PL0WO_BH-VOVYXxJddw@mail.gmail.com>

On Wednesday 02 March 2016 11:23:59, Richard Weinberger wrote:
> On Wed, Mar 2, 2016 at 10:45 AM, Alexander Stein
> <alexander.stein@systec-electronic.com> wrote:
> > ubifs uses the write buffer size in recovery algorithm. When inspecting
> > an unclean ubifs recovery fails with writebuf size 64 in mtdram while
> > recovery on actual mtd device with writebuf size of 1024 succeeds.
> > So add a parameter for setting this property.
> 
> Can it be that you've tested an NAND image on mtdram?

Nope. We copied that image within barebox from device /dev/nor0 (the whole 128MiB NOR flash) and used that in mtdram.
Unfortunately mounting that "broken" ubifs in barebox suffers from essentially the same problem: using a different writebuf size for recovery results in failure. But that's another issue.
The apparently important changes in linux are the commits:
428ff9d2e37d3a82af0f56b476f70c244cf550d1 ("UBIFS: remove dead code")
2765df7da540687c4d57ca840182122f074c5b9c ("UBIFS: use max_write_size during recovery")
With those two the writebuf size gets used by ubifs.

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein
SYS TEC electronic GmbH
alexander.stein@systec-electronic.com

Legal and Commercial Address:
Am Windrad 2
08468 Heinsdorfergrund
Germany

Office: +49 (0) 3765 38600-0
Fax:    +49 (0) 3765 38600-4100
 
Managing Directors:
	Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
	Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
Commercial Registry:
	Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010

  reply	other threads:[~2016-03-02 10:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02  9:45 [PATCH 1/1] mtd: mtdram: Add parameter for setting writebuf size Alexander Stein
2016-03-02 10:23 ` Richard Weinberger
2016-03-02 10:41   ` Alexander Stein [this message]
2016-03-02 12:47     ` Richard Weinberger
2016-03-02 13:01       ` Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2781096.oJXdWOB4df@ws-stein \
    --to=alexander.stein@systec-electronic.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.