From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 268E1C38142 for ; Wed, 1 Feb 2023 05:49:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mRwivXjDj0CVXgbhSHlNyg1Sz5Rxh9SIFZSNSBG72zY=; b=lIYQu74tZqtgeM NKL0mJc8jyXKvZQ2kRhrr4LTSAY42/hkszbp0gOnb4EXcjUuTa7SgN42y9lFheLjl7eaH+GMN9aA9 M0Mf64+4Q9y9lukIH7VSPz6FjyjB1EDzq+iwzfKFzN3re4HMxEw5eHRuHj0EXOurAXDIVAxEBRN7x 0Lbu7sld4JGRTPNS3TyXQ3IOfrKLA1v/RxNZLCkjX1ey4YWCt013FQLXBBMtAwQIZjRgIauzL1yv2 9SEoFXEzoh+JT+UCdcPP1nR8c6Pa6Ka6nYyOzHXozTyrl7q+T5/tabZyRcoLSMG/Yots9UGlrLFNp C0+j9JQfDb3n4tMUScYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pN5zh-00AKNR-2s; Wed, 01 Feb 2023 05:49:17 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pN5zc-00AKDu-Nk for linux-riscv@lists.infradead.org; Wed, 01 Feb 2023 05:49:15 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 17DB324E203; Wed, 1 Feb 2023 13:48:05 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 1 Feb 2023 13:48:04 +0800 Received: from EXMBX066.cuchost.com (172.16.7.66) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 1 Feb 2023 13:48:04 +0800 Received: from EXMBX066.cuchost.com ([fe80::5947:9245:907e:339f]) by EXMBX066.cuchost.com ([fe80::5947:9245:907e:339f%17]) with mapi id 15.00.1497.044; Wed, 1 Feb 2023 13:48:04 +0800 From: JeeHeng Sia To: Alexandre Ghiti , Conor Dooley CC: "paul.walmsley@sifive.com" , "palmer@dabbelt.com" , "aou@eecs.berkeley.edu" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leyfoon Tan , Mason Huo Subject: RE: [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Thread-Topic: [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Thread-Index: AQHZMi9WxT1gIxNRXUer5+u3a86Dx663AUwAgACtmgCAAe0oYA== Date: Wed, 1 Feb 2023 05:48:04 +0000 Message-ID: <27844cccf1894529a75106edeb7026bb@EXMBX066.cuchost.com> References: <20230127091051.1465278-1-jeeheng.sia@starfivetech.com> <20230127091051.1465278-4-jeeheng.sia@starfivetech.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_214913_100589_DF229DCB X-CRM114-Status: GOOD ( 25.19 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Alexandre Ghiti > Sent: Tuesday, 31 January, 2023 4:19 PM > To: Conor Dooley > Cc: JeeHeng Sia ; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; linux- > riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan ; Mason Huo > > Subject: Re: [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function > > Hi, > > On Mon, Jan 30, 2023 at 10:57 PM Conor Dooley wrote: > > > > +CC Alex > > > > On Fri, Jan 27, 2023 at 05:10:50PM +0800, Sia Jee Heng wrote: > > > Currently kernel_page_present() function doesn't support huge page > > > detection causes the function to mistakenly return false to the > > > hibernation core. > > > > This sounds like a bug & should have a fixes tag, no? I assume for > > whatever commit enabled huge page support... > > We don't support set_memory, which by the looks of things is the other > > usecase for this function, so probably doesn't need backporting. > > Maybe add this patch in the Fixes tag: commit 9e953cda5cdf ("riscv: > Introduce huge page support for 32/64bit kernel"). Sure, will add the fixes tag. > > > > > Alex, does this change look good to you? > > Yes, just one thing though: what about a pgd_leaf() test? Even if very > unlikely (I see x86 does not even test it), the privileged spec states > it is possible to have a 256TB page. I can add it in. But as you are probably aware that x86 and ARM don't even tested it. Thanks. > > Thanks, > > Alex > > > > > > Add huge page detection to the function to solve the problem. > > > > > > Signed-off-by: Sia Jee Heng > > > Reviewed-by: Ley Foon Tan > > > Reviewed-by: Mason Huo > > > --- > > > arch/riscv/mm/pageattr.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c > > > index 86c56616e5de..792b8d10cdfc 100644 > > > --- a/arch/riscv/mm/pageattr.c > > > +++ b/arch/riscv/mm/pageattr.c > > > @@ -221,14 +221,20 @@ bool kernel_page_present(struct page *page) > > > p4d = p4d_offset(pgd, addr); > > > if (!p4d_present(*p4d)) > > > return false; > > > + if (p4d_leaf(*p4d)) > > > + return true; > > > > > > pud = pud_offset(p4d, addr); > > > if (!pud_present(*pud)) > > > return false; > > > + if (pud_leaf(*pud)) > > > + return true; > > > > > > pmd = pmd_offset(pud, addr); > > > if (!pmd_present(*pmd)) > > > return false; > > > + if (pmd_leaf(*pmd)) > > > + return true; > > > > > > pte = pte_offset_kernel(pmd, addr); > > > return pte_present(*pte); > > > -- > > > 2.34.1 > > > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F35C38142 for ; Wed, 1 Feb 2023 05:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231296AbjBAFs0 (ORCPT ); Wed, 1 Feb 2023 00:48:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230009AbjBAFsR (ORCPT ); Wed, 1 Feb 2023 00:48:17 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FD64B76A for ; Tue, 31 Jan 2023 21:48:08 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 17DB324E203; Wed, 1 Feb 2023 13:48:05 +0800 (CST) Received: from EXMBX062.cuchost.com (172.16.6.62) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 1 Feb 2023 13:48:04 +0800 Received: from EXMBX066.cuchost.com (172.16.7.66) by EXMBX062.cuchost.com (172.16.6.62) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 1 Feb 2023 13:48:04 +0800 Received: from EXMBX066.cuchost.com ([fe80::5947:9245:907e:339f]) by EXMBX066.cuchost.com ([fe80::5947:9245:907e:339f%17]) with mapi id 15.00.1497.044; Wed, 1 Feb 2023 13:48:04 +0800 From: JeeHeng Sia To: Alexandre Ghiti , Conor Dooley CC: "paul.walmsley@sifive.com" , "palmer@dabbelt.com" , "aou@eecs.berkeley.edu" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leyfoon Tan , Mason Huo Subject: RE: [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Thread-Topic: [PATCH v3 3/4] RISC-V: mm: Enable huge page support to kernel_page_present() function Thread-Index: AQHZMi9WxT1gIxNRXUer5+u3a86Dx663AUwAgACtmgCAAe0oYA== Date: Wed, 1 Feb 2023 05:48:04 +0000 Message-ID: <27844cccf1894529a75106edeb7026bb@EXMBX066.cuchost.com> References: <20230127091051.1465278-1-jeeheng.sia@starfivetech.com> <20230127091051.1465278-4-jeeheng.sia@starfivetech.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [202.188.176.82] x-yovoleruleagent: yovoleflag Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQWxleGFuZHJlIEdoaXRp IDxhbGV4Z2hpdGlAcml2b3NpbmMuY29tPg0KPiBTZW50OiBUdWVzZGF5LCAzMSBKYW51YXJ5LCAy MDIzIDQ6MTkgUE0NCj4gVG86IENvbm9yIERvb2xleSA8Y29ub3JAa2VybmVsLm9yZz4NCj4gQ2M6 IEplZUhlbmcgU2lhIDxqZWVoZW5nLnNpYUBzdGFyZml2ZXRlY2guY29tPjsgcGF1bC53YWxtc2xl eUBzaWZpdmUuY29tOyBwYWxtZXJAZGFiYmVsdC5jb207IGFvdUBlZWNzLmJlcmtlbGV5LmVkdTsg bGludXgtDQo+IHJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtl cm5lbC5vcmc7IExleWZvb24gVGFuIDxsZXlmb29uLnRhbkBzdGFyZml2ZXRlY2guY29tPjsgTWFz b24gSHVvDQo+IDxtYXNvbi5odW9Ac3RhcmZpdmV0ZWNoLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQ QVRDSCB2MyAzLzRdIFJJU0MtVjogbW06IEVuYWJsZSBodWdlIHBhZ2Ugc3VwcG9ydCB0byBrZXJu ZWxfcGFnZV9wcmVzZW50KCkgZnVuY3Rpb24NCj4gDQo+IEhpLA0KPiANCj4gT24gTW9uLCBKYW4g MzAsIDIwMjMgYXQgMTA6NTcgUE0gQ29ub3IgRG9vbGV5IDxjb25vckBrZXJuZWwub3JnPiB3cm90 ZToNCj4gPg0KPiA+ICtDQyBBbGV4DQo+ID4NCj4gPiBPbiBGcmksIEphbiAyNywgMjAyMyBhdCAw NToxMDo1MFBNICswODAwLCBTaWEgSmVlIEhlbmcgd3JvdGU6DQo+ID4gPiBDdXJyZW50bHkga2Vy bmVsX3BhZ2VfcHJlc2VudCgpIGZ1bmN0aW9uIGRvZXNuJ3Qgc3VwcG9ydCBodWdlIHBhZ2UNCj4g PiA+IGRldGVjdGlvbiBjYXVzZXMgdGhlIGZ1bmN0aW9uIHRvIG1pc3Rha2VubHkgcmV0dXJuIGZh bHNlIHRvIHRoZQ0KPiA+ID4gaGliZXJuYXRpb24gY29yZS4NCj4gPg0KPiA+IFRoaXMgc291bmRz IGxpa2UgYSBidWcgJiBzaG91bGQgaGF2ZSBhIGZpeGVzIHRhZywgbm8/IEkgYXNzdW1lIGZvcg0K PiA+IHdoYXRldmVyIGNvbW1pdCBlbmFibGVkIGh1Z2UgcGFnZSBzdXBwb3J0Li4uDQo+ID4gV2Ug ZG9uJ3Qgc3VwcG9ydCBzZXRfbWVtb3J5LCB3aGljaCBieSB0aGUgbG9va3Mgb2YgdGhpbmdzIGlz IHRoZSBvdGhlcg0KPiA+IHVzZWNhc2UgZm9yIHRoaXMgZnVuY3Rpb24sIHNvIHByb2JhYmx5IGRv ZXNuJ3QgbmVlZCBiYWNrcG9ydGluZy4NCj4gDQo+IE1heWJlIGFkZCB0aGlzIHBhdGNoIGluIHRo ZSBGaXhlcyB0YWc6IGNvbW1pdCA5ZTk1M2NkYTVjZGYgKCJyaXNjdjoNCj4gSW50cm9kdWNlIGh1 Z2UgcGFnZSBzdXBwb3J0IGZvciAzMi82NGJpdCBrZXJuZWwiKS4NClN1cmUsIHdpbGwgYWRkIHRo ZSBmaXhlcyB0YWcuDQo+IA0KPiA+DQo+ID4gQWxleCwgZG9lcyB0aGlzIGNoYW5nZSBsb29rIGdv b2QgdG8geW91Pw0KPiANCj4gWWVzLCBqdXN0IG9uZSB0aGluZyB0aG91Z2g6IHdoYXQgYWJvdXQg YSBwZ2RfbGVhZigpIHRlc3Q/IEV2ZW4gaWYgdmVyeQ0KPiB1bmxpa2VseSAoSSBzZWUgeDg2IGRv ZXMgbm90IGV2ZW4gdGVzdCBpdCksIHRoZSBwcml2aWxlZ2VkIHNwZWMgc3RhdGVzDQo+IGl0IGlz IHBvc3NpYmxlIHRvIGhhdmUgYSAyNTZUQiBwYWdlLg0KSSBjYW4gYWRkIGl0IGluLiBCdXQgYXMg eW91IGFyZSBwcm9iYWJseSBhd2FyZSB0aGF0IHg4NiBhbmQgQVJNIGRvbid0IGV2ZW4gdGVzdGVk IGl0LiBUaGFua3MuDQo+IA0KPiBUaGFua3MsDQo+IA0KPiBBbGV4DQo+IA0KPiA+DQo+ID4gPiBB ZGQgaHVnZSBwYWdlIGRldGVjdGlvbiB0byB0aGUgZnVuY3Rpb24gdG8gc29sdmUgdGhlIHByb2Js ZW0uDQo+ID4gPg0KPiA+ID4gU2lnbmVkLW9mZi1ieTogU2lhIEplZSBIZW5nIDxqZWVoZW5nLnNp YUBzdGFyZml2ZXRlY2guY29tPg0KPiA+ID4gUmV2aWV3ZWQtYnk6IExleSBGb29uIFRhbiA8bGV5 Zm9vbi50YW5Ac3RhcmZpdmV0ZWNoLmNvbT4NCj4gPiA+IFJldmlld2VkLWJ5OiBNYXNvbiBIdW8g PG1hc29uLmh1b0BzdGFyZml2ZXRlY2guY29tPg0KPiA+ID4gLS0tDQo+ID4gPiAgYXJjaC9yaXNj di9tbS9wYWdlYXR0ci5jIHwgNiArKysrKysNCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNl cnRpb25zKCspDQo+ID4gPg0KPiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcmlzY3YvbW0vcGFnZWF0 dHIuYyBiL2FyY2gvcmlzY3YvbW0vcGFnZWF0dHIuYw0KPiA+ID4gaW5kZXggODZjNTY2MTZlNWRl Li43OTJiOGQxMGNkZmMgMTAwNjQ0DQo+ID4gPiAtLS0gYS9hcmNoL3Jpc2N2L21tL3BhZ2VhdHRy LmMNCj4gPiA+ICsrKyBiL2FyY2gvcmlzY3YvbW0vcGFnZWF0dHIuYw0KPiA+ID4gQEAgLTIyMSwx NCArMjIxLDIwIEBAIGJvb2wga2VybmVsX3BhZ2VfcHJlc2VudChzdHJ1Y3QgcGFnZSAqcGFnZSkN Cj4gPiA+ICAgICAgIHA0ZCA9IHA0ZF9vZmZzZXQocGdkLCBhZGRyKTsNCj4gPiA+ICAgICAgIGlm ICghcDRkX3ByZXNlbnQoKnA0ZCkpDQo+ID4gPiAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsN Cj4gPiA+ICsgICAgIGlmIChwNGRfbGVhZigqcDRkKSkNCj4gPiA+ICsgICAgICAgICAgICAgcmV0 dXJuIHRydWU7DQo+ID4gPg0KPiA+ID4gICAgICAgcHVkID0gcHVkX29mZnNldChwNGQsIGFkZHIp Ow0KPiA+ID4gICAgICAgaWYgKCFwdWRfcHJlc2VudCgqcHVkKSkNCj4gPiA+ICAgICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOw0KPiA+ID4gKyAgICAgaWYgKHB1ZF9sZWFmKCpwdWQpKQ0KPiA+ID4g KyAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsNCj4gPiA+DQo+ID4gPiAgICAgICBwbWQgPSBwbWRf b2Zmc2V0KHB1ZCwgYWRkcik7DQo+ID4gPiAgICAgICBpZiAoIXBtZF9wcmVzZW50KCpwbWQpKQ0K PiA+ID4gICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7DQo+ID4gPiArICAgICBpZiAocG1kX2xl YWYoKnBtZCkpDQo+ID4gPiArICAgICAgICAgICAgIHJldHVybiB0cnVlOw0KPiA+ID4NCj4gPiA+ ICAgICAgIHB0ZSA9IHB0ZV9vZmZzZXRfa2VybmVsKHBtZCwgYWRkcik7DQo+ID4gPiAgICAgICBy ZXR1cm4gcHRlX3ByZXNlbnQoKnB0ZSk7DQo+ID4gPiAtLQ0KPiA+ID4gMi4zNC4xDQo+ID4gPg0K