All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
	Steve French <smfrench@gmail.com>, Tom Talpey <tom@talpey.com>,
	Long Li <longli@microsoft.com>,
	Paulo Alcantara <pc@manguebit.org>
Subject: Re: [PATCH v3 0/4] smb: smbdirect/client/server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks
Date: Wed, 26 Nov 2025 08:16:09 +0100	[thread overview]
Message-ID: <2786ee25-b543-48a8-8fff-e6c7ff341774@samba.org> (raw)
In-Reply-To: <CAKYAXd_HKKBKx_B7+Z+b_jt+rHazuMkskYYPAp6BROPuy0uBfA@mail.gmail.com>

Am 26.11.25 um 00:50 schrieb Namjae Jeon:
> On Tue, Nov 25, 2025 at 11:22 PM Stefan Metzmacher <metze@samba.org> wrote:
>>
>> Hi,
>>
>> here are some small cleanups for a problem Nanjae reported,
>> where two WARN_ON_ONCE(sc->status != ...) checks where triggered
>> by a Windows 11 client.
>>
>> The patches should relax the checks if an error happened before,
>> they are intended for 6.18 final, as far as I can see the
>> problem was introduced during the 6.18 cycle only.
>>
>> Given that v1 of this patchset produced a very useful WARN_ONCE()
>> message, I'd really propose to keep this for 6.18, also for the
>> client where the actual problem may not exists, but if they
>> exist, it will be useful to have the more useful messages
>> in 6.16 final.
> First, the warning message has been improved. Thanks.
> However, when copying a 6-7GB file on a Windows client, the following
> error occurs. These error messages did not occur when testing with the
> older ksmbd rdma(https://github.com/namjaejeon/ksmbd).

With transport_rdma.* from restored from 6.17?

metze

  parent reply	other threads:[~2025-11-26  7:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 14:21 [PATCH v3 0/4] smb: smbdirect/client/server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks Stefan Metzmacher
2025-11-25 14:21 ` [PATCH v3 1/4] smb: smbdirect: introduce SMBDIRECT_DEBUG_ERR_PTR() helper Stefan Metzmacher
2025-11-25 14:21 ` [PATCH v3 2/4] smb: smbdirect: introduce SMBDIRECT_CHECK_STATUS_{WARN,DISCONNECT}() Stefan Metzmacher
2025-11-25 14:21 ` [PATCH v3 3/4] smb: server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks in recv_done() and smb_direct_cm_handler() Stefan Metzmacher
2025-11-25 14:21 ` [PATCH v3 4/4] smb: client: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks in recv_done() and smbd_conn_upcall() Stefan Metzmacher
2025-11-25 23:50 ` [PATCH v3 0/4] smb: smbdirect/client/server: relax WARN_ON_ONCE(SMBDIRECT_SOCKET_*) checks Namjae Jeon
2025-11-26  1:07   ` Namjae Jeon
2025-11-27 15:54     ` Stefan Metzmacher
2025-11-28  3:18       ` Namjae Jeon
     [not found]         ` <CAH2r5mv0BLnF9+ori1ZfoaYfBLXcscjuFkkAjggSY+aroKDRiw@mail.gmail.com>
2025-11-28 10:17           ` Stefan Metzmacher
2025-11-28 12:11             ` Namjae Jeon
2025-11-28 13:35               ` Stefan Metzmacher
2025-11-28 15:00                 ` Namjae Jeon
2025-11-28 18:05             ` Steve French
2025-11-26  7:16   ` Stefan Metzmacher [this message]
2025-11-26 15:17     ` Namjae Jeon
2025-11-26 15:18       ` Stefan Metzmacher
2025-11-26 16:03         ` Stefan Metzmacher
2025-11-26 23:10           ` Namjae Jeon
2025-11-27 15:45             ` Stefan Metzmacher
2025-11-27 15:50               ` Stefan Metzmacher
2025-11-28  3:20                 ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2786ee25-b543-48a8-8fff-e6c7ff341774@samba.org \
    --to=metze@samba.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=pc@manguebit.org \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.