From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/3] mempool: fix segfault when shared mempool handler not linked Date: Mon, 03 Apr 2017 18:58:32 +0200 Message-ID: <2791910.qOPMfRUke8@xps13> References: <11490938158-936-1-git-send-email-shreyansh.jain@nxp.com> <1490938537-1177-1-git-send-email-shreyansh.jain@nxp.com> <20170331154924.3e6e117d@platinum> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Olivier Matz , dev@dpdk.org, hemant.agrawal@nxp.com, david.hunt@intel.com To: Shreyansh Jain Return-path: Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by dpdk.org (Postfix) with ESMTP id 257BC2B9B for ; Mon, 3 Apr 2017 18:58:33 +0200 (CEST) Received: by mail-wr0-f176.google.com with SMTP id w43so177210842wrb.0 for ; Mon, 03 Apr 2017 09:58:33 -0700 (PDT) In-Reply-To: <20170331154924.3e6e117d@platinum> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-31 15:49, Olivier Matz: > On Fri, 31 Mar 2017 11:05:35 +0530, Shreyansh Jain wrote: > > Fixes: 449c49b93a6b ("mempool: support handler operations") > > > > In case the stack or ring mempool handler are compiled as shared > > library and not linked in with test binary, segfault is reported. > > This is because return value of rte_mempool_set_ops_byname is not > > being checked in rte_mempool_ops_alloc. > > > > This patch handles error returned from rte_mempool_set_ops_byname > > when a mempool is not found. > > > > Signed-off-by: Shreyansh Jain > > Acked-by: Olivier Matz Series applied, thanks