Re: [PATCH] i40e: skip any phy config as a workaround

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-11-17 15:09, Helin Zhang:
> As firmware does not support any link control from software driver
> side, any phy config should be ignored as a workaround. Otherwise
> the link might not be up again after binding back to kernel driver.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
[...]
> +i40e_phy_conf_link(__rte_unused struct i40e_hw *hw,
> +		   __rte_unused uint8_t abilities,
> +		   __rte_unused uint8_t force_speed)
> +{
> +	/* Skip any phy config on both 10G and 40G interfaces, as a workaround
> +	 * for the link control limitation of that all link control should be
> +	 * handled by firmware. It should follow up if link control will be
> +	 * opened to software driver in future firmware versions.
> +	 */
>  	return I40E_SUCCESS;
>  }

An error code seems more appropriate.
But I guess you perfectly know what you do, so
Applied, thanks