All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
	ferruh.yigit@intel.com, stephen@networkplumber.org,
	konstantin.ananyev@intel.com
Subject: Re: [PATCH v2] eal: fix clang compilation error on ARM64
Date: Wed, 11 Apr 2018 22:42:55 +0200	[thread overview]
Message-ID: <2796123.plAjDWPncV@xps> (raw)
In-Reply-To: <20180411170150.11985-1-pbhagavatula@caviumnetworks.com>

11/04/2018 19:01, Pavan Nikhilesh:
> Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8).
> The error was:
> 	include/generic/rte_atomic.h:215:9: error:
> 		implicit declaration of function '__atomic_exchange_2'
> 		is invalid in C99
> 	include/generic/rte_atomic.h:494:9: error:
> 		implicit declaration of function '__atomic_exchange_4'
> 		is invalid in C99
> 	include/generic/rte_atomic.h:772:9: error:
> 		implicit declaration of function '__atomic_exchange_8'
> 		is invalid in C99
> 
> Fixes: ff2863570fcc ("eal: introduce atomic exchange operation")
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>

We did not understand why this error is seen only on ARM
(hopefully we won't discover it somewhere else),
but it is a pragmatic fix.

Applied, thanks

  reply	other threads:[~2018-04-11 20:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 11:01 [PATCH] eal: fix clang compilation error on ARM64 Pavan Nikhilesh
2018-04-06 16:24 ` Thomas Monjalon
2018-04-06 18:25   ` Pavan Nikhilesh
2018-04-10 15:07     ` Thomas Monjalon
2018-04-10 21:35       ` Thomas Monjalon
2018-04-11  8:38         ` Pavan Nikhilesh
2018-04-11  8:46           ` Thomas Monjalon
2018-04-11  9:00             ` Pavan Nikhilesh
2018-04-11 17:01 ` [PATCH v2] " Pavan Nikhilesh
2018-04-11 20:42   ` Thomas Monjalon [this message]
2018-04-11 21:48     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2796123.plAjDWPncV@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.