From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: lpspi: Simplify some error message
Date: Mon, 15 Aug 2022 13:06:34 +0200 [thread overview]
Message-ID: <2796602.mvXUDI8C0e@steina-w> (raw)
In-Reply-To: <253543c462b765eca40ba54c66f4e3fdf4acdeb7.1659735546.git.christophe.jaillet@wanadoo.fr>
Am Freitag, 5. August 2022, 23:39:19 CEST schrieb Christophe JAILLET:
> dev_err_probe() already prints the error code in a human readable way, so
> there is no need to duplicate it as a numerical value at the end of the
> message.
>
> Fixes: 12f62a857c83 ("spi: lpspi: Silence error message upon deferred
> probe") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/spi/spi-fsl-lpspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
> index 19b1f3d881b0..cbbe8bbef90a 100644
> --- a/drivers/spi/spi-fsl-lpspi.c
> +++ b/drivers/spi/spi-fsl-lpspi.c
> @@ -912,7 +912,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
>
> ret = devm_spi_register_controller(&pdev->dev, controller);
> if (ret < 0) {
> - dev_err_probe(&pdev->dev, ret, "spi_register_controller
error: %i\n",
> ret); + dev_err_probe(&pdev->dev, ret, "spi_register_controller
error\n");
> goto free_dma;
> }
Acked-By: Alexander Stein <alexander.stein@ew.tq-group.com>
next prev parent reply other threads:[~2022-08-15 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 21:39 [PATCH] spi: lpspi: Simplify some error message Christophe JAILLET
2022-08-15 11:06 ` Alexander Stein [this message]
2022-08-15 15:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2796602.mvXUDI8C0e@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.