Re: [PATCH V3] ovl: Allocate anonymous devs for lowerdirs

[Chandan Rajendra <chandan@linux.vnet.ibm.com>]

On Thursday, September 21, 2017 11:16:26 PM IST Amir Goldstein wrote:
> On Thu, Jul 27, 2017 at 9:24 AM, Chandan Rajendra
> <chandan@linux.vnet.ibm.com> wrote:
> > On Monday, July 24, 2017 2:47:22 PM IST Chandan Rajendra wrote:
> >> For stat(2) on lowerdir non-dir entries in non-samefs case, this commit
> >> provides unique values for st_dev. The unique values are obtained by
> >> allocating anonymous bdevs for each of the lowerdirs in the overlayfs
> >> instance.
> >>
> >> Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> >> ---
> >> Changelog:
> >>
> >> v2->v3: Optimize away O(n) search for pseudo dev in ovl_get_pseudo_dev().
> >>
> >> v1->v2: Drop code that provided unique st_dev across copy up.
> >>
> >
> > I have rebased Amir's "ovl: relax same fs constrain for constant st_ino"
> > patch on top of the changes made in this patch. The tree containing
> > the rebased patch can be found at
> > "https://github.com/chandanr/linux.git rework-anonymous-dev"
> >
> > I have tested this by executing unionmount-testsuite's "./run --ov --verify".
> >
> 
> 
> Chandan,
> 
> Can you rebase your work on v4.14-rc1?
> 
> You now need to add another patch to relax same fs constrain for
> constant d_ino in readdir.
> Note that you will also need to relax in ovl_cache_update_ino()
> WARN_ON_ONCE(dir->d_sb->s_dev != stat.dev)
> 
> unionmount-testsuite's --verify (non-samefs) does not verify d_ino and
> the your constant d_ino xfstest does not cover the non-samefs case.
> A new xfstest, a simple variant of your samefs xfstest should be sufficient.
> 

Sure, I will do that and post the patches soon.

-- 
chandan